Gitlab 13.9 • Hacker News Board

Re: Gitlab 13.9

#61

Post by weitzj » Wed, Feb 24, 2021, 6:12 PM UTC

jamesh-gl wrote: post #60

weitzj wrote: post #39

I have to use GitLab. But I really quite don’t get some features like: Multiple published html pages per job. Seems not possible: You have to have a special job name “pages” and your build artifacts have to be in a special directory “public” in order for this job to work correctly. Also collecting test coverage reports by grepping with a regex through your build stdout feels weird. These 2 examples leave a weird feel…

GitLab PM here. Great point on #2 about the regex. We have an open issue ( https://gitlab.com/gitlab-org/gitlab/-/issues/21549 ) to parse more data from an uploaded coverage report and coverage percentage seems like a great first step so you don't have to mess around with the regex. -James H, GitLab Product Manager, Verify:Testing

It would be fine if you could for example pick up cobertura reports or maybe some other coverage formats (Golang reports, Xcode coverage reports) I know I can do this with all my Jenkins plug-ins. And maybe GitLab does not want to do all of this and people should use Sonarqube instead. But it is hard to go to GitLab when I have seen the light with Jenkins.

Re: Gitlab 13.9

#62

Post by jamesh-gl » Wed, Feb 24, 2021, 7:34 PM UTC

weitzj wrote: post #61

jamesh-gl wrote: post #60

Earlier quoted context omitted.

GitLab PM here. Great point on #2 about the regex. We have an open issue ( https://gitlab.com/gitlab-org/gitlab/-/issues/21549 ) to parse more data from an uploaded coverage report and coverage percentage seems like a great first step so you don't have to mess around with the regex. -James H, GitLab Product Manager, Verify:Testing

It would be fine if you could for example pick up cobertura reports or maybe some other coverage formats (Golang reports, Xcode coverage reports) I know I can do this with all my Jenkins plug-ins. And maybe GitLab does not want to do all of this and people should use Sonarqube instead. But it is hard to go to GitLab when I have seen the light with Jenkins.

Cobertura is the first target report since it's the format that's supported by the Test Coverage Visualization feature (https://docs.gitlab.com/ee/user/project/merge_requests/test_...).

I'll make sure the other report types are on our list of future iterations as well.

Thanks!

-James H, GitLab Product Manager, Verify:Testing

Re: Gitlab 13.9

#63

Post by sdfhbdf » Thu, Feb 25, 2021, 10:13 AM UTC

phikai wrote: post #52

sdfhbdf wrote: post #32

Very welcome improvements in Code Review department. Really like the explicit Viewed checkbox (even though I noticed that the bolding in the sidebar with the file tree tried to solve the same problem) and really nice with the suggestions. My two top wishlist leftover items in that regard are 1. Marking whether a comment requests changes or not. This is of course straight out of GitHub, but I think their flow better m…

Hi! I'm the PM for Code Review at GitLab - thanks for all the feedback. The team really knocked it out of the park in 13.9 so it's great to see that being recognized. > 1. Marking whether a comment requests changes or not. This is of course straight out of GitHub, but I think their flow better matches what I found to be happening a in a lot of changes. I see such states for a Code review of a MR: Changes approved, Re…

Thanks for the reply. Nice to see you guys are so appreciative of feedback. Thanks for linking the issue I will probably track it now since I was not able to find the nomenclature to find it before. I will probably ask our company account manager to point out that we would be interested in this since we do pay for your product in the end.

Whenever Code review surpasses the UX of GitHub, and i think they're close but just have different approaches to some stuff I think GH for Teams will have no advantage over GitLab. GitLab CI blows GitHub out of the water in my experience.