Live data from Hacker News

Vuejs rejects close to 75% of outside contributions

merge-chance.info

81–90 of 92 posts

Re: Vuejs rejects close to 75% of outside contributions

#81
post #62

Earlier quoted context omitted.

On the contrary, the only people making a demand are developers who insist that their work does, or should, exist in a vacuum, outside of and independent of what is going on in the world, i.e. politics. Reality, however, is there, whether we would like it to be there or not. Look, I get it: sometimes you just want to put your head down and focus on technical details, and let someone else worry about the context. But…

> But keeping your head buried in the sand all the time isn't the answer. It isn't, but I can't see a benefit of dragging unrelated politics into software development, even though the topics might be important.

Developing software in ignorance of the surrounding social context is -- well, it's worse than writing a file picker and neglecting to add a thumbnail feature.

I recommend you read about Allison Parrish's new hacker ethic: http://opentranscripts.org/transcript/programming-forgetting...

The core questions she proposes are essential things every software professional should ask themselves and keep in mind as they work. The political context, and which players in that context benefit from the work you do, is not unrelated at all.

Re: Vuejs rejects close to 75% of outside contributions

#82

Looking at the PR history for the vuejs repo, I can't say that I'm surprised. Holy hell, what a wasteland.

Ya, here's some examples of spam: https://github.com/vuejs/vue/pull/11847/files https://github.com/vuejs/vue/pull/11853/files https://github.com/vuejs/vue/pull/11820/files https://github.com/vuejs/vue/pull/11818/files All within the last month. Maybe there's some tutorial for 'how to submit a PR on GitHub' that links to Vue.js and people are following that?

It would be neat if they could set up automatic filters based on the file type/size/etc. So they could automatically disallow any pull request to the README file for example.

Re: Vuejs rejects close to 75% of outside contributions

#83
post #54

That's the old Vue 2 repository, which has been pretty inactive for a while due to the full rewrite of Vue. Vue 3 (70.62% acceptance): https://merge-chance.info/target?repo=vuejs/vue-next Svelte (57.23% acceptance): https://merge-chance.info/target?repo=sveltejs/svelte React (45.99% acceptance): https://merge-chance.info/target?repo=facebook/react Angular (1.63% acceptance): https://merge-chance.info/target?repo=angu…

Side note: Angular tends to create new commits (keeping the author, changing the committer) instead of directly merging the PRs. The real acceptance rate seems to be high.

Re: Vuejs rejects close to 75% of outside contributions

#84
post #32

I wish the submitter added their comment or gave some context, if there is any. For me this is an arbitrary number for a random popular repository. Especially since the linked github project https://github.com/vuejs/vue is not the latest version of vue (see: https://github.com/vuejs/vue-next ).

Author here. I am still exploring useful metrics for classifying open source projects. My initial intent was to find a way to judge if given project is a good use of time for a first time contributor, someone not affiliated with original authors.

> My initial intent was to find a way to judge if given project is a good use of time for a first time contributor, someone not affiliated with original authors.

so what does this contextless number you submitted here tells us about that? Please be careful with spreading around stats like that without context.

Re: Vuejs rejects close to 75% of outside contributions

#85

Maybe significantly more work, but can you try to filter out very small (or spam) PRs before these calculations? Maybe limit this analysis to PRs that edits source code (not just comment and docs). Or maybe include those, but only when "amount" of changes cross a certain threshold? (e.g. exclude PRs that fix just one typo)

Thanks for feedback! I am in fact working on features to improve that. Spam filtering is one of them.

Re: Vuejs rejects close to 75% of outside contributions

#87
post #34

I will talk about accepting outside contributions in a general sense (beyond JS and Julia comparisons). In my personal experience, the acceptance rates doesn't really matter and does not correlate to the quality of the code. On one hand, you have SQLite which really discourages direct code submissions due to the nature of the IP management of SQLite (they need to ensure that it is 100% in public domain), instead rely…

Why can't you use sqlite in js projects?

You can only use it with node I believe?

At least I would prefer to use sqlite over indexeddb, but haven't found a way yet.

Re: Vuejs rejects close to 75% of outside contributions

#88
post #83
post #54

That's the old Vue 2 repository, which has been pretty inactive for a while due to the full rewrite of Vue. Vue 3 (70.62% acceptance): https://merge-chance.info/target?repo=vuejs/vue-next Svelte (57.23% acceptance): https://merge-chance.info/target?repo=sveltejs/svelte React (45.99% acceptance): https://merge-chance.info/target?repo=facebook/react Angular (1.63% acceptance): https://merge-chance.info/target?repo=angu…

Side note: Angular tends to create new commits (keeping the author, changing the committer) instead of directly merging the PRs. The real acceptance rate seems to be high.

Thanks for pointing that out. I was a bit surprised about the low acceptance rate they had.

Re: Vuejs rejects close to 75% of outside contributions

#89
post #84

Earlier quoted context omitted.

Author here. I am still exploring useful metrics for classifying open source projects. My initial intent was to find a way to judge if given project is a good use of time for a first time contributor, someone not affiliated with original authors.

> My initial intent was to find a way to judge if given project is a good use of time for a first time contributor, someone not affiliated with original authors. so what does this contextless number you submitted here tells us about that? Please be careful with spreading around stats like that without context.

Thanks for feedback. In principle it is a measure that says - this repo will handle your PR quickly, but the base chance of it getting merged is low. The result in this case is skewed by spam however. Until I find a way to filter the spam PRs from counting it will remain uneven for repos like this one.

Re: Vuejs rejects close to 75% of outside contributions

#90
post #84

Earlier quoted context omitted.

> My initial intent was to find a way to judge if given project is a good use of time for a first time contributor, someone not affiliated with original authors. so what does this contextless number you submitted here tells us about that? Please be careful with spreading around stats like that without context.

Thanks for feedback. In principle it is a measure that says - this repo will handle your PR quickly, but the base chance of it getting merged is low. The result in this case is skewed by spam however. Until I find a way to filter the spam PRs from counting it will remain uneven for repos like this one.

That's exactly the problem. If you present a number but it's uneven for all kinds of reason it's a bad measure. And people will go around and unfairly point at projects being "bad for new contributors" with how you present it.
Post reply on HN