Hacker News Board Hacker News, browsed like a classic message board
Live data from Hacker News

YouTube-dl is now part of GitHub/dmca.git

github.com

Post reply on HN
Print view View original

21–30 of 332 posts

Re: YouTube-dl is now part of GitHub/dmca.git

#21

Post by Arnavion »

JMTQp8lwXL wrote: post #17
Stephen304 wrote: post #3

Heh, I didn't expect to get much attention for this. I thought it would be funny to push a merge commit between the 2 repo's latest commits. As a result, the git history is accessible from the dmca repo if you know the commit hashes. Since I didn't rebase, all the commit hashes were preserved with signatures. Another fun discovery is that deleting my fork of github/dmca didn't affect the PR like I thought it would, s…

Would closing the PR be enough to remove it, or does it actually have to be deleted? I didn't think PRs could be deleted, only closed.

Closing will not be enough. Even deleting the fork that made the PR will not be enough. (The PR remains open and the commit URLs automatically get updated to point to the parent repo, just like the URL that was submitted.)

Users can't delete PRs but GitHub can. They do it for PRs reported as spam, etc.

Regardless, what's needed here is not just deleting the PR (and the fork) but also doing a GC (as Stephen304 said), which too is something only GitHub can do.

Re: YouTube-dl is now part of GitHub/dmca.git

#22

Post by RulerOf »

fireattack wrote: post #12
Stephen304 wrote: post #3

Heh, I didn't expect to get much attention for this. I thought it would be funny to push a merge commit between the 2 repo's latest commits. As a result, the git history is accessible from the dmca repo if you know the commit hashes. Since I didn't rebase, all the commit hashes were preserved with signatures. Another fun discovery is that deleting my fork of github/dmca didn't affect the PR like I thought it would, s…

Just curious, why is this possible with an unmerged PR? Just a weird setup on GitHub's end?

There's a lot of reasons it's possible, but the one that sticks out is that the repo owner needs to be able to modify the commit before the PR is merged. AFAIK, the way that's done is by incorporating the remote repo's commit history into the destination repo underneath a pr-specific branch, which naturally brings all of the commits themselves into the repo's git database.

Re: YouTube-dl is now part of GitHub/dmca.git

#23

Post by kamyarg »

Cloned locally, was sad when the original repo was taken down.

Some things actually get worst when you try to prevent people from doing them, hopefully some people realize this.

Can someone remind me which music videos they did not want people to download please?

Re: YouTube-dl is now part of GitHub/dmca.git

#24

Post by mayneack »

gamblor956 wrote: post #15
Stephen304 wrote: post #3

Heh, I didn't expect to get much attention for this. I thought it would be funny to push a merge commit between the 2 repo's latest commits. As a result, the git history is accessible from the dmca repo if you know the commit hashes. Since I didn't rebase, all the commit hashes were preserved with signatures. Another fun discovery is that deleting my fork of github/dmca didn't affect the PR like I thought it would, s…

The end result will be GitHub taking down this repo and possibly blocking PRs. Congratulations on making life difficult for other people.

In a 10 second glance at closed PRs, it doesn't seem like they ever merge any from the public.

Re: YouTube-dl is now part of GitHub/dmca.git

#25

Post by AdamJacobMuller »

Stephen304 wrote: post #3

Heh, I didn't expect to get much attention for this. I thought it would be funny to push a merge commit between the 2 repo's latest commits. As a result, the git history is accessible from the dmca repo if you know the commit hashes. Since I didn't rebase, all the commit hashes were preserved with signatures. Another fun discovery is that deleting my fork of github/dmca didn't affect the PR like I thought it would, s…

This is hilarious, well done.

I realized something while :+1:-ing your PR: I was thinking about how digg deleted my account over posting the AACS key, I really couldn't care less if Microsoft deleted my account over it.

Very interesting considering that even just 2 years ago I never would have done this for fear of my account being deleted. All of my work and personal projects are moved to gitlab (the CI/Kubernetes/etc integration are just too good to pass up).

I know a sample size of 1 has an effectively 100% error rate, but, I think Microsoft is losing mindshare with GitHub. Stuff like this doesn't help. I could see a small company like GitLab needing to toe the DMCA line, but, Microsoft has the deep pockets and could have built some major community will here by handling this better. Unfortunate that they didn't.

Anyway, fun hack, I wonder how long it will last, or will they merge it? It must be the most approved PR in GitHub history at this point!

Re: YouTube-dl is now part of GitHub/dmca.git

#26

Post by judge2020 »

fireattack wrote: post #12
Stephen304 wrote: post #3

Heh, I didn't expect to get much attention for this. I thought it would be funny to push a merge commit between the 2 repo's latest commits. As a result, the git history is accessible from the dmca repo if you know the commit hashes. Since I didn't rebase, all the commit hashes were preserved with signatures. Another fun discovery is that deleting my fork of github/dmca didn't affect the PR like I thought it would, s…

Just curious, why is this possible with an unmerged PR? Just a weird setup on GitHub's end?

I think it's because GitHub wants to allow repo maintainers to merge in PRs without them having to add separate remotes themselves, ie `git remote add` isn't required to `git merge`.

This basically means that any content can be injected into anyone's GH repo (since PRs can't be turned off), but really only in terms of being able to view it on the GitHub website. To give an example, pull 437 on torvalds/linux[0] hasn't been merged in, but if you go to the commit hash in the browser, suddenly main/init.c has the relevant changes and commit that condense the file into one line[1].

This very well could be abused - imagine framing (or just 'canceling') someone with [insert illegal content here] by PRing their repo with a commit with a forged author[2] then linking people to their repo with the commit tree showing the illegal content.

0: https://github.com/torvalds/linux/pull/437

1: https://github.com/torvalds/linux/blob/2793ae1df012c7c3f13ea...

2: https://stackoverflow.com/a/60900120/3878893

Re: YouTube-dl is now part of GitHub/dmca.git

#27

Post by gizmo686 »

fireattack wrote: post #12
Stephen304 wrote: post #3

Heh, I didn't expect to get much attention for this. I thought it would be funny to push a merge commit between the 2 repo's latest commits. As a result, the git history is accessible from the dmca repo if you know the commit hashes. Since I didn't rebase, all the commit hashes were preserved with signatures. Another fun discovery is that deleting my fork of github/dmca didn't affect the PR like I thought it would, s…

Just curious, why is this possible with an unmerged PR? Just a weird setup on GitHub's end?

It is very useful that commits become part of the target repository as soon as a PR is created. This allows people reviewing the PR to checkout it on their local machines without needed to add the source repository as an additional remote.

Re: YouTube-dl is now part of GitHub/dmca.git

#28

Post by freeone3000 »

orbitingpluto wrote: post #13

The RIAA will have to create a takedown notice to takedown their takedown notice, invalidating the former takedown notice?

No, issuing a DMCA claim does not invalidate former claims. The system always works the way a rational human would expect.

Re: YouTube-dl is now part of GitHub/dmca.git

#29

Post by saagarjha »

gamblor956 wrote: post #15
Stephen304 wrote: post #3

Heh, I didn't expect to get much attention for this. I thought it would be funny to push a merge commit between the 2 repo's latest commits. As a result, the git history is accessible from the dmca repo if you know the commit hashes. Since I didn't rebase, all the commit hashes were preserved with signatures. Another fun discovery is that deleting my fork of github/dmca didn't affect the PR like I thought it would, s…

The end result will be GitHub taking down this repo and possibly blocking PRs. Congratulations on making life difficult for other people.

I suspect that many would consider this to be a win, although I doubt this will happen.

Re: YouTube-dl is now part of GitHub/dmca.git

#30

Post by Arnavion »

gamblor956 wrote: post #15
Stephen304 wrote: post #3

Heh, I didn't expect to get much attention for this. I thought it would be funny to push a merge commit between the 2 repo's latest commits. As a result, the git history is accessible from the dmca repo if you know the commit hashes. Since I didn't rebase, all the commit hashes were preserved with signatures. Another fun discovery is that deleting my fork of github/dmca didn't affect the PR like I thought it would, s…

The end result will be GitHub taking down this repo and possibly blocking PRs. Congratulations on making life difficult for other people.

If GitHub ever makes it possible for public repos to disable PRs, I think many regular users will be interested :) It's a quite old feature request: https://github.com/dear-github/dear-github/issues/84

It's been somewhat alleviated recently by the "archive" feature, though it would still be nice to have in cases where the repo is still being developed but doesn't want external contributions.

Post reply on HN