Better Git diff output for Ruby, Python, Elixir, Go • Hacker News Board

Re: Better Git diff output for Ruby, Python, Elixir, Go

#51

Post by heavenlyblue » Tue, Oct 20, 2020, 11:10 AM UTC

narrationbox wrote: post #21

A bigger problem is tree structures, it is particularly egregious for HTML and JSON where the output tend to be a complete mess of red and green. I think a good solution would be for git to call out to the respective language servers (the VS Language Server Protocol) and render changes based on AST and syntax specific diffs.

If you keep each entity on a new line in both HTML and JSON it's actually quite correct.

Re: Better Git diff output for Ruby, Python, Elixir, Go

#52

Post by nailer » Tue, Oct 20, 2020, 5:46 PM UTC

This could (and should) be written as a proper AST diff, rather than a presentation based diff with some mild smarts:

      assigns: { 
        tickets: tickets, 
        ++ event_name: event_name 
      }

Re: Better Git diff output for Ruby, Python, Elixir, Go

#53

Post by hsbauauvhabzb » Tue, Oct 20, 2020, 9:01 PM UTC

ori_b wrote: post #43

hsbauauvhabzb wrote: post #23

Earlier quoted context omitted.

I rarely see files with incorrect file extensions outside of collisions and user error? I don’t see any downside apart from extensionless files like shell scripts with the executable flag set, shebang, and no file extension which could also be solved. Edit: and if comprehensive correctness was truly desired, file magic could make a better guess, but that would be overkill imo.

What's a '.m' file? Matlab, Objective-C, or Mathematica?

Whichever is most common. Alternatively, use file magic to determine type in cases of collision, or do nothing (75+% of devs wouldn’t use these).