Live data from Hacker News

Code scanning for security vulnerabilities now available

github.blog

101–110 of 125 posts

Re: Code scanning for security vulnerabilities now available

#101
post #87

Earlier quoted context omitted.

PM from GitHub here and author of Dependabot. It's different. - Dependabot looks for vulnerabilities in your dependencies, and creates pull requests to update you to fixed versions. - Code scanning looks for vulnerabilities in your own code. So, for example, if you have written code that takes user input and creates a database instruction from it without escaping it, it will flag that you are introducing an SQL injec…

> PM from GitHub here Hey totally off topic sorry. Can you get someone to turn off pull-requests for the unofficial mirrors that you guys created for some open source projects? Users are being mislead into thinking opening PRs there is productive, but they're not monitored by our project and we don't own the repo anyway. https://github.com/wine-mirror/wine/pulls I've tried contacting your support, but they just tell…

You may take a page from FFmpeg: https://github.com/FFmpeg/FFmpeg/pulls (although currently open PRs probably need to be closed somehow for that to be effective).

Re: Code scanning for security vulnerabilities now available

#102
Maybe this is just an issue with my phone, but I found the embedded demo video frustrating to view because it’s 1) low quality / hard to read and 2) in a loop that can’t be paused. I watched it 3 times trying to read through the code each time then gave up in frustration.

Re: Code scanning for security vulnerabilities now available

#103
post #67
post #43

Hopefully GH will apply this to Github Actions, which seem like an exploit vector just sitting there. GH Actions are: - complex enough to develop that third-party solutions are attractive, especially for simple-seeming tasks (I have just been through this) - but yay there's a "marketplace" for actions! - the code in the marketplace is the wild-west, but you'll find something that seems like it'll do what you want - y…

As far as I can see they also have access to your secrets. I really haven't gotten myself to use any non-GitHub-defined Actions yet, because I haven't been able to verify if that's actually safe.

They don't have direct access. You need to assign the secret in your workflow file.

Example:

  steps:
    - uses: actions/checkout@v2
    - uses: sfdx-actions/setup-sfdx@v1
      with:
        sfdx-auth-url: ${{ secrets.SFDX_AUTH_URL }}
or

  steps:
    - uses: actions/checkout@v2
    - name: Run deployment script
      env:
        HEROKU_API_TOKEN: ${{ secrets.HEROKU_API_TOKEN }}
The first is for an Action, the second is for a normal workflow script.

Re: Code scanning for security vulnerabilities now available

#104
post #101
post #87

Earlier quoted context omitted.

> PM from GitHub here Hey totally off topic sorry. Can you get someone to turn off pull-requests for the unofficial mirrors that you guys created for some open source projects? Users are being mislead into thinking opening PRs there is productive, but they're not monitored by our project and we don't own the repo anyway. https://github.com/wine-mirror/wine/pulls I've tried contacting your support, but they just tell…

You may take a page from FFmpeg: https://github.com/FFmpeg/FFmpeg/pulls (although currently open PRs probably need to be closed somehow for that to be effective).

Apparently that doesn't work much better: https://github.com/FFmpeg/FFmpeg/pulls?q=is%3Apr+is%3Aclosed Regardless, it's kind of crappy that we have to clean up after GitHub's mess.

Re: Code scanning for security vulnerabilities now available

#105
post #18

Pass from me, given the published pricing is: > Contact Sales to learn more

We need a crowdsource information for this problem. Imagine a volunteer ask them the price and share it to the world. Glassdoor but for "sales price". Package it as a browser extension. Everyone becomes happy.

Re: Code scanning for security vulnerabilities now available

#106
post #63

They really bury their lead on what languages are supported. - C/C++ - C# - Go - Java - JavaScript/TypeScript - Python https://docs.github.com/en/free-pro-team@latest/github/findi...

weird that they don't support ruby when their site is written in it

Re: Code scanning for security vulnerabilities now available

#107
post #60

Earlier quoted context omitted.

Automated proof of vulnerability is valuable. Kafkaesque pattern matching, is not.

That's only true based on a certain level of care, which sadly is not always the case. Say you have a codebase that wasn't built well. Let's say your code scanner finds you at the very least the text "-----BEGIN R/DSA PRIVATE KEY-----*-----END R/DSA PRIVATE KEY-----". In my codebases that'll find nothing, but for many people, they just found SSH keys committed in plaintext. The same is true for any 1k/2k (++etc) stri…

* will match {cipherkey} so I do not want it.

Re: Code scanning for security vulnerabilities now available

#108
post #77

Earlier quoted context omitted.

I think the real question is if their pricing design is optimal. Would they make more money with clear pricing? I think so. One of my ancestors had a company selling commodities. He wouldn’t answer the phone until the customer had called three times and left messages. He said this was a filter to identify the customers who really needed his product. The logic is sound and on the surface clever. But would he have made…

I'm sure it's tough to tell, and the side with less risk is the one that often costs fewer resources. My dad runs a shop restoring classic cars, mostly as a hobby. The number of minutes you can spend on the phone discussing some potential client's great-grandfather's old clunker and their dreams / aspirations of getting it fixed is nearly limitless, but the number of clients willing to actually pay and wait for it is…

I agree with both of you. The level of business that grants a "write us to know prices" message must be well above the small to medium customer... but still it itches when you're interested and realize that their product is not directed at you at all.

We could argue that they would get more money, but at the end of the day they probably decided that a single bigger fish is definitely worth losing business from a hundred smaller ones. I guess it's one of those "nice problems to have", if you grow so much that you have it.

Re: Code scanning for security vulnerabilities now available

#109
post #74

Earlier quoted context omitted.

What’s frustrating is that it’s not part of the $21/month. I have that and have been trying to get pricing info for a few weeks. I’ve gotten mixed messages that it costs nothing extra and just uses Action minutes on their price schedule or that it costs some unknown price that is extra. My impression is that they haven’t picked pricing yet. It frustrates me when the price answer is “contact sales and let’s talk about…

They are still trying to determine pricing, and figure out how to position themselves against competitors (who are about to have thier lunch eaten if gh is smart)

I wonder if the problem is that the marginal cost is near zero because the rules are mostly open source and there’s no special infrastructure.

So the problem is that they are trying to figure out the “value” instead of giving it out for free.

What’s interesting about gitlab’s sast is that it’s really mostly just curating open source tools and using their existing CI stack. So it’s possible to just look at their code and set up, but a hassle.

I’m hoping GH just gives it away for free. Or does some sort of sonarqube method where you layer on indemnity or something.

The problem is that per user pricing sucks because most users don’t care. The PM or maybe one or two are interested, but paying for 400 users with licenses to please 5 audit people doesn’t make sense when it’s really just being run by a single Jenkins robot (or equivalent).

Re: Code scanning for security vulnerabilities now available

#110
post #87

Earlier quoted context omitted.

PM from GitHub here and author of Dependabot. It's different. - Dependabot looks for vulnerabilities in your dependencies, and creates pull requests to update you to fixed versions. - Code scanning looks for vulnerabilities in your own code. So, for example, if you have written code that takes user input and creates a database instruction from it without escaping it, it will flag that you are introducing an SQL injec…

> PM from GitHub here Hey totally off topic sorry. Can you get someone to turn off pull-requests for the unofficial mirrors that you guys created for some open source projects? Users are being mislead into thinking opening PRs there is productive, but they're not monitored by our project and we don't own the repo anyway. https://github.com/wine-mirror/wine/pulls I've tried contacting your support, but they just tell…

I had no idea that we do that, but I can try to hunt it down internally for you. Ping me an email - greysteil@github.com.
Post reply on HN