Live data from Hacker News

Piranha: An Open Source Tool to Automatically Delete Stale Code

eng.uber.com

11–20 of 50 posts

Re: Piranha: An Open Source Tool to Automatically Delete Stale Code

#11

Neat! I experimented with something similar and found the state of java AST transformers to be in a kind of painful state. I'll have to look though the code base to see what y'all used.

We used Google's Error Prone framework. Pros: you get full compiler symbol/type information, in addition to the AST. Cons: you need to build the code to process it (Error Prone runs as a javac plugin), and if you want to do things efficiently then you are restricted to basically a single AST traversal. It's very use-case dependent whether you are better off just using e.g. javaparser.

Re: Piranha: An Open Source Tool to Automatically Delete Stale Code

#12
A while ago I deleted my Uber/UberEats account (they didn't make it easy btw) because of how utterly unusable their apps were compared to competition. After me and my girlfriend spent 30 minutes trying to order food on 3 different platforms, which has been a repeated experience with them for years, I decided it's time to give up. Same obvious UI/UX bugs as over a year ago - I'm actually dumbfounded at how this is possible, do they even use their own app? To sum up, I tend to look at tech coming from Uber through a somewhat sarcastic lens these days.

Re: Piranha: An Open Source Tool to Automatically Delete Stale Code

#13
post #4

One of our internal experimentation systems handles this by capping rollouts to 95%. So the author is forced to clean up their code if they want a full rollout.

Brilliant. This reminds me of the apocryphal tale where NASA spent millions developing a pen that could work in microgravity… and Russia just used a pencil.

Please stop repeating this, it’s total nonsense.

Re: Piranha: An Open Source Tool to Automatically Delete Stale Code

#14

> Currently implemented for Objective-C, Swift, and Java programs Are Uber's Android apps written in Java? I would have thought they would be Kotlin.

Most of the existing Android codebase is Java. There is some Kotlin code, and PiranhaKotlin is certainly in the roadmap somewhere but, especially when the goal is removing older features, Java makes the lion share of the use case for such a tool right now.

Re: Piranha: An Open Source Tool to Automatically Delete Stale Code

#15

A while ago I deleted my Uber/UberEats account (they didn't make it easy btw) because of how utterly unusable their apps were compared to competition. After me and my girlfriend spent 30 minutes trying to order food on 3 different platforms, which has been a repeated experience with them for years, I decided it's time to give up. Same obvious UI/UX bugs as over a year ago - I'm actually dumbfounded at how this is pos…

Try rooting your phone and installing a CPU monitor like https://f-droid.org/en/packages/com.eolwral.osmonitor/ . Then watch for apps burning CPU in the background. Uber might show up wink.

Re: Piranha: An Open Source Tool to Automatically Delete Stale Code

#16
post #13

Earlier quoted context omitted.

Brilliant. This reminds me of the apocryphal tale where NASA spent millions developing a pen that could work in microgravity… and Russia just used a pencil.

Please stop repeating this, it’s total nonsense.

That's why he said apocryphal..

Re: Piranha: An Open Source Tool to Automatically Delete Stale Code

#19
post #4

One of our internal experimentation systems handles this by capping rollouts to 95%. So the author is forced to clean up their code if they want a full rollout.

I'm sorry, but I don't entirely get this. Does it mean that after I've finished something I want to merge, I have to remove 5% of that? Or of the entire code base? Or something completely different?
Post reply on HN