Hacker News Board Hacker News, browsed like a classic message board
Live data from Hacker News

Every software system used at Gitlab

about.gitlab.com

Post reply on HN
Print view View original

91–100 of 123 posts

Re: Every software system used at Gitlab

#91

Post by babygetoboy »

airlines55 wrote: post #88

I'm so sick of Gitlab support spam in every thread that mentions any issue, making it so that critical conversations are interrupted with self serving pitches! >I once saw Gitlab do this thing. >Hey, Bob from Gitlab thing here. We are really trying to make thing great for our customers . Our next release of thing will do foo which we hope will fix this. Here is a link to a marketing post comparing us to GitHub. Hope…

Hey, Jimmy here, vending machine manager at GitLab. I'm sorry that our posts here are concerning. I'm going to run this one right up the ladder for you. Thank you so much for your concern and sorry about your experience with GitLab!

Re: Every software system used at Gitlab

#92

Post by dominotw »

airlines55 wrote: post #88

I'm so sick of Gitlab support spam in every thread that mentions any issue, making it so that critical conversations are interrupted with self serving pitches! >I once saw Gitlab do this thing. >Hey, Bob from Gitlab thing here. We are really trying to make thing great for our customers . Our next release of thing will do foo which we hope will fix this. Here is a link to a marketing post comparing us to GitHub. Hope…

Their CEO is the worst offender. Shows up on every gitlab thread with these generic/uninteresting comments.

Re: Every software system used at Gitlab

#93

Post by airlines55 »

dominotw wrote: post #92
airlines55 wrote: post #88

I'm so sick of Gitlab support spam in every thread that mentions any issue, making it so that critical conversations are interrupted with self serving pitches! >I once saw Gitlab do this thing. >Hey, Bob from Gitlab thing here. We are really trying to make thing great for our customers . Our next release of thing will do foo which we hope will fix this. Here is a link to a marketing post comparing us to GitHub. Hope…

Their CEO is the worst offender. Shows up on every gitlab thread with these generic/uninteresting comments.

The thing is - I get it. I thi k it's cool when people show up to talk about their product or code that is mentioned on a forum. It's endearing. But when it's systematized by a large corporation, it's no longer so.

Re: Every software system used at Gitlab

#94

Post by blyry »

teen wrote: post #31

Gitlab has been pretty great so far, but the code review tooling is so poor I think I need to look elsewhere. The pull request pages take forever to load, they can't handle pull requests with over 800 lines well at all. It will collapse files with over 100-200 lines of changes for seemingly no reason (hiding the comments within them). You can't ignore whitespace in diffs, and the comments disappear from the diff if t…

> It will collapse files with over 100-200 lines of changes for seemingly no reason (hiding the comments within them)

OH MY GOD this so much. This one specific anti-feature has no doubt caused countless bugs to be missed during code review. I can quote the issue thread by memory at this point i've revisited it so many times the last year(s?)

For goodness sake, if the trade off is between 'seeing all of the changes during the review' vs 'having the page load quickly', the only people who choose 'quickly' are those who haven't been burned by human error missing a collapsed diff. Gitlab made the wrong trade off here in good/fast/cheap triangle.

Re: Every software system used at Gitlab

#95

Post by bostik »

gen220 wrote: post #67
Aeolun wrote: post #62

Earlier quoted context omitted.

I don’t understand. This describes basically every code review tool I’ve ever used. If there’s something aside from Gitlab that I should try that still integrates, I’d love to know.

For huge diffs, there’s not much that beats `git checkout && git diff HEAD^`. For leaving comments, pretty much every system I’ve used has issues. At work we use phabricator; the default settings are atrocious but they can be tuned to something workable. I sometimes wonder how hard it would be to get diff reviews to be a first (or even second) class citizen of the git ecosystem. That way you can finally get the bliss…

> [git ecosystem] have “notes” which are vaguely similar, maybe it’s something they’re considering?

If you're referring to git-notes, they are ... kinda special. They are objects in their own namespace that reference the repository objects the notes themselves are attached to.

Sure enough, you can attach a note to any git-object. And you can view them either directly or from the git-log view. But the discoverability is lacking, and the UI of doing pretty much anything with git-notes is absolutely atrocious. Because they are in their own namespace, you don't automatically get them when you do a pull or fetch, which can get pretty confusing.

For the curious ones, the magic invocation needed to pull in updates to notes from the remote repo is:

    git fetch origin +refs/notes/*:refs/notes/*
Notes are not versioned, and you certainly don't get nice N-way merges between local and remote content. Semantics are different from regular git, and stuff can get lost.

So from where I'm looking at things, git-notes are not suitable for plumbing in a code review flow.

Re: Every software system used at Gitlab

#96

Post by itsArtur »

Aeolun wrote: post #62
teen wrote: post #31

Gitlab has been pretty great so far, but the code review tooling is so poor I think I need to look elsewhere. The pull request pages take forever to load, they can't handle pull requests with over 800 lines well at all. It will collapse files with over 100-200 lines of changes for seemingly no reason (hiding the comments within them). You can't ignore whitespace in diffs, and the comments disappear from the diff if t…

I don’t understand. This describes basically every code review tool I’ve ever used. If there’s something aside from Gitlab that I should try that still integrates, I’d love to know.

I always use IntelliJ for code reviews, works great.

Re: Every software system used at Gitlab

#97

Post by scarface74 »

And HN users only worry about “cloud lock-in”. I’ve said dozens of times that the typical largish company is locked in to dozens of SAAS offerings that would be a major pain and expense to migrate away from.

Once you choose your infrastructure, you might as well go all in. Just look at their dependence on SalesForce.

Re: Every software system used at Gitlab

#98

Post by ecnahc515 »

throwaway_pdp09 wrote: post #42
spondyl wrote: post #30

I don't know if any Gitlabbers are in the comments but I'd be interested to know: Is this basically your internal asset register open sourced? I suppose they're not particularly top secret but there could be a version that has some more sensitive data and this is a safe derivative for example. Similarly, such an asset register would likely have non-technical assets as well while this just seems to be tangible, techni…

Err, what is an internal asset register?

Basically an inventory system.

Re: Every software system used at Gitlab

#99

Post by sa46 »

papaf wrote: post #43
teen wrote: post #31

Gitlab has been pretty great so far, but the code review tooling is so poor I think I need to look elsewhere. The pull request pages take forever to load, they can't handle pull requests with over 800 lines well at all. It will collapse files with over 100-200 lines of changes for seemingly no reason (hiding the comments within them). You can't ignore whitespace in diffs, and the comments disappear from the diff if t…

In my experience, if you are reviewing 800+ line PRs you should be in an IDE. I believe the average human being can not review an 800 line diff reliably. Such large PRs would also probably benefit from live discussions over video (or in the good old days -- in person).

Interesting, I’ve only went through the effort of checking out a pull request for review a couple times. What’s the workflow like? Any tips for reducing friction? I avoid checking out PRs because it’s much higher friction and because I trust CI to catch most bugs so the crappy code forge interfaces are good enough.

Personally, I would kill for a one click to step review interface in IntelliJ that synced comments back to the review.

Re: Every software system used at Gitlab

#100

Post by dgritsko »

airlines55 wrote: post #88

I'm so sick of Gitlab support spam in every thread that mentions any issue, making it so that critical conversations are interrupted with self serving pitches! >I once saw Gitlab do this thing. >Hey, Bob from Gitlab thing here. We are really trying to make thing great for our customers . Our next release of thing will do foo which we hope will fix this. Here is a link to a marketing post comparing us to GitHub. Hope…

It is hilarious to me that this comment is at the top, the rest of the thread is rife with comments from GitLab staff.
Post reply on HN