11–20 of 35 posts
The project uses a mix of Dutch and English for symbols, docs and comments. Now you need programmers that besides Python, are also good with both Dutch and English. Sadly this greatly limits the audience.
Agreed, but that doesn't detract much from the achievement. A few screenshots would be nice, though.
Why not just have it all in one language? Why the English bait and switch?
https://github.com/DirkJanJansen/Pandora/blob/master/invoerI... What the heck is this supposed to be? Are you really creating a database table and then a connection, and executing that in the middle of some random code? You really need to separate this out. And this is not a cherrypicked complaint, this is the first file I randomly clicked in the repo.
https://github.com/DirkJanJansen/Pandora/search?q=create_eng... This looks like you're creating a new engine anywhere you need database access. This is NOT how you use SQLAlchemy. Create a database.py file that contains a SINGLE create_engine function, and define all your tables in one place. This code looks like a real mess.
Don't take this as a personal attack. We all had to start somewhere. But this is not something I'd call top quality or really even quality.
Earlier quoted context omitted.
Agreed, but that doesn't detract much from the achievement. A few screenshots would be nice, though.
The screenshots are available look: https://github.com/DirkJanJansen/Pandora/tree/master/Install...
Looking at the Github, it really feels like you should organize your code better. There are many files with the same prefix that should go into their own src/{prefix} subdirectories. The README is really lackluster and should contain installation information and screenshots at least. https://github.com/DirkJanJansen/Pandora/blob/master/invoerI... What the heck is this supposed to be? Are you really creating a databas…
Echoing others, I recommend improving the readme and embedding or linking to screenshots in it :)
Looking at the Github, it really feels like you should organize your code better. There are many files with the same prefix that should go into their own src/{prefix} subdirectories. The README is really lackluster and should contain installation information and screenshots at least. https://github.com/DirkJanJansen/Pandora/blob/master/invoerI... What the heck is this supposed to be? Are you really creating a databas…
I'm aware, that the code could be organised better. But keep in mind, that the program is not written by a professional. It's intended as an example for integration python with a database system for the community and i am convinced that the program helds many aspects as a learning purpose for instance integrating graphs. And screenshots by the way are available in the project at https://github.com/DirkJanJansen/Pando…
Quite an accomplishment. Well done! How long have you been working on it? Echoing others, I recommend improving the readme and embedding or linking to screenshots in it :)
Is this same with odoo?