Prettier 2.0 – Opinionated JavaScript formatter

Post by Hurtak » Sun, Mar 22, 2020, 10:18 PM UTC

11235813213455 wrote: post #10

hombre_fatal wrote: post #5

Earlier quoted context omitted.

Why not just change it to a high value? Or prettier-ignore exceptional lines?

if you put a high lineWidth value, you'll have your object literals or destructuring mostly one-lined, etc.. often not desirable (for 4+ props) That's mostly why I don't like prettier, sometimes you want a bit of control over code formatting when several options are possible, prettier don't allow it. I use vscode formatter (actually it's TypeScript compiler formatter) instead Other things I dislike with prettier, lik…

    const {a, b, c} = props;

    const {
      // 
      a, 
      b, 
      c
    } = props;

Post by Waterluvian » Sun, Mar 22, 2020, 10:23 PM UTC

afshin wrote: post #42

greentrust wrote: post #31

Earlier quoted context omitted.

Is the cost really that high? For the vast majority of projects, all developers will need to do is run "yarn prettier". We can't expect everything to be perfect on day one, nor should we be stuck with the poor choices we made when starting a project. Maintainers should be allowed to change their mind after careful consideration and community consensus.

Part of the calculus for the cost is losing the immediate utility of git blame once every file has been reformatted.

Post by mceachen » Sun, Mar 22, 2020, 10:33 PM UTC

Waterluvian wrote: post #29

A bit irritating that formatting zealots are changing the defaults. What can possibly drive the decision to change whatever option it is they landed on and deployed? It's contrary to everything they claimed Prettier was about: for better or worse, we have decided on X so we can all move on to more important issues. I feel like the cost of changing defaults is wildly underestimated because it's decided on by people wh…

    {
      "trailingComma": "none",
      "arrowParens": "avoid"
    }

Post by tony » Sun, Mar 22, 2020, 10:35 PM UTC

crooked-v wrote: post #25

tony wrote: post #24

In order to get this working with vim's prettier highlighting, I had to add this to `.prettierrc`: { "trailingComma": "es5", "arrowParens": "always" } Prettier 2.0 changed this to be the defaults, but for some reason the editor plugin wasn't acknowledging it. Also I added a script command to format all the code in package.json: { "scripts": { "prettier": "prettier src webpack data --write" } } Then `npm run prettier`…

> but for some reason the editor plugin wasn't acknowledging it Is it using a bundled pre-2.0 version of Prettier?

Post by lonelappde » Sun, Mar 22, 2020, 10:39 PM UTC

afshin wrote: post #42

greentrust wrote: post #31

Earlier quoted context omitted.

Is the cost really that high? For the vast majority of projects, all developers will need to do is run "yarn prettier". We can't expect everything to be perfect on day one, nor should we be stuck with the poor choices we made when starting a project. Maintainers should be allowed to change their mind after careful consideration and community consensus.

Part of the calculus for the cost is losing the immediate utility of git blame once every file has been reformatted.