Hacker News Board Hacker News, browsed like a classic message board
Live data from Hacker News

Request Node lib used by 48k modules is now deprecated

github.com

Post reply on HN
Print view View original

61–70 of 135 posts

Re: Request Node lib used by 48k modules is now deprecated

#61

Post by 11235813213455 »

outside1234 wrote: post #55
tal_berzniz wrote: post #17

Deprecating is a weird decision as there is nothing wrong with the "request" module. It doesn't lead to bad code, bugs or security risks. It would be better to say this is the last version, except for security upgrades. These upgrades can be done by other maintainers that are assigned to the project.

It is slightly archaic in that it mostly uses a callback convention, when most of the node community has moved on to promises. And there are more modern alternatives like axios that do have this promises interface.

node-fetch above all, it's standard, and works in the browser https://github.com/node-fetch/node-fetch/blob/master/package...

Re: Request Node lib used by 48k modules is now deprecated

#62

Post by tal_berzniz »

JMTQp8lwXL wrote: post #60
tal_berzniz wrote: post #17

Deprecating is a weird decision as there is nothing wrong with the "request" module. It doesn't lead to bad code, bugs or security risks. It would be better to say this is the last version, except for security upgrades. These upgrades can be done by other maintainers that are assigned to the project.

The maintainers claim that the community would be better off without the package. Someone has to stick around to do security fixes for it, and that's time that could be spent making more innovative contributions to the Node.js package ecosystem.

Wouldn't it make more sense to ask the community what they want to do? Without taking time from the original maintainers

Re: Request Node lib used by 48k modules is now deprecated

#63

Post by kabes »

dpedu wrote: post #16

> request will stop accepting new features. > request will stop considering breaking changes. > The committers that are still active will try to merge fixes in a timely fashion Sounds to me like the library is "done".

The annoying thing is, since it is marked as deprecated, everyone installing a package that relies on it will get a deprecation notice. I already had some users opening issues on some of my projects for this.

Re: Request Node lib used by 48k modules is now deprecated

#64

Post by [deleted] »

kabes wrote: post #63
dpedu wrote: post #16

> request will stop accepting new features. > request will stop considering breaking changes. > The committers that are still active will try to merge fixes in a timely fashion Sounds to me like the library is "done".

The annoying thing is, since it is marked as deprecated, everyone installing a package that relies on it will get a deprecation notice. I already had some users opening issues on some of my projects for this.

[deleted]

Re: Request Node lib used by 48k modules is now deprecated

#65

Post by Ididntdothis »

hombre_fatal wrote: post #35
Ididntdothis wrote: post #30

Earlier quoted context omitted.

Why is an alternative needed? To me it sounds like the library is “done” and has all the features it needs. I wish more code was in that stable state.

fwiw they actually did mark their package as deprecated on NPM which means that all installations will see a warning that urges the user to consider other software. It's kind of like if you were to maintain your own promise implementation, then the Promise is added to stdlib. You wouldn't say that your project is "done", you'd want to encourage your users to use the native promise. Request was created back when all w…

Makes sense.

Re: Request Node lib used by 48k modules is now deprecated

#66

Post by Waterluvian »

MadWombat wrote: post #53
djsumdog wrote: post #27

Earlier quoted context omitted.

Yea, makes me think of how every news blog reported mp3 as "dead" when the patent expired, when they should have been saying mp3 is now license free.

Also, "mp3 is license free" rhymes :)

License free mp3 is good to see. But what we need, according to me, is for AAC to become license free.

Re: Request Node lib used by 48k modules is now deprecated

#67

Post by masklinn »

Tomte wrote: post #26

Real title: "Alternative libraries to request". The "deprecating" part is simply the submitter's invention, in order to stir up drama.

The maintainer put it in "maintenance-only" a year back, and officially deprecated it a week ago: https://github.com/request/request/pull/3267

Re: Request Node lib used by 48k modules is now deprecated

#68

Post by fapjacks »

neurobashing wrote: post #49
dpedu wrote: post #16

> request will stop accepting new features. > request will stop considering breaking changes. > The committers that are still active will try to merge fixes in a timely fashion Sounds to me like the library is "done".

Hardly a hot take but a lot of people seem to think that if code isn't actively being worked it, you can't use it, as if there can never be a point where fewer and fewer bugs are reported and fewer and fewer features are requested. when's the last time Knuth wrote a check for TAOCP? Is it "dead"?

He no longer writes checks to people for bug-hunting and hasn't done so for years due to concerns about the proliferation of his banking information. He mails out certificates.

Re: Request Node lib used by 48k modules is now deprecated

#69

Post by hombre_fatal »

tantalor wrote: post #54
hombre_fatal wrote: post #32

Earlier quoted context omitted.

They have marked the package as deprecated on NPM. https://docs.npmjs.com/cli/deprecate See the banner on this page: https://www.npmjs.com/package/request They are urging people to consider the enumerated alternatives.

> No new changes are expected land. In fact, none have landed for some time. That's not what "deprecated" means. That's "maintenance mode". Deprecated means no new clients should use it, and existing clients should migrate to library X or Y, because it's going to be deleted by 202X.

They don't want to maintain this software forever and are definitely urging people to use other software. They even admit that they will merge fix PRs with a disclaimer of "no promises".

I mean, the developer themself has said it's deprecated and has marked it as such formally on NPM with a link to a post that urges people to use alternatives, so I'm unsure of what you're arguing nor what it achieves. Seems to satisfy your own definition, they just don't have an exact date on when their maintenance charity will run out.

Re: Request Node lib used by 48k modules is now deprecated

#70

Post by chrisseaton »

fapjacks wrote: post #68
neurobashing wrote: post #49

Earlier quoted context omitted.

Hardly a hot take but a lot of people seem to think that if code isn't actively being worked it, you can't use it, as if there can never be a point where fewer and fewer bugs are reported and fewer and fewer features are requested. when's the last time Knuth wrote a check for TAOCP? Is it "dead"?

He no longer writes checks to people for bug-hunting and hasn't done so for years due to concerns about the proliferation of his banking information. He mails out certificates.

Why do checks have your banking secrets on them?
Post reply on HN