Git Blame-Someone-Else

#1

Post by dcminter » Wed, Sep 18, 2019, 11:35 AM UTC

Re: Git Blame-Someone-Else

#2

Post by saagarjha » Fri, Sep 20, 2019, 8:10 AM UTC

Personally, I find this really useful when I accidentally squash something incorrectly during a rebase and in the process of cleaning it up end up with changes attributed to the “wrong” person.

Re: Git Blame-Someone-Else

#3

Post by mohsen0 » Fri, Sep 20, 2019, 8:16 AM UTC

And that is why signing commits should be enforced.

Re: Git Blame-Someone-Else

#4

Post by p4bl0 » Fri, Sep 20, 2019, 8:58 AM UTC

It's funny but it doesn't actually work because the hash of the modified commit and all subsequent ones will necessarily change, right? So it would be very visible to everyone that a change has been made as it might break a lot of things to force-push an incompatible history of commit.

Re: Git Blame-Someone-Else

#5

Post by kbumsik » Fri, Sep 20, 2019, 9:30 AM UTC

p4bl0 wrote: post #4

It's funny but it doesn't actually work because the hash of the modified commit and all subsequent ones will necessarily change, right? So it would be very visible to everyone that a change has been made as it might break a lot of things to force-push an incompatible history of commit.

> it doesn't actually work because the hash of the modified commit and all subsequent ones will necessarily change, right?

True, so it is just a joke.

Re: Git Blame-Someone-Else

#6

Post by dcminter » Fri, Sep 20, 2019, 9:30 AM UTC

p4bl0 wrote: post #4

It's funny but it doesn't actually work because the hash of the modified commit and all subsequent ones will necessarily change, right? So it would be very visible to everyone that a change has been made as it might break a lot of things to force-push an incompatible history of commit.

Although your point is perfectly valid, I don't think the tool is intended for anything other than fun.

Re: Git Blame-Someone-Else

#7

Post by spraak » Fri, Sep 20, 2019, 9:48 AM UTC

saagarjha wrote: post #2

Personally, I find this really useful when I accidentally squash something incorrectly during a rebase and in the process of cleaning it up end up with changes attributed to the “wrong” person.

Check out `git reflog` to go back to before the mistake

Re: Git Blame-Someone-Else

#8

Post by Znafon » Fri, Sep 20, 2019, 9:51 AM UTC

mohsen0 wrote: post #3

And that is why signing commits should be enforced.

You would already get a conflict as the history of the repo changed and signing all commits as some drawbacks as Torvalds explained here: http://git.661346.n2.nabble.com/GPG-signing-for-git-commit-t...

I'm not sure it's better.

Re: Git Blame-Someone-Else

#9

Post by alex_duf » Fri, Sep 20, 2019, 10:19 AM UTC

p4bl0 wrote: post #4

It's funny but it doesn't actually work because the hash of the modified commit and all subsequent ones will necessarily change, right? So it would be very visible to everyone that a change has been made as it might break a lot of things to force-push an incompatible history of commit.

The following hashes do changes (you can see that on the gif on their readme). I think you're meant to force push after using the tool

Re: Git Blame-Someone-Else

#10

Post by warpech » Fri, Sep 20, 2019, 11:24 AM UTC

What is more, you can:

1. clone https://github.com/torvalds/linux into /linux" rel="nofollow">https://github.com//linux.

2. push a fake "torvalds" commit into your repo.

3. check the SHA of the the commit that you made.

4. the commit will be visible at the original repo URL with your SHA (" rel="nofollow">https://github.com/torvalds/linux/commit/), with no indication whatsoever that this is coming from a different repo

I have reported this problem to GitHub a while ago and they replied to me that this is a well known feature of the repo "network".