How to do a code review

#1

Post by iamaelephant » Thu, Sep 05, 2019, 9:13 PM UTC

How to do a code review
google.github.io

Re: How to do a code review

#2

Post by mattsfrey » Thu, Sep 05, 2019, 9:58 PM UTC

Would help if they mention what a "CL" is somewhere before using it ubiquitously

Re: How to do a code review

#3

Post by enjoyyourlife » Thu, Sep 05, 2019, 10:01 PM UTC

mattsfrey wrote: post #2

Would help if they mention what a "CL" is somewhere before using it ubiquitously

They do define it, see https://google.github.io/eng-practices/. It means "change list."

Re: How to do a code review

#4

Post by [deleted] » Thu, Sep 05, 2019, 10:03 PM UTC

mattsfrey wrote: post #2

Would help if they mention what a "CL" is somewhere before using it ubiquitously

[deleted]

Re: How to do a code review

#5

Post by jdm2212 » Thu, Sep 05, 2019, 10:09 PM UTC

mattsfrey wrote: post #2

Would help if they mention what a "CL" is somewhere before using it ubiquitously

It refers to "changelist". Google uses a Perforce-like VCS internally, and they kept the Perforce terminology: https://www.perforce.com/perforce/doc.051/manuals/p4guide/07...

Re: How to do a code review

#6

Post by imglorp » Thu, Sep 05, 2019, 10:20 PM UTC

As a side note, their github hosts 1600 repos. Just wanted to say thank you, google.

Re: How to do a code review

#7

Post by euske » Thu, Sep 05, 2019, 10:28 PM UTC

To me this doesn't look a very good guideline. It's needlessly verbose and unintuitive. Instead of writing a long sprawling list of things, just using bullet points and figures would be better.

It mentions the importance of getting a big picture of the code in question first, but the guideline itself is pretty bad at presenting its big picture.

Here's the gist of it as I understand:

- Long-term health of the code is important.

- Development should be incremental and steady.

- Beware of the contexts: style, use cases and technical complexity.

- Suggest them changes with reasons.

- Make it quick enough.

Re: How to do a code review

#8

Post by jorblumesea » Thu, Sep 05, 2019, 10:33 PM UTC

CL? Is that perforce? Hopefully it works better than the real perforce. A really tough and confusing versioning tool.

Re: How to do a code review

#9

Post by krasin » Thu, Sep 05, 2019, 10:37 PM UTC

jorblumesea wrote: post #8

CL? Is that perforce? Hopefully it works better than the real perforce. A really tough and confusing versioning tool.

Google uses Piper, that is vaguely inspired by Perforce workflow, but significantly less confusing.

Source: https://cacm.acm.org/magazines/2016/7/204032-why-google-stor...

Re: How to do a code review

#10

Post by nkskalyan » Thu, Sep 05, 2019, 10:37 PM UTC

jorblumesea wrote: post #8

CL? Is that perforce? Hopefully it works better than the real perforce. A really tough and confusing versioning tool.

It is an internally built versioning tool with similar interface as perforce https://cacm.acm.org/magazines/2016/7/204032-why-google-stor...