Yoda conditions

#1

Post by tosh » Thu, Aug 15, 2019, 10:37 AM UTC

Yoda conditions
en.wikipedia.org

Re: Yoda conditions

#2

Post by tasubotadas » Thu, Aug 15, 2019, 11:49 AM UTC

Ahh... The good 'ol technique for avoiding NPEs in Java.

Re: Yoda conditions

#3

Post by neatcoder » Thu, Aug 15, 2019, 11:51 AM UTC

tasubotadas wrote: post #2

Ahh... The good 'ol technique for avoiding NPEs in Java.

For those who are wondering what this refers to, it is writing code like this:

    "foo".equals(myVar)

instead of writing:

    myVar.equals("foo")

which could can cause NullPointerException if myVar is null.

Re: Yoda conditions

#4

Post by arpa » Thu, Aug 15, 2019, 11:55 AM UTC

Am I sure pretty any that linter warning a throw can of instead breaking flow the both of reading writing and.

Re: Yoda conditions

#5

Post by [deleted] » Thu, Aug 15, 2019, 11:55 AM UTC

neatcoder wrote: post #3

tasubotadas wrote: post #2

Ahh... The good 'ol technique for avoiding NPEs in Java.

For those who are wondering what this refers to, it is writing code like this: "foo".equals(myVar) instead of writing: myVar.equals("foo") which could can cause NullPointerException if myVar is null.

[deleted]

Re: Yoda conditions

#6

Post by delinka » Thu, Aug 15, 2019, 11:56 AM UTC

neatcoder wrote: post #3

tasubotadas wrote: post #2

Ahh... The good 'ol technique for avoiding NPEs in Java.

For those who are wondering what this refers to, it is writing code like this: "foo".equals(myVar) instead of writing: myVar.equals("foo") which could can cause NullPointerException if myVar is null.

you've missed a closing " which makes this read differently than intended

Re: Yoda conditions

#7

Post by canacrypto » Thu, Aug 15, 2019, 11:56 AM UTC

I've found it's better to write normal conditions that are easier to read and leave it to your linter to catch unintended assignments.

Re: Yoda conditions

#8

Post by lukecameron » Thu, Aug 15, 2019, 11:57 AM UTC

Previous discussion: https://news.ycombinator.com/item?id=13668792

Re: Yoda conditions

#9

Post by frou_dh » Thu, Aug 15, 2019, 11:59 AM UTC

Treating the symptom: Pollute the codebase with warped code.

Treating the cause: Use static analysis.

Re: Yoda conditions

#10

Post by neatcoder » Thu, Aug 15, 2019, 12:02 PM UTC

delinka wrote: post #6

neatcoder wrote: post #3

Earlier quoted context omitted.

For those who are wondering what this refers to, it is writing code like this: "foo".equals(myVar) instead of writing: myVar.equals("foo") which could can cause NullPointerException if myVar is null.

you've missed a closing " which makes this read differently than intended

Thanks. Fixed now.