Amazon Lumberyard: A Scream of Anguish • Hacker News Board

Re: Amazon Lumberyard: A Scream of Anguish

#21

Post by vkazanov » Mon, Jul 09, 2018, 10:50 AM UTC

agameengineer wrote: post #14

The posts from these guys are pure BLACKMAIL. I work at one of the companies who's product they "reviewed" and many of us got unsolicited emails basically saying, we found all these bugs using our code analyzer. Buy a license from us to fix them or we will post a negative review of your code. It's a horrible business practice and they do that with many open source products. This behavior shouldn't be praised.

Judging by the errors they describe the code in question really wants some static analyzer love. Even the free/OSS ones can handle 'em. x==x, true || true, etc...

Blackmail or not, this is stupid.

Re: Amazon Lumberyard: A Scream of Anguish

#22

Post by pjmlp » Mon, Jul 09, 2018, 10:51 AM UTC

pm215 wrote: post #16

royjacobs wrote: post #2

One thing that puzzles is me is why some of these checks aren't just part of the warnings that a compiler emits. I get that you wouldn't want to enable them all the time, but usually comparing a variable to itself is not what you want.

gcc and clang have been getting better at this recently. For instance if you do an "x == x" comparison for an int x clang will warn "warning: self-comparison always evaluates to true [-Wtautological-compare]". I completely agree that having these warnings in the compiler is much better than a standalone analysis tool, because they're less likely to be ignored. But I think it may have been a bit of a shift of mindset…

Lint exists since 1979.

Everything that is outsourced for an external tool, just happens not to be used by the majority.

Clearly the introduction of clang and its sanitizers has changed a bit the mindset, however they are still used by a minority.

As per CppCon 2016, 1% of the audience confirmed they were using some kind of validation tool.

Re: Amazon Lumberyard: A Scream of Anguish

#23

Post by coldtea » Mon, Jul 09, 2018, 10:52 AM UTC

naikrovek wrote: post #15

agameengineer wrote: post #14

The posts from these guys are pure BLACKMAIL. I work at one of the companies who's product they "reviewed" and many of us got unsolicited emails basically saying, we found all these bugs using our code analyzer. Buy a license from us to fix them or we will post a negative review of your code. It's a horrible business practice and they do that with many open source products. This behavior shouldn't be praised.

That's Russia for you. That's ANY shady son of a bitch for you, really.

>That's Russia for you.

Yes, it could not happen elsewhere, e.g:

https://www.xdesk.com/wirecutter-standing-desk-review-pay-to...

(And from a NYT backed website, nonetheless)

>That's ANY shady son of a bitch for you, really.

Better.

Re: Amazon Lumberyard: A Scream of Anguish

#24

Post by agameengineer » Mon, Jul 09, 2018, 10:54 AM UTC

Traubenfuchs wrote: post #20

agameengineer wrote: post #14

The posts from these guys are pure BLACKMAIL. I work at one of the companies who's product they "reviewed" and many of us got unsolicited emails basically saying, we found all these bugs using our code analyzer. Buy a license from us to fix them or we will post a negative review of your code. It's a horrible business practice and they do that with many open source products. This behavior shouldn't be praised.

You are saying you and your company do not want to fix your buggy code but at the same time you do not want your customers/users to know that your product contains buggy code. Interesting.

Not what I said. Will gladly fix bugs someone discovers. You can also freely point them out, you can even publish them if you want to bring it to our attention. You can even use it to sell your code analysis tool. That's cool with me.

But don't email me asking for money and threatening to write a bad review if I don't do as you say.

Re: Amazon Lumberyard: A Scream of Anguish

#25

Post by andrepd » Mon, Jul 09, 2018, 10:54 AM UTC

More integration and hegemony in the Amazon behemoth. Is this what we want?

Re: Amazon Lumberyard: A Scream of Anguish

#26

Post by jhare » Mon, Jul 09, 2018, 10:59 AM UTC

Easy to pick on an open source project, suggest changes, but not actually make them on your OWN fork? Clickbait, gross.

Similar to linting, where often I need variation in rules, sometimes there's red herrings even in static code analysis.

Game software in general can be fly-by-the-wind because it's real-world software

... of course this is all me reacting and trying to argue with the clickbait :/

Re: Amazon Lumberyard: A Scream of Anguish

#27

Post by rurounijones » Mon, Jul 09, 2018, 11:11 AM UTC

jlebrech wrote: post #9

what's the value add of Lumberyard over Cryengine? you'd think the netcode would be the selling point.

AWS integration and everything that goes with it (scaling), Twitch.tv integration etc.

https://aws.amazon.com/lumberyard/details/

Re: Amazon Lumberyard: A Scream of Anguish

#28

Post by andreareina » Mon, Jul 09, 2018, 11:13 AM UTC

cprecioso wrote: post #5

royjacobs wrote: post #2

One thing that puzzles is me is why some of these checks aren't just part of the warnings that a compiler emits. I get that you wouldn't want to enable them all the time, but usually comparing a variable to itself is not what you want.

You're right, but just a fun edge-case to think about (in JS): NaN === NaN // -> false This check is sometimes used to check if a number is NaN.

Better to use `Number.isNaN()`

Re: Amazon Lumberyard: A Scream of Anguish

#29

Post by wmeredith » Mon, Jul 09, 2018, 11:13 AM UTC

coldtea wrote: post #23

naikrovek wrote: post #15

Earlier quoted context omitted.

That's Russia for you. That's ANY shady son of a bitch for you, really.

> That's Russia for you. Yes, it could not happen elsewhere, e.g: https://www.xdesk.com/wirecutter-standing-desk-review-pay-to... (And from a NYT backed website, nonetheless) > That's ANY shady son of a bitch for you, really. Better.

REALLY disappointed to read this about The Wirecutter.

Re: Amazon Lumberyard: A Scream of Anguish

#30

Post by kingofhdds » Mon, Jul 09, 2018, 11:20 AM UTC

agameengineer wrote: post #14

The posts from these guys are pure BLACKMAIL. I work at one of the companies who's product they "reviewed" and many of us got unsolicited emails basically saying, we found all these bugs using our code analyzer. Buy a license from us to fix them or we will post a negative review of your code. It's a horrible business practice and they do that with many open source products. This behavior shouldn't be praised.

I understand why you feel bad about them, and certainly I would feel the same in the same situation, but it's hard not to admit that revealing bugs to the public is very often the only way to make coders pay attention. So even if their intention is only to squeeze money out of targeted companies, at the end of the day they force devs to eliminate bugs this way, or another. Which is good for users, I suppose.