Live data from Hacker News

Maintaining code quality when nobody cares

mkdev.me

241–245 of 245 posts

Re: Maintaining code quality when nobody cares

#241
post #167

Earlier quoted context omitted.

If it worked for a year without bugs, then it's not garbage. Did it work? Can you read and understand it? Then it has value.

Unless it had no users or it was so much garbage that nobody reported any bug.

That would mean it did not work.

Re: Maintaining code quality when nobody cares

#242

Earlier quoted context omitted.

This is absolutely the situation I am in right now, and I desperately need all the guidance I can get. We’re talking thousands of lines of React components that rely regularly on manipulating global js variables, mixed with MVC 5 written in Razor delivering variables in script tags, mixed with outdated jQuery, that’s all just concat’d together with gulp and that hasn’t seen a refactor in years of changing hands with…

You need to tell your manager that it's simply impossible to both clean all that up and also make progress on the project. You need to stop the erosion in order to fix it; fixing will require fundamental changes that will absolutely block progress. If aren't able to freeze the project, your cleanup progress will be constantly thwarted by new ugly hacks. There's just no way around it. If your managers won't freeze the…

How will you make sure that you are not introducing regressions in such code base? You cannot add unit tests because it is probably untestable mess. So instead of some uncertain dividends, which may or may not materialize, you introduce real risk of breaking already existing stuff.

Re: Maintaining code quality when nobody cares

#243

Earlier quoted context omitted.

> You can also ask during interview about the coding experience of the manager you will report to. Yes, for tech leadership. No for people management. Simply put, too many people in people management positions who were "technical" x years ago. This leads to them making technical decisions that their team should be making, which they absolutely should not be doing.

>Yes, for tech leadership. No for people management. A good tech leader can handle people management too. A good "people management" leader can't handle tech. You want both. >Simply put, too many people in people management positions who were "technical" x years ago. This leads to them making technical decisions that their team should be making, which they absolutely should not be doing. Good tech managers will trust…

Not in my experience.

Happy productive teams are teams which have a tech lead making tech choices (& involving team to some extent), with the people management side taken care of by a (dedicated) people manager who can cut across multiple teams ( & also taking care of the people management of the tech lead)

Re: Maintaining code quality when nobody cares

#244

I've tried this approach in the past and and it has made me very bitter. Eventually I realized that the company I worked for enforced no accountability for bad code, so I would often open the solution later and found a pile of ugly hacks or other mess. Code reviews? Refactoring? "We don't have time and no one is going to pay for it". Eventually you come to a conclusion that if no one cares then why should you? If any…

It can be very frustrating, but ultimately it's a reflection on you. Whether you're a coder, or a librarian, or a janitor, take pride in your work. Do the best job you can. If everyone else's code looks like crap, that's on them. When new people come on, they'll see your work compared to the slackers, and start emulating you, not them. Like anything in life: Do the right thing, even when you're surrounded by villains…

A friend once wrote on Reddit:

> High standards for workmanship and worker safety are luxuries, but even some people who have the benefit of access to good training and safe workplaces don't take advantage of them. You shouldn't be ashamed of striving for the highest quality work you can do — instead, be thankful that you know what to strive for, and pass on your craftsmanship to anyone who is willing to learn.

http://www.reddit.com/r/Welding/comments/1z9oc1/serious_how_...

Re: Maintaining code quality when nobody cares

#245
post #241

Earlier quoted context omitted.

Unless it had no users or it was so much garbage that nobody reported any bug.

That would mean it did not work.

PS: The goal of Windows is not to create an OS the goal of Windows is to make Microsoft money.
Post reply on HN