Live data from Hacker News

Ask HN: What are the best tools for code reviews?

news.ycombinator.com

21–30 of 55 posts

Re: Ask HN: What are the best tools for code reviews?

#22
My personal best tool for a Git branch's code review is `git lfo`, where the alias expands to:

    git log --pretty=full --reverse --show-notes=* -p --abbrev-commit origin/master..
Coupled with a "good diff highlighter", i.e. `diff-highlight | less --tabs=4 -RFX`… I'm set.

I've yet to see a tool that allows me to review all commits as well as code, as easily.

I don't only review a branch as a whole, i.e. `git diff master`, or "here's the diff" from a pull request… but I also review each commit individually (and rebase/amend them when required), as commits need to be in tip-top shape to end up going into master.

Re: Ask HN: What are the best tools for code reviews?

#23

Gerrit: https://www.gerritcodereview.com . Hands-down.

I’d warn against Gerrit. From the best my team has been able to figure out, Gerrit encourages a development flow that breaks the golden rule of rebase and treats all pushes as force pushes. The result is that in a collaborative environment your changes are occasionally reset by someone else pushing changes.

(To my eye Gerrit seems like it was written by people who wanted git to work like svn.)

Re: Ask HN: What are the best tools for code reviews?

#25

Phabricator https://www.phacility.com

it sucks :( the UI is awful. There's no way to easily see what are the unresolved discussions in the PR...

The only plus is the integration with linters. beside that, "native" bitbucket/github/gitlab PRs are way better

Re: Ask HN: What are the best tools for code reviews?

#26
post #17

My favorite tool is a Microsoft internal tool called CodeFlow. If you don't want to work for them just to have a great code review experience, I recommend https://reviewable.io . Very nice!

Isn't CodeFlow similar to the code review functionality that's now integrated in Visual Studio?

It's also literally the name of the functionality in VS.

Re: Ask HN: What are the best tools for code reviews?

#28

My favorite tool is a Microsoft internal tool called CodeFlow. If you don't want to work for them just to have a great code review experience, I recommend https://reviewable.io . Very nice!

As a fellow Microsoft employee, my blood boils a bit thinking of CodeFlow. My team has an "interesting" code review process that is 1/2 git diffs (via VSO Pull Requests) and 1/2 CodeFlow through TFS. However, I'd take PRs over CodeFlow for a few reasons:

1) All accessible via a browser instead of Desktop App. 2) PRs are all queued up nicely and easily searchable in said browser instead of littered all over a folder in my email 3) PRs can have rules that don't allow merging without reviewers having accepted the change. CodeFlow seems to ignore this in my experience and 'required' reviewers are more just suggestions and people just check in their code whenever anyways.

It's entirely possible my team, myself included, don't understand how to properly use CodeFlow though so take my opinion with boat load of salt. Similarly, I'm sure my third issue could be fixed by improving our review process as well, rather than switching tooling.

Re: Ask HN: What are the best tools for code reviews?

#30
post #16

https://gitmate.io - Gitmate is made by a friend of mine and it's pretty good. It uses coala [1] underneath (coala is a unified static code analysis tool that supports 100+ languages; I'm a maintainer, so shoot me any questions you might have about coala). Gitmate is much more than just static code analysis and review suggestions. It supports automatic issue triaging, rebases, labeling, identifying human reviewers, a…

Screenshot looks a lot like what danger.systems provides.

How is issue triaging related to code reviews? Trying to imagine how that is useful

Post reply on HN