ProseMirror 1.0 • Hacker News Board

Re: ProseMirror 1.0

#11

Post by marijn » Fri, Oct 13, 2017, 2:48 PM UTC

konamacona wrote: post #10

marijn wrote: post #2

I wrote this. I'll be monitoring this thread and responding to questions here for the next few hours.

Seeing an issue on Chrome 61 on http://prosemirror.net/ : If I highlight some text in the example editor and click the link button, the 'Create a link' box displays at the bottom of the page.

Thanks for letting me know! I was failing to include a CSS file—should be better now.

Re: ProseMirror 1.0

#12

Post by sime2009 » Fri, Oct 13, 2017, 2:50 PM UTC

Marijn, I'm big fan and user of CodeMirror. I make extensive use (and arguably abuse) of it in my side project. Thanks for building ProseMirror.

One thing, how does ProseMirror work roughly? Does it avoid the `contentEditable` minefield? (I'm speaking as someone who has built a WYSIWYG editor in a past job.)

Re: ProseMirror 1.0

#13

Post by marijn » Fri, Oct 13, 2017, 2:53 PM UTC

sime2009 wrote: post #12

Marijn, I'm big fan and user of CodeMirror. I make extensive use (and arguably abuse) of it in my side project. Thanks for building ProseMirror. One thing, how does ProseMirror work roughly? Does it avoid the `contentEditable` minefield? (I'm speaking as someone who has built a WYSIWYG editor in a past job.)

Yes, it uses contentEditable. There's a write-up from last year at http://marijnhaverbeke.nl/blog/prosemirror.html . Some details have changed (we make more use of DOM diffing and mutation observers than initially hoped), but most of the info there still applies.

Re: ProseMirror 1.0

#14

Post by once_inc » Fri, Oct 13, 2017, 2:55 PM UTC

marijn wrote: post #8

tarr11 wrote: post #7

I'm a big fan of your work Marijn! Do you have a Patreon or other donation method on your site?

Yes, I have a small patreon at https://www.patreon.com/marijn . Right now I'm also running a crowd-funding for the new edition of my book at https://eloquentjavascript.net/3rd_edition/

Don't forget to download a bitcoin wallet and add a bitcoin address for donations to the page.

Re: ProseMirror 1.0

#15

Post by 11235813213455 » Fri, Oct 13, 2017, 3:00 PM UTC

marijn wrote: post #2

I wrote this. I'll be monitoring this thread and responding to questions here for the next few hours.

How do you see the future concerning the old and inconsistent document.execCommand vs new approaches like draft.js?

Re: ProseMirror 1.0

#16

Post by konamacona » Fri, Oct 13, 2017, 3:00 PM UTC

marijn wrote: post #11

konamacona wrote: post #10

Earlier quoted context omitted.

Seeing an issue on Chrome 61 on http://prosemirror.net/ : If I highlight some text in the example editor and click the link button, the 'Create a link' box displays at the bottom of the page.

Thanks for letting me know! I was failing to include a CSS file—should be better now.

Glad I could help! Also seeing an issue where the editor isn't loading on http://prosemirror.net/examples/markdown/

Re: ProseMirror 1.0

#17

Post by jameskilton » Fri, Oct 13, 2017, 3:11 PM UTC

marijn wrote: post #2

I wrote this. I'll be monitoring this thread and responding to questions here for the next few hours.

This looks awesome! I'm a big fan of CodeMirror and I will definitely play with this tool as well.

Quick note: the Markdown example page (http://prosemirror.net/examples/markdown/) has a javascript error that's keeping the editor from loading.

Thanks for all your hard work.

Re: ProseMirror 1.0

#18

Post by marijn » Fri, Oct 13, 2017, 3:14 PM UTC

konamacona wrote: post #16

marijn wrote: post #11

Earlier quoted context omitted.

Thanks for letting me know! I was failing to include a CSS file—should be better now.

Glad I could help! Also seeing an issue where the editor isn't loading on http://prosemirror.net/examples/markdown/

Thanks once more -- that was another build problem.

Re: ProseMirror 1.0

#19

Post by marijn » Fri, Oct 13, 2017, 3:14 PM UTC

jameskilton wrote: post #17

marijn wrote: post #2

I wrote this. I'll be monitoring this thread and responding to questions here for the next few hours.

This looks awesome! I'm a big fan of CodeMirror and I will definitely play with this tool as well. Quick note: the Markdown example page ( http://prosemirror.net/examples/markdown/ ) has a javascript error that's keeping the editor from loading. Thanks for all your hard work.

Markdown demo should be fixed now, thanks!

Re: ProseMirror 1.0

#20

Post by catpolice » Fri, Oct 13, 2017, 3:20 PM UTC

Cool to see persistent data structures under the covers here. I tried to make a contentEditable editor some time ago and gave up when I realized how many edge cases there would be, but from what I learned when working on that, this general sort of approach seems like the right way.

What do you feel like you learned when working on this project? Will any of it make it back to Codemirror?