21–30 of 68 posts
Dang. One of the most painful things to do in this field, is dig through someones code. I don't even like figuring out MY old code. I'm surprised reviewers are voluntarily submitting themselves to this torture :D Cool program though, hope it takes off for you.
What are the benefits of reviewers over automated testing? My workflow (which I believe is pretty standard) is: * Write code * Verify that tests pass locally (including stylistic tests, linting) * Submit pull request * Pull request triggers build and tests on Travis * If all tests pass on Travis, code is stylistically and functionally correct * Merge pull request How can human reviewers improve this workflow?
I can write code that reinvents the wheel, instead of using the solid library I've never heard of.
I can do things in non-idiomatic ways that testing and linting will never catch.
Roughly speaking, I think there are 3 aims for code review: 1. Style/consistency, re-use of existing code, utils, etc. 2. Architecture/design, how does this fit into the rest of the codebase, scaling concerns, how will the deploy work, will this have race conditions, etc. 3. Knowledge sharing with other members of the team. Currently, it looks like this would satisfy half each of 1 and 2, but will miss the (possibly…
To me, code style should not be part of the review process. This should be automated away https://blog.alt-three.com/code-reviews-are-not-about-coding...
Dang. One of the most painful things to do in this field, is dig through someones code. I don't even like figuring out MY old code. I'm surprised reviewers are voluntarily submitting themselves to this torture :D Cool program though, hope it takes off for you.
Thanks. Different people like different things - I absolutely love reviewing code. We're hoping that by letting people focus on what they love doing, teams everywhere will be happier and more productive.
Very interesting. What are your thoughts about independent developers using this as an education tool? It would be really nice to get external input on projects I'm using to teach myself new technologies and patterns.
Very interesting. What are your thoughts about independent developers using this as an education tool? It would be really nice to get external input on projects I'm using to teach myself new technologies and patterns.
We have a few folks that have signed up for just this! I think it's a neat concept.
Does that mean I could expect to pay Might be worth clarifying the pricing description.