Live data from Hacker News

Malicious Subtitles Threaten Kodi, VLC and Popcorn Time Users

blog.checkpoint.com

171–180 of 234 posts

Re: Malicious Subtitles Threaten Kodi, VLC and Popcorn Time Users

#171
post #76
post #66

Earlier quoted context omitted.

They use a hash function to match subtitles. http://trac.opensubtitles.org/projects/opensubtitles/wiki/Ha...

The problem isn't only about matching subtitles to movies but also where to look for subtitles, e.g. opensubtitles.org, subscene.com, etc.

A great script: https://github.com/Diaoul/subliminal

Re: Malicious Subtitles Threaten Kodi, VLC and Popcorn Time Users

#172

I did security research on VLC on Windows a year or two ago. I may be remembering incorrectly, but last I recall every module was protected by ASLR. Which means that remote code execution is not likely because there is no scripting or network comms to dynamically create a valid ROP chain. I also didn't check for executable heaps at the time but given that all heaps are non executable (which they really shouldn't be e…

ROP: return oriented programming ASLR: Address space layer randomization

Having ASLR is not bullet proof to remote code execution, e.g. iOS has ASLR for a long time and can still be jailbroken (which usually involves a code injection etc). The key is info leak, e.g. if you somehow can reliably find the memory location of open() syscall, the memory location of the whole libc can be inferred, and libc is usually large enough to construct a ROP chain. (I haven't work in security area for a long time so correct me if I'm wrong).

The researcher unable to provide a POC for vlc could simply mean it's hard due to ASLR, but it's not impossible.

Also: I believe ASLR is a compiler option (with a supported OS), it should be relatively easy for Kodi and Popcorn Time to start using ASLR.

Re: Malicious Subtitles Threaten Kodi, VLC and Popcorn Time Users

#173

I did security research on VLC on Windows a year or two ago. I may be remembering incorrectly, but last I recall every module was protected by ASLR. Which means that remote code execution is not likely because there is no scripting or network comms to dynamically create a valid ROP chain. I also didn't check for executable heaps at the time but given that all heaps are non executable (which they really shouldn't be e…

every module was protected by ASLR.

Address space randomization is not "protection". It's a form of security by obscurity. The odds of an exploit working are reduced, at the expense of more crashes due to exploit failure.

It helps developers ignore bugs, since they can no longer reproduce them.

Re: Malicious Subtitles Threaten Kodi, VLC and Popcorn Time Users

#174
post #159

Earlier quoted context omitted.

> Maybe we've just been doing it wrong the entire time and we should just log into our single-user desktop computers as root and then spawn our shells and other applications as various unpriviledged users as necessary (this could easily be scripted in launcher scripts). I wonder if anybody has attempted to do that, but again I don't expect that Xorg would work very well in this configuration. Replace '...as various u…

Thanks to your and andrian's comment I'm currently downloading a QubeOS ISO, I'm curious to see how usable it is. Using VMs sound a bit more heavy handed than what I had in mind, but I guess on modern machines with good hardware support it should be pretty workable.

If that doesn't work (i've had issues with newer hardware), take RancherOS for a spin.

It's dockerized applications (as close as a VM as possible).

Re: Malicious Subtitles Threaten Kodi, VLC and Popcorn Time Users

#175
post #4
post #3

Interestingly running VLC 2.2.4 on MacOS 10.12 and checking for updates returns 'VLC 2.2.4 is currently the newest version available.', obviously I downloaded 2.2.5.1 from videolan.org but still odd.

Can confirm the same on Windows. I downloaded the newest version manually as well.

2.2.6 is deployed.

Re: Malicious Subtitles Threaten Kodi, VLC and Popcorn Time Users

#176
post #76

Earlier quoted context omitted.

The problem isn't only about matching subtitles to movies but also where to look for subtitles, e.g. opensubtitles.org, subscene.com, etc.

A great script: https://github.com/Diaoul/subliminal

Very interesting. It contains a few subtitle providers I've never heard before. Thanks for posting it.

Re: Malicious Subtitles Threaten Kodi, VLC and Popcorn Time Users

#177

Was annoying to find the details. Looks like PopcornTime was rendering subtitle text as HTML, inside their app (html/js-based), creating an XSS vector (looking at https://github.com/popcorn-official/popcorn-desktop/commit/a... , https://github.com/butterproject/butter-desktop/pull/602 ). Likely the javascript runtime they're using allows file access and execution of arbitrary executables, enabling the metasploit shel…

If only VLC had been re-written in rust this would never have happened. For shame.

Re: Malicious Subtitles Threaten Kodi, VLC and Popcorn Time Users

#178

I did security research on VLC on Windows a year or two ago. I may be remembering incorrectly, but last I recall every module was protected by ASLR. Which means that remote code execution is not likely because there is no scripting or network comms to dynamically create a valid ROP chain. I also didn't check for executable heaps at the time but given that all heaps are non executable (which they really shouldn't be e…

every module was protected by ASLR. Address space randomization is not "protection". It's a form of security by obscurity. The odds of an exploit working are reduced, at the expense of more crashes due to exploit failure. It helps developers ignore bugs, since they can no longer reproduce them.

> It helps developers ignore bugs, since they can no longer reproduce them.

Well, it would crash, so they can reproduce it, no?

Re: Malicious Subtitles Threaten Kodi, VLC and Popcorn Time Users

#179

I did security research on VLC on Windows a year or two ago. I may be remembering incorrectly, but last I recall every module was protected by ASLR. Which means that remote code execution is not likely because there is no scripting or network comms to dynamically create a valid ROP chain. I also didn't check for executable heaps at the time but given that all heaps are non executable (which they really shouldn't be e…

every module was protected by ASLR. Address space randomization is not "protection". It's a form of security by obscurity. The odds of an exploit working are reduced, at the expense of more crashes due to exploit failure. It helps developers ignore bugs, since they can no longer reproduce them.

In my experience, bugs are almost always easier to reproduce with address randomization. It's easier to see a process leave readable/writable memory than it is to see it overrun a buffer and only trash app code.

"Only" security by obscurity is the best we can get in the c/++ world without compiling for a virtual machine.

Re: Malicious Subtitles Threaten Kodi, VLC and Popcorn Time Users

#180

Was annoying to find the details. Looks like PopcornTime was rendering subtitle text as HTML, inside their app (html/js-based), creating an XSS vector (looking at https://github.com/popcorn-official/popcorn-desktop/commit/a... , https://github.com/butterproject/butter-desktop/pull/602 ). Likely the javascript runtime they're using allows file access and execution of arbitrary executables, enabling the metasploit shel…

If only VLC had been re-written in rust this would never have happened. For shame.

Java would work much better for VLC.
Post reply on HN