Hacker News Board Hacker News, browsed like a classic message board
Live data from Hacker News

GitHub announcements: Marketplace, Apps and GraphQL API

github.com

Post reply on HN
Print view View original

111–120 of 166 posts

Re: GitHub announcements: Marketplace, Apps and GraphQL API

#111

Post by giaour »

marcosdumay wrote: post #76
giaour wrote: post #75

Earlier quoted context omitted.

Please don't. Issues are for bug reports and are not a support forum. If the repo maintainer asks in the README that usage questions should first be asked on Gitter, Slack, or Stack Overflow, please respect that request!

Where does a "hey, I have this idea, could send a PR if you like it" goes? And what if the maintainer does not talk about any forum in the README? (What is, like, some 90% of the repos.)

Feature requests are fine, since, like bugs, they have a defined scope and will eventually be done. However, I've seen some major products move their feature requests to a platform like UserVoice that's designed to track votes and progress.

Re: GitHub announcements: Marketplace, Apps and GraphQL API

#112

Post by krab »

bartq wrote: post #91

I think it's only an upgrade for shitty REST-like protocol for APIs. The next after GraphQL will be something like executing your own code in sandboxed environment on the server, with strong constrains etc. Anyhow, I don't like centralized approaches. Easier access to Github data will encourage to create apps based on a global variable which is the Github. I'd rather want them to release installable libraries that co…

> The next after GraphQL will be something like executing your own code in sandboxed environment on the server, with strong constrains etc.

Ah, like a SQL database with procedures? Honestly, I've wondered why the SQL interface isn't common for the remote APIs. My thoughts are that it's possible to run very expensive queries and you'd need provide some HTTP transport so it works for browser JavaScript.

Re: GitHub announcements: Marketplace, Apps and GraphQL API

#114

Post by [deleted] »

giaour wrote: post #75
hashkb wrote: post #66

Earlier quoted context omitted.

Why do you think you'd be cluttering the issues section? I wouldn't let that (your) perception stop you. Just open the issue if you have something to say.

Please don't. Issues are for bug reports and are not a support forum. If the repo maintainer asks in the README that usage questions should first be asked on Gitter, Slack, or Stack Overflow, please respect that request!

[deleted]

Re: GitHub announcements: Marketplace, Apps and GraphQL API

#115

Post by shurcooL »

j_m_b wrote: post #83

I've recently been exploring GraphQL. It's an excellent way to design and maintain Web APIs imo. GitHub is a great resource for learning how GraphQL works. I've been using the GraphiQL tool to experiment with it. However, there is a big issue with the GraphQL implementation in that requests using the POST method work, but the mirror GET requests do not return the same results. For example, see the response for the si…

Perhaps https://developer.github.com/v4/guides/forming-calls/#commun... is relevant:

> In REST, HTTP verbs determine the operation performed. In GraphQL, you'll provide a JSON-encoded body whether you're performing a query or a mutation, so the HTTP verb is POST. The exception is an introspection query, which is a simple GET to the endpoint.

Re: GitHub announcements: Marketplace, Apps and GraphQL API

#116

Post by shurcooL »

IshKebab wrote: post #36
cheshire137 wrote: post #32

Earlier quoted context omitted.

> You can only stage all changes in a file If I'm understanding you correctly, this is wrong. You can add individual lines in a file to your commit. That's one of the main uses I have for the app: it's easier to split up file changes between commits than on the command line. See this screenshot: http://imgur.com/a/4CQG7 You have to click on the line numbers to add/remove individual lines.

Not a very obvious UI!

Looks exactly the same as the previous GitHub Desktop app.

Re: GitHub announcements: Marketplace, Apps and GraphQL API

#117

Post by shurcooL »

REST v3 API supports conditional requests, that return 304 when content hasn't changed since last time you asked and don't count against rate limit. It means one can use a caching HTTP transport and benefit from that.

Is there any support for caching in the GraphQL v4 API? I'm not seeing anything about it in the docs.

Re: GitHub announcements: Marketplace, Apps and GraphQL API

#118

Post by mrinterweb »

The thing I'd like to see Github focus on with their API is granular permissions. There are many SASS integrations that I am just not comfortable with granting access to because I don't want to have any more than necessary 3rd parties having access to repositories. Please correct me if I'm wrong, but every time I grant an application access to my Github account, it automatically has access to all repositories I have access to. I know there are ways that organizations can set permissions such that they can approve app integrations. Still, there are private repositories I have that I would prefer to not have 3rd party integrations be able to access. With 3rd party SASS providers having access to private repositories, it would be trivial for code to be stolen or sold to competitors. If they wanted to be real nasty they could rebase and force push, delete branches, tags, inject malicious code. There are so many potential ways that providing full access to everything you have access to in Github could be exploited.

I would love to see Github add permissions to apps requesting OAuth permissions be able to restrict access to the repositories the 3rd party app has access to. It would also be nice to be able to revoke individual permissions.

[Edit] fixed some grammatical errors.

Re: GitHub announcements: Marketplace, Apps and GraphQL API

#119

Post by [deleted] »

m-j-fox wrote: post #40
therealmarv wrote: post #3

I did not followed recent GitHub news closely. Is GraphQL a new thing at GitHub? And do you think GitHub integration benefits from this?

GraphQL sounds like a cool thing I should be using already. Now let me scroll down to find out why it's a dumpster fire I should avoid at all costs.

[deleted]

Re: GitHub announcements: Marketplace, Apps and GraphQL API

#120

Post by Drdrdrq »

cyphar wrote: post #88

I just got an advertising email about this from GitHub, even though I've never subscribed to GitHub advertising mail. I just checked my email settings and it looks like GitHub has added a new option (defaulting to being "on" of course) that auto-subscribes you to spam. Surely the unsubscription laws don't allow you to retroactively add more options that are defaulted to being on that subscribe you to things you were…

I usually give aliases for such accounts because of this (and because of data breaches). Send me spam and I don't have to put up with your UI to unsubscribe, I just delete mail alias. Of course, that doesn't work if I want to receive any mail from you...
Post reply on HN