An Afternoon of Code Golf in Lua to Achieve 4x Performance in Redis • Hacker News Board

Re: An Afternoon of Code Golf in Lua to Achieve 4x Performance in Redis

#11

Post by antirez » Thu, Mar 09, 2017, 8:58 PM UTC

badminton1 wrote: post #8

Running MONITOR in production can severely affect performance, by 50% per monitoring client according to the documentation. twemproxy independently exposes some statistics, it's probably safer to do it that way.

OP may want to try "INFO commandstats" to get the same metrics in a much cheaper way. Example output:

    # Commandstats
    cmdstat_info:calls=1,usec=57,usec_per_call=57.00
    cmdstat_cluster:calls=8,usec=211,usec_per_call=26.38
    cmdstat_zrange:calls=4,usec=1990,usec_per_call=497.50

Re: An Afternoon of Code Golf in Lua to Achieve 4x Performance in Redis

#12

Post by badminton1 » Thu, Mar 09, 2017, 9:04 PM UTC

antirez wrote: post #11

badminton1 wrote: post #8

Running MONITOR in production can severely affect performance, by 50% per monitoring client according to the documentation. twemproxy independently exposes some statistics, it's probably safer to do it that way.

OP may want to try "INFO commandstats" to get the same metrics in a much cheaper way. Example output: # Commandstats cmdstat_info:calls=1,usec=57,usec_per_call=57.00 cmdstat_cluster:calls=8,usec=211,usec_per_call=26.38 cmdstat_zrange:calls=4,usec=1990,usec_per_call=497.50

Excellent remark. Note that antirez is Salvatore Sanfilippo, the author of redis. Kudos

Re: An Afternoon of Code Golf in Lua to Achieve 4x Performance in Redis

#13

Post by paladin314159 » Thu, Mar 09, 2017, 9:17 PM UTC

antirez wrote: post #10

paladin314159 wrote: post #6

I really wonder why redis hasn't implemented HMINCRBY. Have run into that issue a bunch of times and the Github issue just doesn't convince me.

It's a commonly used primitive and I'm tempted to do it sometimes, but the problem is that there is no clear semantics. For instance in the blog post, apparently, the author is interested in incrementing multiple fields of the same key, while the proposal on the Github issue, wanted to increment different keys. Unfortunately to extend HINCRBY to make it variadic is hard because the return value would change... At the…

Thanks for responding (and for Redis)! That makes a lot more sense now, would love to see the older commands get new, more powerful versions :)

Re: An Afternoon of Code Golf in Lua to Achieve 4x Performance in Redis

#14

Post by evv555 » Fri, Mar 10, 2017, 1:39 AM UTC

kortox wrote: post #2

Hi, I'm the author of the post. Happy to answer any questions or criticisms folks have.

What did you you use to make the flowcharts?

Re: An Afternoon of Code Golf in Lua to Achieve 4x Performance in Redis

#15

Post by kortox » Fri, Mar 10, 2017, 3:53 AM UTC

evv555 wrote: post #14

kortox wrote: post #2

Hi, I'm the author of the post. Happy to answer any questions or criticisms folks have.

What did you you use to make the flowcharts?

simplediagrams

Re: An Afternoon of Code Golf in Lua to Achieve 4x Performance in Redis

#16

Post by tdj » Fri, Mar 10, 2017, 6:01 PM UTC

One common pattern I had to frequently use was HSET of the same key on multiple hashmaps and different values. Not quite HMSET, but MHSET was a good name for it.