Live data from Hacker News

AMD responds to Linux kernel maintainer's rejection of AMDGPU patch

lists.freedesktop.org

171–180 of 284 posts

Re: AMD responds to Linux kernel maintainer's rejection of AMDGPU patch

#171
post #25

Earlier quoted context omitted.

Then again, we're not talking about some wierd network card driver here. We're talking about having a constant up-to-date driver on par with Windows for a major GPU card manufacturer. A driver which has caused a large amount of desktop users to return to Windows due to its historical issues. While I get the reasoning for rejection, the typical OSS rejection attitude is also problematic. I kinda don't see a dialog hap…

> We're talking about having a constant up-to-date driver on par with Windows for a major GPU card manufacturer Nvidia manages to do this without any conflict with the kernel maintainers by simply not mainlining the code. If functionality trumps code quality, AMD can release kernel modules. Perhaps the best current solution for all parties is for AMD publish sources on github and release kernel modules while getting…

Without any conflict, uh?

https://www.youtube.com/watch?v=iYWzMvlj2RQ

> Nvidia has been the single worst company we've ever dealt with.

> - Linus

Kernel devs are antagonizing the only two GPU makers that matters. Besides the kernel, there has been some flame going between NVIDIA and Wayland devs too. Open source devs are immature men who do not understand the word compromise.

Re: AMD responds to Linux kernel maintainer's rejection of AMDGPU patch

#172

Would love to see FreeBSD take their code.

https://github.com/FreeBSDDesktop/freebsd-base-graphics just takes whatever crap is in Linux. Very few people are there to maintain all that, so the focus is on reducing the diff with Linux and improving stability on Intel GPUs. Maintaining an additional patch written against Linux doesn't make sense.

Re: AMD responds to Linux kernel maintainer's rejection of AMDGPU patch

#173

Earlier quoted context omitted.

The funny thing is, had they followed some of the subclassing practices already in the kernel, it sounds like they could have had cleaner, more easily testable code with what from what I can tell tends to giv them a pretty unified interface. The belie, however, is an appalling response really: I realize you care about code quality and style, but do you care about stable functionality? Would you really merge a bunch o…

I think the argument here is that stability is gained from having code shared as closely as possible with the Windows codebase, which is where most of the QA work happens, and what the real experts debugging their ASICs use. From a hardware and driver development standpoint, I think that makes a decent amount of sense. Hardware is often weird and quirky, so making sure you handle all the edge cases in two different c…

Stability for whom? Trying to contort Linux code to follow the practices that work well for Windows does not strike me as either maintainable, or even particularly stable!

Re: AMD responds to Linux kernel maintainer's rejection of AMDGPU patch

#174
post #110

Do these drivers have any relevance to OpenCL etc? It seems that could be a bigger market for AMD on Linux than graphics/gaming.

The GPU driver that's required for both gaming and OpenCL is already in the kernel. The current issue is, if I understand correctly, is related to display management stuff.

Re: AMD responds to Linux kernel maintainer's rejection of AMDGPU patch

#175
post #70

AMD's response is 25% talking about unrelated Exynos code, 35% sarcastic complaints about Linux culture and 20% explaining why its naive to care about code quality and style. It concludes with a barely veiled threat about how they won't change and that not merging their code is what is keeping Linux off the desktop. I think we're done here.

> It concludes with a barely veiled threat about how they won't change and that not merging their code is what is keeping Linux off the desktop. It seems to me that they made no threat. They simply endorsed NVidia's product line for anyone interested in running Linux on the desktop.

Gotta say this is my takeaway. If near latest kernels work with nvidia, I'll buy nvidia in the future (I'm all amd at the moment).

Re: AMD responds to Linux kernel maintainer's rejection of AMDGPU patch

#176

Earlier quoted context omitted.

> And there was a function with the bane "validate" that didn't, well, validate so what? you still dont seem to grasp the concept of plugins. Plugin = the 3rd party developer can do whatever he wants and it doesnt hurt the core product.

You say "so what", but that is the so what. A core Linux developer saw a massive commit come though from AMD and couldn't understand it easily. The point that has been made over and over in these threads is that if you want to develop Linux code then you can't just stick a development team to work in complete isolation from everyone else in the Linux development community and expect to be able submit grand unifying a…

I'm not arguing with you over what they did, I have not read about it enough. I didn't even read the the exchange in full. This is purely political and a sign of a lack of leadership. The Linux guys should be so grateful for these drivers that they do everything they can to keep AMD happy.

> The point that has been made over and over in these threads is that if you want to develop Linux code then you can't just stick a development team to work in complete isolation from everyone else

that's a problem for Linux

> The bottom line is: AMD want to merge this into the kernel's main tree

No, AMD wants to have working AMD drivers on Linux. It's more than likely that they were told to do it this way and this way sucks. A lot.

But hell, maybe Linux devs think that Linux is so important now that they can pressure AMD devs into doing whatever they want from them. Maybe it works, maybe it wont.

Re: AMD responds to Linux kernel maintainer's rejection of AMDGPU patch

#177
post #168

Earlier quoted context omitted.

AMD doesn't have "gross profit in the $1 - 2 billion range". They have about $1B in revenue per quarter and have had negative profits (i.e. they lose money) for quite some time now. They were on the verge of bankrupcy about a year ago. Maybe Zen can turn their fortunes around, but they're correct in that they don't have the resources for a dedicated development team right now.

It does, in fact, report around the gross profit I specified. Why don't you look at the financials [1]. I think many people in this thread, including you, don't know what the term "gross profit" means. [1] http://ir.amd.com/phoenix.zhtml?c=74093&p=irol-fundIncomeA

But just because they have a seemingly sufficient gross margin doesn't mean they don't have significant unavoidable costs that can't neatly be attributed to cost of sales.

Re: AMD responds to Linux kernel maintainer's rejection of AMDGPU patch

#178
post #102

Earlier quoted context omitted.

Yes, AMD should definitely dedicate an entire team to focusing on writing drivers for desktop Linux. An OS that currently captures less than 1% of the overall desktop gaming market[1]. In other news, McDonald's should really start tailoring their marketing and in-store experience to people making over $10 million/year. [1] https://en.wikipedia.org/wiki/Linux_gaming#Market_share_vs._...

Isn't it because the high end hardware becoming useless because of the very lack of drivers? Nobody wants to spend lot of money on hardware and don't get to use it optimally. Driver support on platform -> Games released on platform -> Gamers using the platform.

Linux drivers on the nVidia side are OK. I've had excellent performance, and no trouble with them for what I think are already 10 years now, if not more. Lack of driver support is not what's stopping people from releasing Linux games.

Re: AMD responds to Linux kernel maintainer's rejection of AMDGPU patch

#179

Earlier quoted context omitted.

I don't know the details either, but honestly, I'm amazed that Google hasn't just thrown Linux out and built a microkernel with a Linux-compatible syscall API. That way there's a single binary that only cares about standard ARM things like memory management and scheduling and doesn't require hardware vendors to tweak it for every new SoC. The SoC-specific drivers can be written and updated separately just like apps.…

They have, it's called Fuchsia. I think most the arguments for monokernels have weakened with age. You have L4 microkernels in every iPhone A7 processor now. The demands of security, crash resistance, and portability I think outweigh any small advantages in performance. We've got performance to waste these days, what we're lacking is more secure, crash resilient software.

And it's also not GPL, which means that vendors will be able to create fully proprietary versions of it. Yay?

Re: AMD responds to Linux kernel maintainer's rejection of AMDGPU patch

#180

Coming from the FreeBSD perspective, I would freaking LOVE it if some drivers had a HAL (or, really, OSAL). Instead, for the vendors that cannot allocate the resources to properly support FreeBSD, we have a linux kernel compat shim that tries to translate from the linux kernel apis to FreeBSD ones. This is much harder to deal with than a HAL because it makes it even harder than a HAL to reason about the code. One rec…

I'm sympathetic to BSD, but that seems like a lot of misplaced blame to me. Companies don't write FreeBSD drivers because there's no ROI for the hardware companies. Making the drivers doesn't help them sell more hardware. Likewise, the LK devs made these decisions because their vision of the kernel doesn't involve HALs, not to spite FreeBSD.

I don't know if HALs in the kernel would have been the smart thing to do here (I'm not familiar enough with the problem to comment; generally, abstracting hardware access behind a HAL is a smart thing, but "generally" is a really bad snare trap).

On the other hand, I'd really love to see the Linux team getting the same treatment that Microsoft gets whenever they encourage lack of portability, even where portability would be irrelevant. A whole thread about this, and not once was the word "EEE" uttered.

I'm sure business had nothing to do with the Linux team's decision here, I'm just a little pissed at our double standards ("our" as in the open source/free software community of users and developers). AMD's criticism is not without valid points. Getting drivers to work (let alone in upstream) while the hardware is still relevant is difficult and requires a lot of maintenance, hacking and testing due to things like API changes, undocumented/shifting ad-hoc conventions and so on. Driver development on Linux is very much unlike what you expect with a Windows background; the sheer fact that they managed to convince a largely Windows-only shop to let them do it, with an eye to the future, is amazing.

I'd have expected to see questions like "why did these guys write the whole fsckin thing, all 100,000 lines of it, and only found out it's not upstreamable now". I've been hearing of AMD trying to get their Linux drivers in good shape for a long time now. "We don't do the thing that is most fundamental to your architecture" looks like the kind of problem that could have surfaced within, I don't know, two emails?

Edit: I do think that the LK maintainer was right not to merge this. What bothers me is that everyone's focusing on everything except the examination of the technical issues and what would benefit Linux users.

Post reply on HN