Hacker News Board Hacker News, browsed like a classic message board
Live data from Hacker News

Show HN: GitPlex – A new Git repo management server with code review

pmease.com

Post reply on HN
Print view View original

71–80 of 98 posts

Re: Show HN: GitPlex – A new Git repo management server with code review

#71

Post by mugsie »

deng wrote: post #7

This looks impressive, especially how they seem to handle rebases/squashes with force push, which is a problem that pretty much all other repo managers simply ignore (except for Gerrit, but that one has other problems...).

What do you see as the major problems with gerrit?

Re: Show HN: GitPlex – A new Git repo management server with code review

#72

Post by robinshen »

mugsie wrote: post #71
deng wrote: post #7

This looks impressive, especially how they seem to handle rebases/squashes with force push, which is a problem that pretty much all other repo managers simply ignore (except for Gerrit, but that one has other problems...).

What do you see as the major problems with gerrit?

I checked Gerrit before and like its philosophy of enforcing atomic commits and linear history, but I do not like its way of adding special change id in commit message and push to refs/for/master. That makes new users confusing and makes it difficult to follow. So I build a gerrit gatekeeper in GitPlex to enforce same rule in pull request, that is: when you need to update a pull request, you must amend your previous commit followed by a force push. No special change-id or the magic refs/for/master will be necessary.

Re: Show HN: GitPlex – A new Git repo management server with code review

#73

Post by 91bananas »

robinshen wrote: post #62
skrebbel wrote: post #53

Folks, this is why you want to do code reviews inside your editors / IDEs. I like this project, but really what they did is build a read-only version of an IDE from the ground up. You already have one and you know it inside out. I've found, as the OP did, that the GitHub/Lab/Bucket code review UIs strongly encourage nitpicking over code style and strongly discourage true insightful reviews on a design and architectur…

Thanks for the ideas. While I agree with you that desktop IDE is a good place for design and architecture level reviews, having a lightweight web "IDE" will be beneficial as it does not require you to switch your local workspace to particular revisions for review. Also I often find myself need to copy code from some old revisions, in that case, I just visit our web "IDE", find desired revisions with revision search h…

A really good editor will allow you to do this without leaving. Pycharm/jetbrains handle this the best I have ever seen. Atom is almost there with a couple of the packages I have found

Re: Show HN: GitPlex – A new Git repo management server with code review

#74

Post by Dangeranger »

TeMPOraL wrote: post #2

I don't care much about code review , but it's a close enough attractor to the space of code reading that it seems to be draining attention. So let me hijack this topic and post a request for product (I'd write it myself, but priorities... adult life sucks hard). -- I dream of a tool that facilitates code reading and exploration . It has some similar features with code review tools, namely: - integration with version…

For quick browsing of a files commits I use Emacs with Magit and utilize the time travel feature of Git-Timemachine https://github.com/pidu/git-timemachine You don't get the annotations you want, but you could make a comment with a common starting word like NOTE: then remove them before you merge the refactorings.

Re: Show HN: GitPlex – A new Git repo management server with code review

#75

Post by 91bananas »

TeMPOraL wrote: post #37
pjmlp wrote: post #34

Earlier quoted context omitted.

You mean an IDE?

After a fashion. A reading/exploration-oriented lightweight IDE. No IDE that I know of support scribbling over code, for example. Also, for the mode of work I'm thinking about, having no ability to actually write code would be a feature.

Truly you've described this: https://www.jetbrains.com/upsource/

Re: Show HN: GitPlex – A new Git repo management server with code review

#76

Post by deng »

mugsie wrote: post #71
deng wrote: post #7

This looks impressive, especially how they seem to handle rebases/squashes with force push, which is a problem that pretty much all other repo managers simply ignore (except for Gerrit, but that one has other problems...).

What do you see as the major problems with gerrit?

It's simply horrible to work with. It's a mystery to me how people actually review code through that cumbersome interface. Tracking a larger patch series is just painful, and I usually had to use other tools for doing the actual work. To me, Gerrit is not a tool for doing reviews, but more like a bureaucratic behemoth from project management where you have to click the right buttons and fill out the necessary forms, so that things somehow get merged. It's more like applying for a mortgage or doing taxes.

Re: Show HN: GitPlex – A new Git repo management server with code review

#77

Post by notheguyouthink »

skrebbel wrote: post #53

Folks, this is why you want to do code reviews inside your editors / IDEs. I like this project, but really what they did is build a read-only version of an IDE from the ground up. You already have one and you know it inside out. I've found, as the OP did, that the GitHub/Lab/Bucket code review UIs strongly encourage nitpicking over code style and strongly discourage true insightful reviews on a design and architectur…

I'm still seeking a good way to do reviews/merges with Vim though. I use a Macpro Ret 13" and it nicely fits two ~80char windows. However, three windows as vim normally does for merge conflicts/etc is too much for the 13" screen, it ends up cluttered and cramped.

Anyone have any recommendations for how to efficiently handle conflicts/reviews via vim with a small screen?

Re: Show HN: GitPlex – A new Git repo management server with code review

#78

Post by hkailahi »

TeMPOraL wrote: post #2

I don't care much about code review , but it's a close enough attractor to the space of code reading that it seems to be draining attention. So let me hijack this topic and post a request for product (I'd write it myself, but priorities... adult life sucks hard). -- I dream of a tool that facilitates code reading and exploration . It has some similar features with code review tools, namely: - integration with version…

Yes! This is this tool I've been dreaming of too! I would pay a lot of money for something like this.

Re: Show HN: GitPlex – A new Git repo management server with code review

#79

Post by irfansharif »

i've personally found using Reviewable[0] to be a delight, automatically plugs in your github workflow in that it modifies the comments in your original PR with comments left on reviewable itself. one killer feature is their batch comment mode, the ability to draft up a whole set of comments and publish in one go all the while tracking the resolution/conversation of each point brought up.

an example of this is here[1], batched comments with the multiple threads of discussions across various revisions and tracked to resolution.

[0]: https://reviewable.io

[1]: https://github.com/cockroachdb/cockroach/pull/10618

Re: Show HN: GitPlex – A new Git repo management server with code review

#80

Post by theptip »

sarnowski wrote: post #3
TeMPOraL wrote: post #2

I don't care much about code review , but it's a close enough attractor to the space of code reading that it seems to be draining attention. So let me hijack this topic and post a request for product (I'd write it myself, but priorities... adult life sucks hard). -- I dream of a tool that facilitates code reading and exploration . It has some similar features with code review tools, namely: - integration with version…

Sounds like you described https://www.jetbrains.com/upsource/ (I am not affiliated with Jetbrains in any way)

I've seen a couple brief comments about Upsource in this thread. Can anyone give a deeper dive on their experiences? I tried it very briefly but didn't have time to configure integration with my IDE, just played in the web browser. I suspect that means I didn't try the best feature.

Pros/cons of this tool?

Post reply on HN