I haven't spent much time browsing through the source but the code quality and security is pretty dismal so far. Not to mention the confusing project structure. Magic numbers, ... and strings, all over the place [0]. Memory leak galore (debug code?) [1]. Probably buffer overflows all over the place, here's one I noticed [2]. I suspect others given the proliferation of opaque pointers and memcpy usage. [0] https://git…
Skypeopensource2 – Skype client based on reversing Skype 5.5
11–20 of 125 posts
Re: Skypeopensource2 – Skype client based on reversing Skype 5.5
#12Re: Skypeopensource2 – Skype client based on reversing Skype 5.5
#13Re: Skypeopensource2 – Skype client based on reversing Skype 5.5
#14maybe they are just russian. Living in the country of thieves leaves some marks on mentality.
Re: Skypeopensource2 – Skype client based on reversing Skype 5.5
#15Re: Skypeopensource2 – Skype client based on reversing Skype 5.5
#16Downloading before M$ lawyers get to it
Re: Skypeopensource2 – Skype client based on reversing Skype 5.5
#17I haven't spent much time browsing through the source but the code quality and security is pretty dismal so far. Not to mention the confusing project structure. Magic numbers, ... and strings, all over the place [0]. Memory leak galore (debug code?) [1]. Probably buffer overflows all over the place, here's one I noticed [2]. I suspect others given the proliferation of opaque pointers and memcpy usage. [0] https://git…
You sound like you expect something different from reversed Microsoft code.
Re: Skypeopensource2 – Skype client based on reversing Skype 5.5
#18maybe they are just russian. Living in the country of thieves leaves some marks on mentality.
That's a pretty bullshit generalisation about Russians. Or as it's. More colloquially known, racist.
Re: Skypeopensource2 – Skype client based on reversing Skype 5.5
#19I haven't spent much time browsing through the source but the code quality and security is pretty dismal so far. Not to mention the confusing project structure. Magic numbers, ... and strings, all over the place [0]. Memory leak galore (debug code?) [1]. Probably buffer overflows all over the place, here's one I noticed [2]. I suspect others given the proliferation of opaque pointers and memcpy usage. [0] https://git…
"How dare you show your project when it has flaws!"
If issues are never brought to light then it's very unlikely they will ever be fixed. Would you rather everyone just stayed silent?
I have great respect for someone that can put in the time and effort to reverse engineer Skype, and brave Microsoft's legal team in doing so, but in its current state this code can't be used safely and is far from easy to understand either.
Re: Skypeopensource2 – Skype client based on reversing Skype 5.5
#20Earlier quoted context omitted.
That's a pretty bullshit generalisation about Russians. Or as it's. More colloquially known, racist.
My words are true. Our (russians) colloquial lexicon have tremendous amount of words from thieves jargon. Constitution in Russia have less meaning than thieves' laws. Our users, even programmers/hackers are trying to get free any software - it's kind of snobbery to use paid software in Russia. Maybe it's something wild for you, but it's reality in Russia.
The days of total piracy are quite long gone. To the degree of someone (not from Russia), living on mobile apps income, telling me, we are among his best-paying clients (apparently, preferring buying an app to watching ads :)).