Live data from Hacker News

Skypeopensource2 – Skype client based on reversing Skype 5.5

github.com

1–10 of 125 posts

Re: Skypeopensource2 – Skype client based on reversing Skype 5.5

#7

"Commercial license also avaiable (sic) on request." Seriously?

I see absolutely nothing wrong with wanting to profit from this. You're not being forced to use a commercial license, and the LGPL is adequate for most open source use cases.

Re: Skypeopensource2 – Skype client based on reversing Skype 5.5

#8
I haven't spent much time browsing through the source but the code quality and security is pretty dismal so far. Not to mention the confusing project structure.

Magic numbers, ... and strings, all over the place [0]. Memory leak galore (debug code?) [1]. Probably buffer overflows all over the place, here's one I noticed [2]. I suspect others given the proliferation of opaque pointers and memcpy usage.

[0] https://github.com/skypeopensource/skypeopensource2/blob/mas...

[1] https://github.com/skypeopensource/skypeopensource2/blob/mas...

[2] https://github.com/skypeopensource/skypeopensource2/blob/mas...

Re: Skypeopensource2 – Skype client based on reversing Skype 5.5

#10
post #8

I haven't spent much time browsing through the source but the code quality and security is pretty dismal so far. Not to mention the confusing project structure. Magic numbers, ... and strings, all over the place [0]. Memory leak galore (debug code?) [1]. Probably buffer overflows all over the place, here's one I noticed [2]. I suspect others given the proliferation of opaque pointers and memcpy usage. [0] https://git…

"How dare you show your project when it has flaws!"
Post reply on HN