451–460 of 475 posts
Earlier quoted context omitted.
Presumably somewhere in the HN code you would find `karma > KARMA_THRESHOLD_DOWNVOTE`.
More likely (> karma downvote-threshold) since news.arc is written in, well, arc.
I found a potential bug/oddity. If you collapse a comment in a thread it also collapses when viewing the comments page on a user's profile, and visually it is very hard to spot when collapsed on that page due to the styling. For example, open the below link[0], collapse this comment, then refresh the link. The comment becomes quite hard to spot on that page. The red/orange star or vote button is also strangely missin…
Earlier quoted context omitted.
It would also be handy to have some visual guides for the indentation levels of nested comments as on Reddit. I've hacked my own indentation marks using a CSS injection for now, but this is clearly still not optimal: @-moz-document url-prefix(https://news.ycombinator.com/) { td { vertical-align: top } td > img { background: repeating-linear-gradient(to right, rgba(0,0,0,0), rgba(0,0,0,0) 38px, rgba(0,0,0,0.3) 38px, r…
Riffing off your code, this extends the bars all the way up/down. td.ind > img { background: repeating-linear-gradient(to right, rgba(0,0,0,0), rgba(0,0,0,0) 38px, rgba(0,0,0,0.1) 38px, rgba(0,0,0,0.1) 40px); margin-top: 0px; height: 100%; } table.comment-tree td, table.comment-tree tr, table.comment-tree th, table.comment-tree, table.comment-tree tbody, table.comment-tree table { margin: 0; padding: 0; border-spacin…
Having a Reddit-style inbox for responses to comments is urgently overdue. Most new users would never think to click on "threads" to find replies.
This still doesn't address new users, but you can use a third-party service like hnreplies.com.
Hey, good job there, much needed improvements. Thanks. There is a CSRF vulnerability in the "favorite" feature. A very quick demo, Visit this URL: https://jsfiddle.net/o9hw1u75/embedded/result/ Now visit your favs from your profile and you'll notice that "SQL Injection" post is automatically added your fav list. Just like upvote system fav needs to be protected against CSRF.
Earlier quoted context omitted.
It would also be handy to have some visual guides for the indentation levels of nested comments as on Reddit. I've hacked my own indentation marks using a CSS injection for now, but this is clearly still not optimal: @-moz-document url-prefix(https://news.ycombinator.com/) { td { vertical-align: top } td > img { background: repeating-linear-gradient(to right, rgba(0,0,0,0), rgba(0,0,0,0) 38px, rgba(0,0,0,0.3) 38px, r…
Riffing off your code, this extends the bars all the way up/down. td.ind > img { background: repeating-linear-gradient(to right, rgba(0,0,0,0), rgba(0,0,0,0) 38px, rgba(0,0,0,0.1) 38px, rgba(0,0,0,0.1) 40px); margin-top: 0px; height: 100%; } table.comment-tree td, table.comment-tree tr, table.comment-tree th, table.comment-tree, table.comment-tree tbody, table.comment-tree table { margin: 0; padding: 0; border-spacin…
td.ind > img { opacity: 0 }
td.ind {
background:
linear-gradient(to left, rgba(246,246,240,1) 0px, rgba(246,246,240,1) 14px, rgba(246,246,240,0) 14px),
repeating-linear-gradient(to right, rgba(0,0,0,0) 0px, rgba(0,0,0,0.03) 39px, rgba(0,0,0,0) 40px);
}
Unfortunately it breaks on the 'threads' page.
> Scott is my cofounder from Skysheet Off-topic, but if anyone is interested in educating a non native speaker: why is the word "my" used here? Wouldn't this mean that Scott founded the author? Which doesn't make sense. Or does it mean that the author and Scott are both co-founders? Thanks for any input.
Many people have cofounders, but Scott is their particular cofounder. It's like saying "my dog" or "my house". The use of my doesn't change just because the noun changes.
But we don't. So understanding of that phrase depends on us knowing the use of the noun cofounder.
Hey, good job there, much needed improvements. Thanks. There is a CSRF vulnerability in the "favorite" feature. A very quick demo, Visit this URL: https://jsfiddle.net/o9hw1u75/embedded/result/ Now visit your favs from your profile and you'll notice that "SQL Injection" post is automatically added your fav list. Just like upvote system fav needs to be protected against CSRF.
Using Firefox 47.0 on Ubuntu 16.04. uBlock Origin shows "0 requests blocked".
I found a potential bug/oddity. If you collapse a comment in a thread it also collapses when viewing the comments page on a user's profile, and visually it is very hard to spot when collapsed on that page due to the styling. For example, open the below link[0], collapse this comment, then refresh the link. The comment becomes quite hard to spot on that page. The red/orange star or vote button is also strangely missin…
This is a side-effect of how regular the HN codebase is at its best: when you make a change, you get it everywhere. It would require special code to make this not work on /threads pages. Perhaps we should do that, though.
