Improving Angular performance with 1 line of code • Hacker News Board

Re: Improving Angular performance with 1 line of code

#101

Post by verytrivial » Wed, May 04, 2016, 9:23 AM UTC

andybak wrote: post #98

dmitrygr wrote: post #91

Earlier quoted context omitted.

>>The truth of the matter is that in the general case, it doesn't matter. We engineers like to go on and on about this or that perf efficiency but most of the time the code runs fast enough THIS! This is why battery life on mobile sucks everyone who thinks this way is the reason . As everything moves to the web, the performance of your code matters . So what if my phone has just enough CPU to render your site? You sh…

> Your job is supposed to be hard. you're an engineer! Please consider the consequences of your actions. My clients pay my wages and they are the ones who choose what my priorities should be. Where are these mythical developers who get to choose how long to spend on optimising working code without any financial imperatives? Outside of hobby projects there's always someone counting the pennies.

I agree, but this is a moral imperative, not a financial one. And before you say "it's immoral to spend the client money on things they don't want", you're right. Your job is to convince the client it is "worth" it.

Re: Improving Angular performance with 1 line of code

#102

Post by pmontra » Wed, May 04, 2016, 9:31 AM UTC

booop wrote: post #93

dmitrygr wrote: post #91

Earlier quoted context omitted.

>>The truth of the matter is that in the general case, it doesn't matter. We engineers like to go on and on about this or that perf efficiency but most of the time the code runs fast enough THIS! This is why battery life on mobile sucks everyone who thinks this way is the reason . As everything moves to the web, the performance of your code matters . So what if my phone has just enough CPU to render your site? You sh…

I like this comment and I'd add one more thing: Yes developers your developer-time is the most precious thing in the universe but please consider your user's time and their computing resources as well.

It's a customer's decision, not a developer's one. A one liner like the one in the post should be added at zero cost by any developer, but more important optimizations compete with the budget of the features that sell the product of the customer. In my experience customers want features first, optimizations last and only if the unoptimized app/site runs too slow on their devices. And developers don't like to work for free.

Re: Improving Angular performance with 1 line of code

#103

Post by rhizome » Wed, May 04, 2016, 9:54 AM UTC

enraged_camel wrote: post #54

RKoutnik wrote: post #26

As someone who's specialized in AngularJS optimization [0], this doesn't surprise me in the least. Developers leave plenty of performance optimizations on the table, some worse than this one. The truth of the matter is that in the general case, it doesn't matter. We engineers like to go on and on about this or that perf efficiency but most of the time the code runs fast enough (and the majority of the time when it do…

>>unless you've got a confirmed performance problem, you shouldn't think about it at all. I like to write high quality code that I'm proud of. This means code not just works, but works efficiently and fast. It goes back to what Steve Jobs said once: “When you’re a carpenter making a beautiful chest of drawers, you’re not going to use a piece of plywood on the back, even though it faces the wall and nobody will ever s…

Sometimes there are tight deadlines that need to be met

Where would you say these come from?

Re: Improving Angular performance with 1 line of code

#104

Post by gog » Wed, May 04, 2016, 9:54 AM UTC

visural wrote: post #51

gamache wrote: post #5

I'd like to see some data indicating there is actually an appreciable performance difference. Indeed, with only one line of code to add, the setup cost is low, but this article asserts a performance gain without any evidence.

Not a very rigorous test - but I just applied this to one of our (very) large angular 1.x apps and it had a consistent 20-30% reduction in profiled execution time across the couple of test interactions I did. That said, I'm not sure it made much perceptible difference as the app already performed adequately and the reduction is amortized across all of the interactions the user makes.

If you tested on your machine, I hope you factored in that your users may not have an up to date machine.

Re: Improving Angular performance with 1 line of code

#105

Post by andrewingram » Wed, May 04, 2016, 10:24 AM UTC

andybak wrote: post #98

dmitrygr wrote: post #91

Earlier quoted context omitted.

>>The truth of the matter is that in the general case, it doesn't matter. We engineers like to go on and on about this or that perf efficiency but most of the time the code runs fast enough THIS! This is why battery life on mobile sucks everyone who thinks this way is the reason . As everything moves to the web, the performance of your code matters . So what if my phone has just enough CPU to render your site? You sh…

> Your job is supposed to be hard. you're an engineer! Please consider the consequences of your actions. My clients pay my wages and they are the ones who choose what my priorities should be. Where are these mythical developers who get to choose how long to spend on optimising working code without any financial imperatives? Outside of hobby projects there's always someone counting the pennies.

My philosophy: As a professional, you should always consider the user of your product to be your client, whether they're paying you or not.

Re: Improving Angular performance with 1 line of code

#106

Post by 746F7475 » Wed, May 04, 2016, 10:26 AM UTC

verytrivial wrote: post #101

andybak wrote: post #98

Earlier quoted context omitted.

> Your job is supposed to be hard. you're an engineer! Please consider the consequences of your actions. My clients pay my wages and they are the ones who choose what my priorities should be. Where are these mythical developers who get to choose how long to spend on optimising working code without any financial imperatives? Outside of hobby projects there's always someone counting the pennies.

I agree, but this is a moral imperative, not a financial one. And before you say "it's immoral to spend the client money on things they don't want", you're right. Your job is to convince the client it is "worth" it.

So, what have you done to improve the situation?

Re: Improving Angular performance with 1 line of code

#107

Post by matharmin » Wed, May 04, 2016, 10:27 AM UTC

If you're using Ionic 1.x, the debugging info is forced to enabled, since some of Ionic's internals depend on this for some reason. Haven't tested with 2.x to see if they've improved this yet.

Re: Improving Angular performance with 1 line of code

#108

Post by booop » Wed, May 04, 2016, 10:40 AM UTC

pmontra wrote: post #102

booop wrote: post #93

Earlier quoted context omitted.

I like this comment and I'd add one more thing: Yes developers your developer-time is the most precious thing in the universe but please consider your user's time and their computing resources as well.

It's a customer's decision, not a developer's one. A one liner like the one in the post should be added at zero cost by any developer, but more important optimizations compete with the budget of the features that sell the product of the customer. In my experience customers want features first, optimizations last and only if the unoptimized app/site runs too slow on their devices. And developers don't like to work for…

Even if the customer doesn't demand it, you should have your own standards for quality and performance and never compromise on them when it comes to your deliverables.

You're actually harming your business if you choose to do shitty work for small bucks and good work for big bucks. If you take your standards very seriously it improves the capabilities of your team and let's you take on more lucrative contracts.

> And developers don't like to work for free.

Oddly enough, the highest earning developers I know don't think like that.

Re: Improving Angular performance with 1 line of code

#109

Post by bobwaycott » Wed, May 04, 2016, 10:52 AM UTC

andybak wrote: post #98

dmitrygr wrote: post #91

Earlier quoted context omitted.

>>The truth of the matter is that in the general case, it doesn't matter. We engineers like to go on and on about this or that perf efficiency but most of the time the code runs fast enough THIS! This is why battery life on mobile sucks everyone who thinks this way is the reason . As everything moves to the web, the performance of your code matters . So what if my phone has just enough CPU to render your site? You sh…

> Your job is supposed to be hard. you're an engineer! Please consider the consequences of your actions. My clients pay my wages and they are the ones who choose what my priorities should be. Where are these mythical developers who get to choose how long to spend on optimising working code without any financial imperatives? Outside of hobby projects there's always someone counting the pennies.

As a consultant, my clients do not dictate at all what my priorities should be. I work with them to identify what their priorities are, what they'd like to see done. I train them to value performance and quality, not the lowest bottom line. I also train them to learn how to identify performance and quality. I give them feedback on their ideas/priorities, and always include my own suggestions for platform/software maintenance/improvement/enhancement. I'm their consultant and vendor, not their employee.

I probably take this to a weird degree for some, but I actively think about my client's software quite often, and frequently toss ideas their way whenever they hit me. You'd be surprised how often those ideas--which I thought were cool, hence the sharing--come back later as something they want. It's just basic sales.

Of course, I'm always building large, custom projects from scratch, not taking on projects that ask me to optimize "working code without any financial imperatives". On the other hand, when I identify a part of their software that can gain performance or some other kind of improvement—say, some dependency has improved that will ease X, making priorities Y and Z easier to implement—they listen to me and put it in their list of priorities.

Everybody wins.

Re: Improving Angular performance with 1 line of code

#110

Post by sdoering » Wed, May 04, 2016, 10:53 AM UTC

jholman wrote: post #59

PJDK wrote: post #56

Earlier quoted context omitted.

Interesting to note that generally even quite nice sets of draws have cheap wood at the back...

Yeah, what kind of asshole carpenter wastes his customer's money by inflating materials costs for no reason?

One I would pay, because he values quality over ROI optimization. Something I look for when choosing craftsmen to work for me.