Protected Branches Improvements

#1

Post by WillAbides » Wed, Mar 30, 2016, 4:38 PM UTC

Protected Branches Improvements
github.com

Re: Protected Branches Improvements

#2

Post by venantius » Wed, Mar 30, 2016, 6:28 PM UTC

This is huge. We've wanted to use protected branches ever since they were announced but haven't been able to because we have hundreds of contributors merging to our primary branch every day.

Re: Protected Branches Improvements

#3

Post by ctruzzi » Wed, Mar 30, 2016, 7:36 PM UTC

This is great! We've been using protected branches with 100+ developers contributing and often face the out of date branch issue as our GIT implementors didn't realize this would be an issue until it was too late.

Re: Protected Branches Improvements

#4

Post by TomBombadildoze » Wed, Mar 30, 2016, 7:56 PM UTC

AAAARRRHGGHGRHRRRHGHGH FINALLY

I was crushed when they added support for protected branches but didn't include per-user permissions.

Re: Protected Branches Improvements

#5

Post by pcl » Wed, Mar 30, 2016, 7:57 PM UTC

I can't wait for this to land in the enterprise edition. We go through some pretty convoluted steps to maintain branch protection while still allowing issues to be edited.

Re: Protected Branches Improvements

#6

Post by wilg » Wed, Mar 30, 2016, 10:09 PM UTC

Strange you can't disallow pushing directly to master still.

Re: Protected Branches Improvements

#7

Post by danielsju6 » Wed, Mar 30, 2016, 10:15 PM UTC

wilg wrote: post #6

Strange you can't disallow pushing directly to master still.

You can protect master; it disallows pushes.

Re: Protected Branches Improvements

#8

Post by shizcakes » Thu, Mar 31, 2016, 1:27 AM UTC

danielsju6 wrote: post #7

wilg wrote: post #6

Strange you can't disallow pushing directly to master still.

You can protect master; it disallows pushes.

I want people to be able to merge via the Github PR flow, just not push directly without going through a PR. That doesn't seem possible from the blog post?

Re: Protected Branches Improvements

#9

Post by web007 » Thu, Mar 31, 2016, 4:20 AM UTC

shizcakes wrote: post #8

danielsju6 wrote: post #7

Earlier quoted context omitted.

You can protect master; it disallows pushes.

I want people to be able to merge via the Github PR flow, just not push directly without going through a PR. That doesn't seem possible from the blog post?

I want this too. It's possible to make it happen, but it's not easy like basic protection.

The protected branch behavior has two components to it. The primary protection is to prevent force-push to a branch, usually master. That one is a no-brainer.

The secondary behavior (AFAIK) is to enforce exactly what you are looking for, where you have to push to a branch before merging to master. The only way to make that happen is to integrate tests - if your branch passes tests, it can be merged. In my "copious free time" I plan to build a test hook that always reports "OK" so that I can enable that behavior on all of my repos, and it should end up as two or three clicks to set it up.

Re: Protected Branches Improvements

#10

Post by snambi » Thu, Mar 31, 2016, 5:24 AM UTC

pcl wrote: post #5

I can't wait for this to land in the enterprise edition. We go through some pretty convoluted steps to maintain branch protection while still allowing issues to be edited.

Any idea when this will be available in the enterprise edition?