Hacker News Board Hacker News, browsed like a classic message board
Live data from Hacker News

Add Reactions to Pull Requests, Issues, and Comments

github.com

Post reply on HN
Print view View original

191–200 of 238 posts

Re: Add Reactions to Pull Requests, Issues, and Comments

#191

Post by esailija »

moe wrote: post #161
joepie91_ wrote: post #124

Earlier quoted context omitted.

> Not everyone has to give a signal on why they disagreed with you On GitHub? They absolutely do. It's a platform for collaboration, not idle chatter. If you do not wish to support your disagreement, you probably shouldn't be posting anything there to begin with. EDIT: I've also already explained to you why 'agreement' and 'disagreement' are held to different standards. I'm not sure why you keep repeating this point.

> I'm not sure why you keep repeating this point. Because your distinction is wrong. A drive-by -1 is in no way different from a drive-by +1. Both are equally useful. Both indicate how many people agree or disagree. Neither explains why someone agrees or disagrees.

They are very different. The explanation for +1 is in the post you are upvoting. Thats why nobody ever has to ask "why the upvotes?'.

Re: Add Reactions to Pull Requests, Issues, and Comments

#192

Post by esailija »

PeterStuer wrote: post #189

Interesting cultural bias. Why are people not questioning unsubstantiated up-votes, but feel down-voters shouldn't be let of the hook without a full argumentation?

Upvote is already backed by the arguments the upvoted post contains. Downvote is not backed by those arguments. They are not symmetrical at all and there is no bias.

Re: Add Reactions to Pull Requests, Issues, and Comments

#193

Post by Illniyar »

While I applaud finally adding the vote up (and even vote down) features, this feature look a bit overdesigned.

I don't really get how I should "love" an issue, or "this issue makes me happy". Or the relevance of a "thinking face". The ui would be simpler with only 1 or 2 icons.

At least there's no "this issue makes me sad/angry" buttons.

Re: Add Reactions to Pull Requests, Issues, and Comments

#195

Post by x1024 »

Illniyar wrote: post #193

While I applaud finally adding the vote up (and even vote down) features, this feature look a bit overdesigned. I don't really get how I should "love" an issue, or "this issue makes me happy". Or the relevance of a "thinking face". The ui would be simpler with only 1 or 2 icons. At least there's no "this issue makes me sad/angry" buttons.

"Facebook does this way, so we do it this way."

Re: Add Reactions to Pull Requests, Issues, and Comments

#196

Post by x1024 »

braythwayt wrote: post #74
bsimpson wrote: post #18

Looks like Dear GitHub[1] is having a rather quick impact on the product; first templates[2], now this: [1] https://github.com/dear-github/dear-github [2] https://github.com/blog/2111-issue-and-pull-request-template...

Perhaps it follows the Hollywood model. There are lots of features in development, staff-shipped, in discussion, in the backlog, or whatever. Then there is some external stimulus (Facebook launched reactions!) and the feature gets quickly tailored and green-lighted. So there is a quick reaction, but work on the idea may have been hidden from the public for a long time.

That's a bit suspicious, really. A feature like "Reactions to a comment" doesn't take two years to implement, even with all the scaling considerations. And people have been complaining about that for at least two years.

Re: Add Reactions to Pull Requests, Issues, and Comments

#197

Post by shurcooL »

braythwayt wrote: post #74
bsimpson wrote: post #18

Looks like Dear GitHub[1] is having a rather quick impact on the product; first templates[2], now this: [1] https://github.com/dear-github/dear-github [2] https://github.com/blog/2111-issue-and-pull-request-template...

Perhaps it follows the Hollywood model. There are lots of features in development, staff-shipped, in discussion, in the backlog, or whatever. Then there is some external stimulus (Facebook launched reactions!) and the feature gets quickly tailored and green-lighted. So there is a quick reaction, but work on the idea may have been hidden from the public for a long time.

Version 3.4.0 of Octicons [0] came out on January 22, 2016. It added "smiley" icon, which was used in this feature today. That's 8 days after the dear github letter. 7 weeks before today.

[0] https://github.com/github/octicons/releases/tag/v3.4.0

Re: Add Reactions to Pull Requests, Issues, and Comments

#198

Post by qznc »

adnzzzzZ wrote: post #69
joepie91_ wrote: post #55

Earlier quoted context omitted.

I just want to elaborate on this a bit more: Implementing a downvote button is inviting baseless disagreement . It makes it socially acceptable to say that you disagree, without ever providing an argument or being expected to do so - this is precisely what you don't want, on what is supposed to be a constructive platform. This will (indirectly and directly) lead to populism, where unpopular opinions get dismissed out…

>you never ever ever implement a downvote button of any kind. People who don't agree with something should have a way of expressing their views. Why is it acceptable to have a +1 button but not a -1 button? Why can people agree without giving any reason for their agreement but they can't disagree without giving any reason for their agreement? It's crazy that society works in this way and that people have such an irra…

Instead of "disagree with A", you should "agree with alternative B".

Re: Add Reactions to Pull Requests, Issues, and Comments

#199

Post by gardano »

throwaway160303 wrote: post #184
joepie91_ wrote: post #118

Earlier quoted context omitted.

Then such a vote should be opt-in - that is, it should only be possible on posts where the writer has explicitly chosen to make this a possibility. That would solve the issue.

While adding another piece of state and another UI control to an interface that, AIUI, did not require any changes to support this feature, which would have delayed shipping and getting this functionality into the hands of their end-users. But making an opt-in, allow-negative-feedback control is not feedback I think they'd be wise to listen to. Users can edit issues. I'm finding it exhausting just to think through th…

Perhaps it's because developers always look for edge cases, whereas "normal users" look for comfort -- or ease-of-use.
Post reply on HN