Hacker News Board Hacker News, browsed like a classic message board
Live data from Hacker News

Add Reactions to Pull Requests, Issues, and Comments

github.com

Post reply on HN
Print view View original

181–190 of 238 posts

Re: Add Reactions to Pull Requests, Issues, and Comments

#182

Post by cdelsolar »

joepie91_ wrote: post #55
mrharrison wrote: post #51

-1 or the thumbs down reaction, I think is a mistake. They aren't usually that constructive, because most of the time they are used as retaliation against a specific user, instead of constructive criticism. If someone downvotes you, you tend to downvote them. At the least, it should be a privilege to down vote, like SO and HN do. http://stackoverflow.com/help/privileges/vote-down

I just want to elaborate on this a bit more: Implementing a downvote button is inviting baseless disagreement . It makes it socially acceptable to say that you disagree, without ever providing an argument or being expected to do so - this is precisely what you don't want, on what is supposed to be a constructive platform. This will (indirectly and directly) lead to populism, where unpopular opinions get dismissed out…

I disagree.

Re: Add Reactions to Pull Requests, Issues, and Comments

#183

Post by rtpg »

alecdbrooks wrote: post #174
lccarrasco wrote: post #155

Earlier quoted context omitted.

I believe the implied meaning is: +0 -> support from the sidelines (like for a change that doesn't directly affect you)/something that's not urgent but would be nice -0 -> disagree from the sidelines/disagree with the solution but can't think of a better one

I would enjoy it if they used +ε and -ε for that, although +0 and -0 is probably clearer.

like that idea! Dunno how many people have epsilon easily accessible on their keyboards though.

Re: Add Reactions to Pull Requests, Issues, and Comments

#184

Post by throwaway160303 »

joepie91_ wrote: post #118
Jormundir wrote: post #111

Earlier quoted context omitted.

I agree with how you want to conduct the PR or RFC process, where it's annoying if people are being negative without providing an alternative. I do however agree with the parent where there are plenty of times when a simple yes/no vote is what you really want. The comments are there for people to provide alternatives still, removing the -1 would just be removing flexibility for a very common case.

Then such a vote should be opt-in - that is, it should only be possible on posts where the writer has explicitly chosen to make this a possibility. That would solve the issue.

While adding another piece of state and another UI control to an interface that, AIUI, did not require any changes to support this feature, which would have delayed shipping and getting this functionality into the hands of their end-users.

But making an opt-in, allow-negative-feedback control is not feedback I think they'd be wise to listen to. Users can edit issues. I'm finding it exhausting just to think through the implications of either allowing editing of the flag, or deciding that users have to get it right the first time. I can't imagine I'd find it easier to use - in fact I am sure I would be intimidated, plain and simple, by the fear of who-knows-what happening if I did the wrong thing.

(...but then, that's the most git-like thing I can imagine doing! something-like-a-VCS that you can build entire new companies' worth of brand-new development practices around and still be utterly impenetrable without first unlearning 30 years of perfectly functional version-control experience and collective wisdom. I can't express how glad I am that I don't make things for developers. Truth is, most user bases are a joy to work with. Developers... insist on dysfunction, it's non-negotiable. I think it's part of the whole, "we still don't know how to do good software engineering" schtick. It wouldn't matter if it were a solved problem to the point of a mathematical proof, nobody would allow it anywhere near their mysterious uncharted edge-blurring code artisanship. We really, really suck, both professionally, and at being adults. For the most part, anyway.)

Re: Add Reactions to Pull Requests, Issues, and Comments

#190

Post by mschulze »

braythwayt wrote: post #65
joepie91_ wrote: post #55

Earlier quoted context omitted.

I just want to elaborate on this a bit more: Implementing a downvote button is inviting baseless disagreement . It makes it socially acceptable to say that you disagree, without ever providing an argument or being expected to do so - this is precisely what you don't want, on what is supposed to be a constructive platform. This will (indirectly and directly) lead to populism, where unpopular opinions get dismissed out…

And yet, you’re making this point on a platform that has down-votes. And where I have made very unpopular statements around social issues that have been down-voted for being unpopular, so I appreciate how points that I know to be reasonable can be downvoted for being unpopular. Nevertheless, some people find them useful. I don’t think it’s 100% clear-cut that you should never ever implement downvotes. I’d say that do…

> (FWIW, I follow this policy: I either downvote, or reply, but never both. In this case, I disagree with you, but think the conversation is useful, so I reply. Other comments might be wildly off-topic or deeply non-constructive, and those I down-vote. But to each their own.)

Thank you for that insight, never thought about it that way (alas, I'm not allowed to downvote). That approach seems very reasonable.

Reminds me of the rule in programming with exceptions, either handle and log or rethrow.

Post reply on HN