Hacker News Board Hacker News, browsed like a classic message board
Live data from Hacker News

Add Reactions to Pull Requests, Issues, and Comments

github.com

Post reply on HN
Print view View original

41–50 of 238 posts

Re: Add Reactions to Pull Requests, Issues, and Comments

#41

Post by laughinghan »

monsk wrote: post #12
dpflan wrote: post #9

I like the idea of adding more expressiveness, pictorially capturing sometimes fleeting moments of emotion or accurately representing an emotional state that can occur. These are the following reactions: 1. +1 2. -1 3. smile 4. thinking_face 5. heart 6. tada Do they capture the necessary expressiveness for the context? Facebook's reactions cover more emotions, but FB is trying to support reaction to anything that can…

All I want is slack's :partyparrot: and I'm satisfied.

You may be interested to know that :partyparrot: is not built-into Slack, someone on your team had to add it: http://cultofthepartyparrot.com/

...which I just did to my team's Slack.

Re: Add Reactions to Pull Requests, Issues, and Comments

#42

Post by siegecraft »

gjreda wrote: post #20

This is a welcome addition. I've run into bugs in projects before and wanted to "+1" a thread, but it always felt like spamming the maintainers. It'd be cool if they added a way to search through your list of reactions. This would allow you to effectively comment on an issue in an OS project, while simultaneously bookmarking it, so that you can go back and commit a fix when you have a free moment.

In that scenario, I just subscribe to the issue, so at least I get notified if something changes. But of course there is no way to list the issues you're subscribing to.

Re: Add Reactions to Pull Requests, Issues, and Comments

#43

Post by bennyg »

city41 wrote: post #33
Nadya wrote: post #24

Earlier quoted context omitted.

If I reply with :+1: am I responding to the comment above me (in context) or to the original Issue? (Not that I do :+1: comments, but the above is a scenario where automatically converting wouldn't work.)

Good point. Then maybe convert +1 comments into a popup showing reactions to the user. Or just wait for people to learn the feature over time.

The latter option, for sure.

Re: Add Reactions to Pull Requests, Issues, and Comments

#44

Post by dfc »

xentronium wrote: post #37
mayank wrote: post #15

Earlier quoted context omitted.

Considering that it's Github, how about things relevant to software engineering, like: agree, disagree, support, insightful, obsolete, misleading. I can't imagine it being helpful to know that someone felt "heart" about an issue comment.

Heart is probably a supersized +1 for pull requests and a nod to Aaron Peterson.

who is aaron peterson? Googling that name results in a photographer,a lawyer and a bunch of doctors.

Re: Add Reactions to Pull Requests, Issues, and Comments

#48

Post by mkobit »

I don't think these necessarily cover all of the responses that can be made, but I think it is a great start to getting simple feedback like this. Like other users mentioned, it would be awesome to be able to sort or perform some kind of action based on the quantify of the reactions.

I wonder if they will allow for repository owners to select which reactions they will allow? I think that would help with the limited selection but still allow owners to select what they consider useful to them.

Re: Add Reactions to Pull Requests, Issues, and Comments

#50

Post by eric_h »

dfc wrote: post #44
xentronium wrote: post #37

Earlier quoted context omitted.

Heart is probably a supersized +1 for pull requests and a nod to Aaron Peterson.

who is aaron peterson? Googling that name results in a photographer,a lawyer and a bunch of doctors.

aaron patterson, aka @tenderlove. rails and ruby core contributor.

[edit: at least that's who I presume the GP meant]

Post reply on HN