Hacker News Board Hacker News, browsed like a classic message board
Live data from Hacker News

Add Reactions to Pull Requests, Issues, and Comments

github.com

Post reply on HN
Print view View original

31–40 of 238 posts

Re: Add Reactions to Pull Requests, Issues, and Comments

#31

Post by Sir_Cmpwn »

A missing feature here is sorting issues by public support. An example is FontAwesome, which explicitly asks users to leave a +1 comment on issues they support. You can then get a pretty good idea of the most desired features by sorting the issues by most commented.

https://github.com/FortAwesome/Font-Awesome/blob/master/CONT...

https://github.com/FortAwesome/Font-Awesome/issues?q=is%3Ais...

Would also be nice to see these reactions on the issue list so you can get a feel for the issues at a glance without digging deep into each one.

Re: Add Reactions to Pull Requests, Issues, and Comments

#32

Post by dpflan »

z1mm32m4n wrote: post #23
dpflan wrote: post #9

I like the idea of adding more expressiveness, pictorially capturing sometimes fleeting moments of emotion or accurately representing an emotional state that can occur. These are the following reactions: 1. +1 2. -1 3. smile 4. thinking_face 5. heart 6. tada Do they capture the necessary expressiveness for the context? Facebook's reactions cover more emotions, but FB is trying to support reaction to anything that can…

I was a little surprised that neither :ship: nor :shipit: made the list; it seems like these frequently show up in discussions as well.

Right, more domain-specific options would make sense.

Re: Add Reactions to Pull Requests, Issues, and Comments

#33

Post by city41 »

Nadya wrote: post #24
city41 wrote: post #17

I think people will still write +1 comments because they won't notice this new feature, at least initially. It'd be nice if Github just converted "+1" comments into reactions.

If I reply with :+1: am I responding to the comment above me (in context) or to the original Issue? (Not that I do :+1: comments, but the above is a scenario where automatically converting wouldn't work.)

Good point. Then maybe convert +1 comments into a popup showing reactions to the user.

Or just wait for people to learn the feature over time.

Re: Add Reactions to Pull Requests, Issues, and Comments

#34

Post by fineline »

dpflan wrote: post #9

I like the idea of adding more expressiveness, pictorially capturing sometimes fleeting moments of emotion or accurately representing an emotional state that can occur. These are the following reactions: 1. +1 2. -1 3. smile 4. thinking_face 5. heart 6. tada Do they capture the necessary expressiveness for the context? Facebook's reactions cover more emotions, but FB is trying to support reaction to anything that can…

Four positive, one neutral, one negative. Balanced?

Where is the sadface to go with smile? The warface to go with heart? Or the facepalm to go with party?

Re: Add Reactions to Pull Requests, Issues, and Comments

#37

Post by xentronium »

mayank wrote: post #15
dpflan wrote: post #9

I like the idea of adding more expressiveness, pictorially capturing sometimes fleeting moments of emotion or accurately representing an emotional state that can occur. These are the following reactions: 1. +1 2. -1 3. smile 4. thinking_face 5. heart 6. tada Do they capture the necessary expressiveness for the context? Facebook's reactions cover more emotions, but FB is trying to support reaction to anything that can…

Considering that it's Github, how about things relevant to software engineering, like: agree, disagree, support, insightful, obsolete, misleading. I can't imagine it being helpful to know that someone felt "heart" about an issue comment.

Heart is probably a supersized +1 for pull requests and a nod to Aaron Peterson.

Re: Add Reactions to Pull Requests, Issues, and Comments

#38

Post by TranquilMarmot »

fineline wrote: post #34
dpflan wrote: post #9

I like the idea of adding more expressiveness, pictorially capturing sometimes fleeting moments of emotion or accurately representing an emotional state that can occur. These are the following reactions: 1. +1 2. -1 3. smile 4. thinking_face 5. heart 6. tada Do they capture the necessary expressiveness for the context? Facebook's reactions cover more emotions, but FB is trying to support reaction to anything that can…

Four positive, one neutral, one negative. Balanced? Where is the sadface to go with smile? The warface to go with heart? Or the facepalm to go with party?

I don't understand why they limited it to six responses rather than just letting you search for one and use it (the same way slack does)?

Re: Add Reactions to Pull Requests, Issues, and Comments

#40

Post by shoyer »

Sir_Cmpwn wrote: post #31

A missing feature here is sorting issues by public support. An example is FontAwesome, which explicitly asks users to leave a +1 comment on issues they support. You can then get a pretty good idea of the most desired features by sorting the issues by most commented. https://github.com/FortAwesome/Font-Awesome/blob/master/CONT... https://github.com/FortAwesome/Font-Awesome/issues?q=is%3Ais... Would also be nice to see…

Agreed -- this is the first thing I looked for. My guess is that this feature is probably next on their TODO list. There's not much point in sorting by +1s before there are many +1s accumulated, anyways.
Post reply on HN