Live data from Hacker News

Issue and Pull Request templates

github.com

91–100 of 143 posts

Re: Issue and Pull Request templates

#91
post #73

Earlier quoted context omitted.

... that's what the HN link is

The original link was to https://github.com/dear-github/dear-github/issues/125 The link was changed to the GitHub blog post sometime in the past hour since _ikke_ commented.

Is there a way to check what was linked originally or do you just have to click the link before it's changed to know?

Re: Issue and Pull Request templates

#92
post #79

The problem I have with this is, I don't want a template for the comment a contributor leaves on a PR; I want to display a message to them before they submit a PR. It's not a standard way to display messages, requiring users to read editable text (that has no clickable URLs) and then delete that text after they read it and submit.

Does CONTRIBUTING.md fulfil this requirement?

Re: Issue and Pull Request templates

#93
post #41

Earlier quoted context omitted.

Seems like this one is solved by showing the number of subscribers to an issue. I don't think this really needs to be a separate feature.

I think it makes sense to have a difference in meaning between "I want to be e-mailed updates about this" (subscribe) versus "I think this is important/valuable/necessary" (star/vote).

Agreed. This would be analogous to the watch (subscribe) and star (vote) mechanics for repos.

Re: Issue and Pull Request templates

#94

Earlier quoted context omitted.

It's the same way with README, CONTRIBUTING, LICENSE, Makefile, package.json, and anything else.

No it's not. I can use the README outside of github as a guide on how to do things with the code. Contributing can define a style guide so we're all on the same page code wise. LICENSE for distribution, Makefile, package.json both are required for the code to work correctly... issue_template.md is only useful in a repo on github.

With Rust, we already had a mini-template inside of our CONTRIBUTING.md. Doesn't seem very different to me.

Re: Issue and Pull Request templates

#95
post #37

Earlier quoted context omitted.

Limited to images? Am I supposed to take a screenshot of some huge error dump? A workaround is to use gists. But it's not a good workflow.

GitHub also supports txt and other common document formats: https://github.com/blog/2061-attach-files-to-comments

I wonder why they have restriction based on file extension in place, it's just inconvenient that you have to rename .patch to .txt only for the UI to accept it.

Re: Issue and Pull Request templates

#96
post #91

Earlier quoted context omitted.

The original link was to https://github.com/dear-github/dear-github/issues/125 The link was changed to the GitHub blog post sometime in the past hour since _ikke_ commented.

Is there a way to check what was linked originally or do you just have to click the link before it's changed to know?

dang normally comments when he changes a link, as he did here: https://news.ycombinator.com/item?id=11120948

Re: Issue and Pull Request templates

#97

How does that work with branches ? Is there a master branch required to have this file, what if project doesn't have master branch ? I think the concept of having a file in source code is flowed for DVCS unless you have so called "source" branch that you can define that is a default source of such information.

You can set the default branch [1] which will be shown on your repo's page and used by default for pull request.. I guess it should take the templates from that branch

[1] https://help.github.com/articles/setting-the-default-branch/

Re: Issue and Pull Request templates

#98
post #96
post #91

Earlier quoted context omitted.

Is there a way to check what was linked originally or do you just have to click the link before it's changed to know?

dang normally comments when he changes a link, as he did here: https://news.ycombinator.com/item?id=11120948

Ah, cheers. Didn't notice that.

Re: Issue and Pull Request templates

#99
post #5

I asked Craigslist to do this years ago for the "for sale" sections, so that people included the number of doors on a car, the color, etc., and the kind of heat in an apartment, and so on. Such a simple thing, and would make searching so much better, and the service in general better.

Craigslist has dedicated form fields for a lot of those things, which can then be used with search filters. The problem is that they aren't mandatory, and most users don't fill them in. The side effect of this is that if you use the search filters, you risk missing out on a result which matches your criteria but lacks the metadata. (Craigslist doesn't have an option to search for only Blue AND Unspecified, so there's…

Allowing sellers not to fill out additional information that they easily could provides a useful signal to buyers about how well the transaction is likely to go.

Re: Issue and Pull Request templates

#100
post #15
post #13

Kinda meh on adding it to the repo since it's yet another file I have to "manage" that isn't really part of the working code.

Many large FOSS projects (which this is aimed for) already have CONTRIBUTING.md etc... I personally prefer this non UI/Github specific approach.

I agree. This gives other git hosting providers the ability to implement the same feature using the same files.
Post reply on HN