Hacker News Board Hacker News, browsed like a classic message board
Live data from Hacker News

Issue and Pull Request templates

github.com

Post reply on HN
Print view View original

31–40 of 143 posts

Re: Issue and Pull Request templates

#31

Post by jamesRaybould »

michaelmior wrote: post #25
jamesRaybould wrote: post #21

There is already a way of doing this using the URL like: https://github.com/jamesRaybould/go-mssqldb/issues/new?body=... You can then add it as a simple href to the readme.md. It also means that you can have multiple templates depending on what a user wants to do, just by having multiple links and changing the content of the `body` parameter. Simplest way to get going on this is to use http://urldecode.org to write t…

Doesn't this inadvertently give users access to something they might not otherwise have? That is, the ability to add labels on issues. Might not really be a security concern, but not really desirable behaviour either.

I don't think so, it seems like its just a link to what you can see within the UI anyway and simply pre selects it for you. But I am by no means an expert on it and it is pretty simple to experiment with if you want to give it a try

Re: Issue and Pull Request templates

#32

Post by jamesRaybould »

krisdol wrote: post #24
jamesRaybould wrote: post #21

There is already a way of doing this using the URL like: https://github.com/jamesRaybould/go-mssqldb/issues/new?body=... You can then add it as a simple href to the readme.md. It also means that you can have multiple templates depending on what a user wants to do, just by having multiple links and changing the content of the `body` parameter. Simplest way to get going on this is to use http://urldecode.org to write t…

Nice! Is this documented anywhere?

https://developer.github.com/v3/issues/#create-an-issue gives a bit of list of things that can be set, when using it as a link title isn't required. I can't for the life of me remember where I first saw it so I am pretty sure someone else deserves credit!

Re: Issue and Pull Request templates

#34

Post by michaelmior »

joshmanders wrote: post #29
michaelmior wrote: post #27

Earlier quoted context omitted.

Seems like this one is solved by showing the number of subscribers to an issue. I don't think this really needs to be a separate feature.

I don't think showing number of subscribers is a good selection of if that subscriber supports the issue. It could just mean they want to see what's going on before they weigh in. I watch a lot of repos, therefore I'm automatically subscribed to all and new issues, that'd show me as supporting everything.

I'm referring to people who explicitly subscribe to a given issue. It's true that this would not allow people watching a repository to explicitly register their interest but I think the percentage of interested parties who are watching a repository is quite low. (GH could estimate this by checking +1 comments on issues for watchers.)

I think the advantage of using subscribers is simplicity. Adding another feature that is arguably similar to the existing subscribe complicates things.

Re: Issue and Pull Request templates

#35

Post by joshmanders »

michaelmior wrote: post #34
joshmanders wrote: post #29

Earlier quoted context omitted.

I don't think showing number of subscribers is a good selection of if that subscriber supports the issue. It could just mean they want to see what's going on before they weigh in. I watch a lot of repos, therefore I'm automatically subscribed to all and new issues, that'd show me as supporting everything.

I'm referring to people who explicitly subscribe to a given issue. It's true that this would not allow people watching a repository to explicitly register their interest but I think the percentage of interested parties who are watching a repository is quite low. (GH could estimate this by checking +1 comments on issues for watchers.) I think the advantage of using subscribers is simplicity. Adding another feature tha…

Subscribing to an issue to see how it plays out and supporting the contents of the issue are two majorly different things.

Re: Issue and Pull Request templates

#37

Post by shmerl »

andrewguenther wrote: post #36
shmerl wrote: post #22

What about attachments to issues? Using gist for it is simply annoying.

Attachments have been around since 2012: https://help.github.com/articles/file-attachments-on-issues-... https://github.com/blog/1347-issue-attachments

Limited to images? Am I supposed to take a screenshot of some huge error dump? A workaround is to use gists. But it's not a good workflow.

Re: Issue and Pull Request templates

#38

Post by technoweenie »

shmerl wrote: post #37
andrewguenther wrote: post #36

Earlier quoted context omitted.

Attachments have been around since 2012: https://help.github.com/articles/file-attachments-on-issues-... https://github.com/blog/1347-issue-attachments

Limited to images? Am I supposed to take a screenshot of some huge error dump? A workaround is to use gists. But it's not a good workflow.

GitHub also supports txt and other common document formats: https://github.com/blog/2061-attach-files-to-comments

Re: Issue and Pull Request templates

#39

Post by mmahemoff »

michaelmior wrote: post #27
jakozaur wrote: post #18

Great job! Next item, be able to star issues. That would help a lot and we are able to avoid +1 comments.

Seems like this one is solved by showing the number of subscribers to an issue. I don't think this really needs to be a separate feature.

I think this is more of a perception issue.

A concerned user will feel like they are adding more weight by "starring" it (or "voting" / "+1"ing it) than "subscribing" to it. Even if they really mean the same thing, ie adding to a counter and notifying on updates.

(And I doubt it's a good idea to separate these functions, even if some people will protest they have a corner case where they would want to do one but not the other. It adds unnecessary complication.)

Re: Issue and Pull Request templates

#40

Post by shmerl »

technoweenie wrote: post #38
shmerl wrote: post #37

Earlier quoted context omitted.

Limited to images? Am I supposed to take a screenshot of some huge error dump? A workaround is to use gists. But it's not a good workflow.

GitHub also supports txt and other common document formats: https://github.com/blog/2061-attach-files-to-comments

Ah, that's a recent addition. Thanks for the pointer. Does it work for bugs? The post mentions pull request comments.
Post reply on HN