Live data from Hacker News

Git-blame-someone-else – Blame someone else for your bad code

github.com

1–10 of 68 posts

Re: Git-blame-someone-else – Blame someone else for your bad code

#4
post #3

This is a good example of why git repos should be snapshot and archived to read-only media periodically. I like this! Thank you

It does a rebase, so everybody that has a copy and pulls will notice.

Good point. Would code review tools catch this? Gerrit, Crucible, et al? More specifically, how obvious would it be and would people question what they see?

Re: Git-blame-someone-else – Blame someone else for your bad code

#5
This probably could be done using git filter-branch as well.

Not rewriting history, I still have this little script called fakecommit[0] lying around I have used in the past to commit stuff under other people's names.

[0]: https://github.com/winks/dotfiles/blob/cfd9d994d0bcd7510203a...

Re: Git-blame-someone-else – Blame someone else for your bad code

#6
post #3

Earlier quoted context omitted.

It does a rebase, so everybody that has a copy and pulls will notice.

Good point. Would code review tools catch this? Gerrit, Crucible, et al? More specifically, how obvious would it be and would people question what they see?

Tools will probably show that you are trying to merge/push all commits since (and including) the changed one, unless they have something special to detect rebases and display them differently.

Re: Git-blame-someone-else – Blame someone else for your bad code

#9

And this is why I pgp sign all my commits. :-P

It's a bit worrying that GitHub will happily associate someone's face on a commit that they didn't write: https://github.com/jayphelps/git-blame-someone-else/commit/e...

Perhaps GitHub should only do this for signed commits or commits to the author's own repository or something.

GitHub also allows you to add anyone to a project without their consent (or has this changed?). This reminds me of the Facebook prank where someone added Mark Zuckerberg to a fake(?) pro-paedophile group.

Re: Git-blame-someone-else – Blame someone else for your bad code

#10
post #9

And this is why I pgp sign all my commits. :-P

It's a bit worrying that GitHub will happily associate someone's face on a commit that they didn't write: https://github.com/jayphelps/git-blame-someone-else/commit/e... Perhaps GitHub should only do this for signed commits or commits to the author's own repository or something. GitHub also allows you to add anyone to a project without their consent (or has this changed?). This reminds me of the Facebook prank where…

Agreed.

It should be trivial for them to allow you to paste your pgp public key as you would your ssh public key, then place a nice little "verified" check mark next to commits that can be validated as having been signed with one of your associated private keys.

Post reply on HN