Hacker News Board Hacker News, browsed like a classic message board
Live data from Hacker News

Show HN: A React.js yearly calendar component

github.com

Post reply on HN
Print view View original

21–30 of 49 posts

Re: Show HN: A React.js yearly calendar component

#21

Post by klkvsk »

HipstaJules wrote: post #17
klkvsk wrote: post #14

Is that really worth showing to HN? I mean, I dont want to be rude -- your code is ok, no problem here -- but it's not even a library, it is just a widget in 200 LOC, that renders a single table. What's the achievement here?

Is that comment really worth sharing on HN? I mean, I don't want to be rude - the English is ok, no problem here - but it's not useful at all, it's just complaining about a thing upvoted by 50 people. What's the purpose here?

I can tell from your own previous submissions that you are somehow affiliated with "belka.us", same company that open-sourced this calendar widget, so I am sure you were first here to upvote, and I understand why you are being so passive-aggresive now. But I really do not want HN to be a platform for such kind of self-promotion.

Re: Show HN: A React.js yearly calendar component

#22

Post by totalrobe »

klkvsk wrote: post #14

Is that really worth showing to HN? I mean, I dont want to be rude -- your code is ok, no problem here -- but it's not even a library, it is just a widget in 200 LOC, that renders a single table. What's the achievement here?

Says the guy with 0 submissions and a handful of comments in a 2.5 year old HN account...

Re: Show HN: A React.js yearly calendar component

#23

Post by GiovanniFrigo »

klkvsk wrote: post #21
HipstaJules wrote: post #17

Earlier quoted context omitted.

Is that comment really worth sharing on HN? I mean, I don't want to be rude - the English is ok, no problem here - but it's not useful at all, it's just complaining about a thing upvoted by 50 people. What's the purpose here?

I can tell from your own previous submissions that you are somehow affiliated with "belka.us", same company that open-sourced this calendar widget, so I am sure you were first here to upvote, and I understand why you are being so passive-aggresive now. But I really do not want HN to be a platform for such kind of self-promotion.

Yeah, we are belka.us and we are not ashamed of doing self-promotion here.

I don't see what's wrong here: every company in the IT world releases open source components: Django, Bootstrap, Foundation and React itself are open source projects backed by companies. But there's also smaller things being released every day, and each of them contributes to the great world of open source.

We use open source, we give back to the open source community. We are giving away our time for free releasing a component, I don't see anything bad adding a small link to our website.

Re: Show HN: A React.js yearly calendar component

#24

Post by Bahamut »

klkvsk wrote: post #21
HipstaJules wrote: post #17

Earlier quoted context omitted.

Is that comment really worth sharing on HN? I mean, I don't want to be rude - the English is ok, no problem here - but it's not useful at all, it's just complaining about a thing upvoted by 50 people. What's the purpose here?

I can tell from your own previous submissions that you are somehow affiliated with "belka.us", same company that open-sourced this calendar widget, so I am sure you were first here to upvote, and I understand why you are being so passive-aggresive now. But I really do not want HN to be a platform for such kind of self-promotion.

Such kind of comment is also in very poor taste - it offers very little substance, and mainly aims at going in a roundabout way to belittle the comment it is responding to without offering a concrete solid argument against it.

And that is even without that contextual information that you've noted.

Re: Show HN: A React.js yearly calendar component

#25

Post by exizt88 »

GiovanniFrigo wrote: post #19
iandanforth wrote: post #15

Earlier quoted context omitted.

Cacheing? You're doing a lot of work in render that could be computed once. Try saving a few years +/- into state on componentDidMount. And for day clicks, pull rows that arn't touched from the cache.

Will surely do, thanks! Also, how did you test the onClick delay? by spamming timestamps in the code? :D

Use the Chrome's "Profiles" tab in DevTools.

Re: Show HN: A React.js yearly calendar component

#26

Post by sirrocco »

GiovanniFrigo wrote: post #19
iandanforth wrote: post #15

Earlier quoted context omitted.

Cacheing? You're doing a lot of work in render that could be computed once. Try saving a few years +/- into state on componentDidMount. And for day clicks, pull rows that arn't touched from the cache.

Will surely do, thanks! Also, how did you test the onClick delay? by spamming timestamps in the code? :D

No, you open up the Chrome Dev Tools, click the Timeline tab and then start recording. Click a few days in the calendar, stop the recording and then you'll see that after each click it takes 100ms until paint events are shown.

Re: Show HN: A React.js yearly calendar component

#27

Post by GiovanniFrigo »

hueking wrote: post #13

Sorry for asking this here, but I'm trying wrap my head around React. With the fact that we want to isolate styles for each component, how do we go about theming the components later on?

I suggest you to read this (http://stackoverflow.com/a/31638988/2304450) very good stack overflow answer, you'll find some interesting introduction to inline styles if that's what you were looking for.

A different approach could be to pass a `classScope` string props down to the components, and each component then applies it to the classes it uses (Example: return (); ). This way we could achieve better css selector scoping, at a cost of a slightly more verbose code when using a component.

Re: Show HN: A React.js yearly calendar component

#28

Post by GiovanniFrigo »

GiovanniFrigo wrote: post #27
hueking wrote: post #13

Sorry for asking this here, but I'm trying wrap my head around React. With the fact that we want to isolate styles for each component, how do we go about theming the components later on?

I suggest you to read this ( http://stackoverflow.com/a/31638988/2304450 ) very good stack overflow answer, you'll find some interesting introduction to inline styles if that's what you were looking for. A different approach could be to pass a `classScope` string props down to the components, and each component then applies it to the classes it uses (Example: return ( ); ). This way we could achieve better css select…

Also, you can get way more competent answers on reddit (/r/reactjs) or on stackoverflow :)

Re: Show HN: A React.js yearly calendar component

#29

Post by bmelton »

klkvsk wrote: post #21
HipstaJules wrote: post #17

Earlier quoted context omitted.

Is that comment really worth sharing on HN? I mean, I don't want to be rude - the English is ok, no problem here - but it's not useful at all, it's just complaining about a thing upvoted by 50 people. What's the purpose here?

I can tell from your own previous submissions that you are somehow affiliated with "belka.us", same company that open-sourced this calendar widget, so I am sure you were first here to upvote, and I understand why you are being so passive-aggresive now. But I really do not want HN to be a platform for such kind of self-promotion.

It's a "Show HN" article. From the "Show HN" rules:

> Show HN is for something you've made that other people can play with. HN users can try it out, give you feedback, and ask questions in the thread.

https://news.ycombinator.com/showhn.html

There is nothing even remotely inappropriate being done here, except for your comment, which violates the self-same rules:

> Be respectful. Anyone sharing work is making a contribution, however modest.

Re: Show HN: A React.js yearly calendar component

#30

Post by JoeAltmaier »

GiovanniFrigo wrote: post #23
klkvsk wrote: post #21

Earlier quoted context omitted.

I can tell from your own previous submissions that you are somehow affiliated with "belka.us", same company that open-sourced this calendar widget, so I am sure you were first here to upvote, and I understand why you are being so passive-aggresive now. But I really do not want HN to be a platform for such kind of self-promotion.

Yeah, we are belka.us and we are not ashamed of doing self-promotion here. I don't see what's wrong here: every company in the IT world releases open source components: Django, Bootstrap, Foundation and React itself are open source projects backed by companies. But there's also smaller things being released every day, and each of them contributes to the great world of open source. We use open source, we give back to…

You're doing fine; thanks for sharing!
Post reply on HN