Live data from Hacker News

Linus Torvalds did not commit this

github.com

41–50 of 198 posts

Re: Linus Torvalds did not commit this

#41
post #6

TBH we "exploit" this when accepting PRs for an open source project I work on. It's not really feasible for us to expect / force each PR author to have a clean commit history, so we basically do some squashing, then commit the "single" change as the original author before merging.

I don't think you need to do this? I may be wrong but I thought if you squash the author's commits git will still give the author credit for the commit.

Re: Linus Torvalds did not commit this

#42
post #4

Earlier quoted context omitted.

I guess the real uptake is that commits should really be signed by default (eg, by encouraging signing in the tools & ecosystem).

Really, this only becomes a problem when services like GitHub link the name up, making it look more legitimate than it is. If they enforced authentication as that user before providing the linking it would be better (perhaps allowing approval of the linking if posted by a different user). Currently it's trivial to make it look like any GitHub user is an actual committer to some sort of egregious or controversial proj…

Apparently Github doesn't list those faked commits in your profile. Which is anyway a problem because you could be "committing" to who knows what project project without being notified.

Re: Linus Torvalds did not commit this

#43

One workaround would be to remove any public email address you commit under from your Github profile. Github uses these email addresses to tie back to your user profile so if you don't want commits pointing at your profile, don't tie email addresses to your profile. Perhaps some mechanism is called for here for approving tying back to your user on new repositories or making any repository not owned by you or your org…

My github profile email is different from my git author email. The latter is even more accessible. Just run git-log on any repository an author has committed to.

Re: Linus Torvalds did not commit this

#44
post #14

In other words, a lot of people haven't the slightest clue how Git works. Luckily Github record push history separately

This is not just about Git, it's also that Github is implicitly trusting user data, by linking to the user profile.

In Git, it's clear that there's no authentication, a user is just a tuple of strings, but on Github the same doesn't apply, a user is actually a well defined entity which is secured by one or even two factors of authentication, so the expectations are different.

Re: Linus Torvalds did not commit this

#45

Also you may send email from any address you want if you put it in the “MAIL FROM” SMTP transaction. Thankfully the Linux kernel project accepts only signed commits.

> Thankfully the Linux kernel project accepts only signed commits. This is false, FWIW.

Indeed. Thanks for the correction! It requires signed patches, alas not with a cryptographic signature.

Re: Linus Torvalds did not commit this

#46
post #19

Earlier quoted context omitted.

Similarly, nothing stops you altering the time claimed in the commit. Or -- for that matter -- from taking someone's diff and claiming credit for it. For that reason, I jokingly created `git-upstage`, which streamlines the process of abusing commit edits and plagiarizing code! It squashes a branch, backdates it 5 minutes, and claims you wrote it. https://github.com/SilasX/git-upstage Edit: Looks like my last commit l…

I love this. Had a project in college that was supposed to be time limited... based on repository times. Oops. Big mistake prof. We rolled back the times on our repo and laughed maniacally about our free 6 hour extension.

...then procrastinated for 6 hours. Or is that just me?

Re: Linus Torvalds did not commit this

#47
Another example of why email addresses cannot serve as "identities" like so many people, somehow magically, assume.

If you know it, everything about email and its protocols would make you assume the exact opposite.

Now PGP signatures on the other hand … but hey, nobody wants those, right?! Far too complicated! /rant

Re: Linus Torvalds did not commit this

#48
I found that github's automatic identity resolution is actually helpful in some cases. I migrated a bzr repo into github recently and was pleasantly surprised to see my contributors matched up to their github accounts. I understand that many people might not want this, but it is a feature that can be useful.

Re: Linus Torvalds did not commit this

#49

Interesting, there must be some level of validation because it does not show up in his public activity feed[0] [0] https://github.com/torvalds?tab=activity

That's because there's a difference between a GitHub account (usually authenticated by a key) and a git commiter (only identified by the name and email). It would be pretty annoying if hundreds of commits popped up in his feed every time somebody forked Linux or git.

Re: Linus Torvalds did not commit this

#50
git should really make it possible to use openssh/openssl keys for signing - so that I have one key both to push to github and sign my commits. I know that they can be converted from one form to another ... but its really inconvenient, especially on Windows, etc.

The GPG key is designed for a email based collaboration flow - that Linus uses. But most of us use Github or Bitbucket's UI to collaborate.

Github/Bitbucket should use this key in their UI as well - to show verified users.

Post reply on HN