Git log in JSON format

#1

Post by adonisk » Sat, Jul 11, 2015, 10:41 PM UTC

Re: Git log in JSON format

#2

Post by rossy » Sun, Jul 12, 2015, 12:15 AM UTC

> What if there's a double quote in a commit message?

This is what I want to know too. Unless I'm missing something, it doesn't do any escaping. The last time I did something like this, I used %n and %x00 to delimit the output of git log, and converted it to a JavaScript object on the JavaScript side. Git log isn't smart enough to write JSON by itself.

Re: Git log in JSON format

#3

Post by lowmagnet » Sun, Jul 12, 2015, 12:29 AM UTC

Only somewhat related, the really neat tool code-maat[0] can do a lot with your commit data, but it uses plain CSV. It provides a bunch of canned reports you can run on your repo as well.

[0] https://github.com/adamtornhill/code-maat

Re: Git log in JSON format

#4

Post by lmitchell » Sun, Jul 12, 2015, 2:24 AM UTC

rossy wrote: post #2

> What if there's a double quote in a commit message? This is what I want to know too. Unless I'm missing something, it doesn't do any escaping. The last time I did something like this, I used %n and %x00 to delimit the output of git log, and converted it to a JavaScript object on the JavaScript side. Git log isn't smart enough to write JSON by itself.

I did something very similar for work last summer and we basically realized the same thing - null-delimited fields seemed like the only way to really be safe.

Re: Git log in JSON format

#5

Post by tracker1 » Sun, Jul 12, 2015, 4:21 AM UTC

rossy wrote: post #2

> What if there's a double quote in a commit message? This is what I want to know too. Unless I'm missing something, it doesn't do any escaping. The last time I did something like this, I used %n and %x00 to delimit the output of git log, and converted it to a JavaScript object on the JavaScript side. Git log isn't smart enough to write JSON by itself.

Agreed on better output to text, then process, but I'd suggest the record & group separators... It always surprises me when people use more exotic characters for something that's been defined forever (practically) in computer terms for this purpose.

http://www.theasciicode.com.ar/ascii-control-characters/reco...

Re: Git log in JSON format

#6

Post by m1el » Sun, Jul 12, 2015, 5:03 AM UTC

Every time I see people using printf to generate structured data formats, a part of me dies inside.

Here's how I would do it, using libgit2 and proper JSON output: https://gist.github.com/m1el/42472327b4be382b02eb

Re: Git log in JSON format

#7

Post by pjtr » Sun, Jul 12, 2015, 6:04 AM UTC

Mercurial has a properly designed extensible generic template system for that built-in.

  hg log -T json
  hg log -T xml
  hg status -T json
  hg tags -T json
  ...

Re: Git log in JSON format

#8

Post by jaseemabid » Sun, Jul 12, 2015, 8:41 AM UTC

m1el wrote: post #6

Every time I see people using printf to generate structured data formats, a part of me dies inside. Here's how I would do it, using libgit2 and proper JSON output: https://gist.github.com/m1el/42472327b4be382b02eb

Every time I see this pattern, a part of me dies inside.

    collection = []
    for i in data:
        collection.append(fn(i))

Why not just

    [fn(i) for i in data] ?

Re: Git log in JSON format

#9

Post by wingerlang » Sun, Jul 12, 2015, 9:08 AM UTC

jaseemabid wrote: post #8

m1el wrote: post #6

Every time I see people using printf to generate structured data formats, a part of me dies inside. Here's how I would do it, using libgit2 and proper JSON output: https://gist.github.com/m1el/42472327b4be382b02eb

Every time I see this pattern, a part of me dies inside. collection = [] for i in data: collection.append(fn(i)) Why not just [fn(i) for i in data] ?

First example is way, WAY, more readable. Honestly, if I didn't read the first one I would probably not have figured out what the other one does without research.

Re: Git log in JSON format

#10

Post by zokier » Sun, Jul 12, 2015, 9:10 AM UTC

jaseemabid wrote: post #8

m1el wrote: post #6

Every time I see people using printf to generate structured data formats, a part of me dies inside. Here's how I would do it, using libgit2 and proper JSON output: https://gist.github.com/m1el/42472327b4be382b02eb

Every time I see this pattern, a part of me dies inside. collection = [] for i in data: collection.append(fn(i)) Why not just [fn(i) for i in data] ?

If we are nitpicking then why not

    map(fn, data)

?