The Art of Code Review: A Dropbox Story

#1

Post by leahculver » Tue, Mar 10, 2015, 7:43 PM UTC

The Art of Code Review: A Dropbox Story
objc.io

Re: The Art of Code Review: A Dropbox Story

#2

Post by aston » Tue, Mar 10, 2015, 9:06 PM UTC

Also nice is the style guide, which also covers a number of best practices for modern Objective-C: https://dl.dropboxusercontent.com/s/5utnlwhr18ax05c/style-gu...

Re: The Art of Code Review: A Dropbox Story

#3

Post by kelukelugames » Tue, Mar 10, 2015, 9:14 PM UTC

aston wrote: post #2

Also nice is the style guide, which also covers a number of best practices for modern Objective-C: https://dl.dropboxusercontent.com/s/5utnlwhr18ax05c/style-gu...

Curious, has anyone adopted another company's published style guide?

Re: The Art of Code Review: A Dropbox Story

#4

Post by achompas » Tue, Mar 10, 2015, 9:15 PM UTC

kelukelugames wrote: post #3

aston wrote: post #2

Also nice is the style guide, which also covers a number of best practices for modern Objective-C: https://dl.dropboxusercontent.com/s/5utnlwhr18ax05c/style-gu...

Curious, has anyone adopted another company's published style guide?

At Knewton we used (use?) Google's Python style guide.

Re: The Art of Code Review: A Dropbox Story

#5

Post by krazydad » Tue, Mar 10, 2015, 9:21 PM UTC

Thank god there's a few dank memes to offset the bitter taste of the mountain of red-tape. Employee morale must be off-the-charts!

Re: The Art of Code Review: A Dropbox Story

#6

Post by spigoon » Tue, Mar 10, 2015, 9:49 PM UTC

kelukelugames wrote: post #3

aston wrote: post #2

Also nice is the style guide, which also covers a number of best practices for modern Objective-C: https://dl.dropboxusercontent.com/s/5utnlwhr18ax05c/style-gu...

Curious, has anyone adopted another company's published style guide?

At Tilt we use the NY Times Objective-C styleguide. https://github.com/NYTimes/objective-c-style-guide

Re: The Art of Code Review: A Dropbox Story

#7

Post by bshimmin » Tue, Mar 10, 2015, 10:09 PM UTC

I think this may very well be the most joyless article about software engineering I've ever read. The sort of weird tone of moderately enthused Newspeak is also quite frightening in a way.

Re: The Art of Code Review: A Dropbox Story

#8

Post by rikkus » Tue, Mar 10, 2015, 10:36 PM UTC

bshimmin wrote: post #7

I think this may very well be the most joyless article about software engineering I've ever read. The sort of weird tone of moderately enthused Newspeak is also quite frightening in a way.

Initially I thought it seemed unreal, with the way it was written, then I thought perhaps it was satire, but couldn't work out what was funny about it.

"Bask in our engineer’s prideful feeling that every single line now being added to the Dropbox for iOS app began as a task in Maniphest."

I follow a system just like this; it keeps things working smoothly, but I'm not sure I'm basking in any kind of pride over it.

Re: The Art of Code Review: A Dropbox Story

#9

Post by drisco » Tue, Mar 10, 2015, 11:02 PM UTC

Even though this might be best for the company and the product, does anyone else feel that big bureaucratic processes like this take away the joy and creativity of coding? I suppose it is because I'm more fond of coding as an art than as a science.

Re: The Art of Code Review: A Dropbox Story

#10

Post by krazydad » Tue, Mar 10, 2015, 11:05 PM UTC

drisco wrote: post #9

Even though this might be best for the company and the product, does anyone else feel that big bureaucratic processes like this take away the joy and creativity of coding? I suppose it is because I'm more fond of coding as an art than as a science.

Totally. While it seems appropriate that a product like Dropbox would require some very careful risk management and quality control, this feels like a joyless environment, despite the occasional use of memes in quality control threads.