Apple CoreGraphics framework logging input data to /tmp
1–10 of 26 posts
Re: Apple CoreGraphics framework logging input data to /tmp
#2Well every programmer probably made a mistake like that once, twice or more (or just, every programmers makes mistakes tout-court), but imo something like this should have been caught in the pull request/code review/general testing stage as it concerns a major OS? That being said I obviously have no idea what stages precede an actual release of an OS. Anyone does?
Re: Apple CoreGraphics framework logging input data to /tmp
#3Very very few OSX apps use an alternate allocator so this was probably not noticed. Having written a commercial memory allocator before (for MacOS prior to OSX) the one in OSX is actually quite good for most people. I don't know why Mozilla decided they needed jemalloc but maybe it tested better for their usage.
Still you would think tracking what's written to such a common directory would have been seen by someone at Apple. Firefox isn't exactly obscure.
Re: Apple CoreGraphics framework logging input data to /tmp
#4Well every programmer probably made a mistake like that once, twice or more (or just, every programmers makes mistakes tout-court), but imo something like this should have been caught in the pull request/code review/general testing stage as it concerns a major OS? That being said I obviously have no idea what stages precede an actual release of an OS. Anyone does?
More interesting, I think, would be seeing the code change itself, which might make it easier to work out how this got through code review / testing.
Re: Apple CoreGraphics framework logging input data to /tmp
#5Well every programmer probably made a mistake like that once, twice or more (or just, every programmers makes mistakes tout-court), but imo something like this should have been caught in the pull request/code review/general testing stage as it concerns a major OS? That being said I obviously have no idea what stages precede an actual release of an OS. Anyone does?
The bug is triggered by using a custom memory allocator. It's clearly an edge case. There will be bugs that slip over code review and/or testing no matter what. That's a fact in software development.
Re: Apple CoreGraphics framework logging input data to /tmp
#6I'm using Firefox Developer Edition, and I don't see any CGLog_* files in /tmp at all. Am I missing something?
Re: Apple CoreGraphics framework logging input data to /tmp
#7I'm using Firefox Developer Edition, and I don't see any CGLog_* files in /tmp at all. Am I missing something?
>This issue has been addressed in Mozilla products by explicitly turning off the framework's logging of input events.
It's fixed now and anything you had in there was already auto-deleted at some point. You're likely not missing anything.
Re: Apple CoreGraphics framework logging input data to /tmp
#8Very very few OSX apps use an alternate allocator so this was probably not noticed. Having written a commercial memory allocator before (for MacOS prior to OSX) the one in OSX is actually quite good for most people. I don't know why Mozilla decided they needed jemalloc but maybe it tested better for their usage. Still you would think tracking what's written to such a common directory would have been seen by someone a…
[deleted]
Re: Apple CoreGraphics framework logging input data to /tmp
#9Well every programmer probably made a mistake like that once, twice or more (or just, every programmers makes mistakes tout-court), but imo something like this should have been caught in the pull request/code review/general testing stage as it concerns a major OS? That being said I obviously have no idea what stages precede an actual release of an OS. Anyone does?
Erm...
goto fail;
goto fail;Re: Apple CoreGraphics framework logging input data to /tmp
#10Well every programmer probably made a mistake like that once, twice or more (or just, every programmers makes mistakes tout-court), but imo something like this should have been caught in the pull request/code review/general testing stage as it concerns a major OS? That being said I obviously have no idea what stages precede an actual release of an OS. Anyone does?
The bug is triggered by using a custom memory allocator. It's clearly an edge case. There will be bugs that slip over code review and/or testing no matter what. That's a fact in software development.
Sure, but the thing is: one developper (or a group of) said 'well let's enable this' and then nobody else reviewed that or thought 'hmm, surely it can't be good to just start logging pretty much everything'? Just wondering how that happens in large companies.