Hacker News Board Hacker News, browsed like a classic message board
Live data from Hacker News

Improvements to OCaml code editing: the basics of a refactor engine

tarides.com

Post reply on HN
Print view View original

1–10 of 21 posts

Re: Improvements to OCaml code editing: the basics of a refactor engine

#2

Post by panglesd »

Very cool!

Does it replace identical expressions in the same scope? Like:

    let tau = 3.14 +. 3.14
becomes

    let pi = 3.14
    let tau = pi +. pi
?

EDIT: Or even crazier with function:

    let _ = (x + 1) + (y + 1)
becomes

    let plus_one a = a + 1
    let _ = (plus_one x) + (plus_one y)
(I ask this just out of curiosity. Even the "simpler" version is very impressive!)

Re: Improvements to OCaml code editing: the basics of a refactor engine

#4

Post by nukifw »

panglesd wrote: post #2

Very cool! Does it replace identical expressions in the same scope? Like: let tau = 3.14 +. 3.14 becomes let pi = 3.14 let tau = pi +. pi ? EDIT: Or even crazier with function: let _ = (x + 1) + (y + 1) becomes let plus_one a = a + 1 let _ = (plus_one x) + (plus_one y) (I ask this just out of curiosity. Even the "simpler" version is very impressive!)

Nop, for the moment, we try to not "infer user usages"! But if you extract an expression with variable, there will be, obviously, not be repeated:

    let tau =
      let pi = 3.14 in 
      pi + pi
if we extract `pi + pi` it will lead (if you do not give any concrete name) to the following code:

    let fun_name1 pi = 
       pi + pi

    let tau = 
       let pi = 3.14 in 
       fun_name1 pi

Re: Improvements to OCaml code editing: the basics of a refactor engine

#7

Post by lemonwaterlime »

I’ve been working on similar refactoring and grepping utility functions for vim, though mine are meant to work in any language.

The most recent one I’ve made runs 'git grep' on the word under cursor or on the visual selection and puts everything into a quick fix list.

Since it is generic, it works on any phrases as well, and helps me find prose snippets and phrases in docs or other writings.

Re: Improvements to OCaml code editing: the basics of a refactor engine

#8

Post by mhitza »

Extract expression is such a common refactoring, happy to see support for it. I'm even more curious to see now if there are going to be more advanced refactoring possible. A List.map, to for loop, and back refactoring would be such a great thing to have in how I program.

Only thing that would go on my OCD nerve, is the lack of an empty newline when the show_markup function is extracted. Kind of "common sense" when writing top level bindings to leave some breathing room between them.

Re: Improvements to OCaml code editing: the basics of a refactor engine

#9

Post by nukifw »

mhitza wrote: post #8

Extract expression is such a common refactoring, happy to see support for it. I'm even more curious to see now if there are going to be more advanced refactoring possible. A List.map, to for loop, and back refactoring would be such a great thing to have in how I program. Only thing that would go on my OCD nerve, is the lack of an empty newline when the show_markup function is extracted. Kind of "common sense" when wr…

For the first point, you are right. We start by a common (but very useful) feature. Since OCaml allows an infinite level of nesting (and different kind of structure item) it was still a bit of a challenge, mostly for finding the right UX.

For the second point we delay the aeration convention to the formatter (ocamlformat). It can be configure in a different way :)

Thanks for your feedback!

Post reply on HN