Quake 3 Source Code Review

#1

Post by mgevans » Sat, Jun 30, 2012, 8:27 PM UTC

Quake 3 Source Code Review
fabiensanglard.net

Re: Quake 3 Source Code Review

#2

Post by hello_asdf » Sat, Jun 30, 2012, 9:40 PM UTC

I'm not really adding anything of value to this discussion, but I've always loved reading his code reviews. I have an unshaken belief in the genius that is John Carmack.

Re: Quake 3 Source Code Review

#3

Post by AaronMT » Sat, Jun 30, 2012, 10:27 PM UTC

Feels like yesterday that we (or at least some of us) we're all in awe with the released 'Q3Test' published online in 1999.

Re: Quake 3 Source Code Review

#4

Post by ehuss » Sun, Jul 01, 2012, 12:47 AM UTC

For those who may not be familiar with id's titles, this is a code review of the older idTech3 engine. He also recently published a code review for the newer idTech4 (Doom 3): http://fabiensanglard.net/doom3/index.php

His amazing site includes code reviews for several other id software titles.

Re: Quake 3 Source Code Review

#5

Post by [deleted] » Sun, Jul 01, 2012, 1:29 AM UTC

[deleted]

Re: Quake 3 Source Code Review

#6

Post by rangibaby » Sun, Jul 01, 2012, 2:19 AM UTC

AaronMT wrote: post #3

Feels like yesterday that we (or at least some of us) we're all in awe with the released 'Q3Test' published online in 1999.

Oh yeah. Flashback to the 90s: I got Q3Test with some magazine's cover CD and had barely-56k internet at the time so couldn't play FPSes at home until CS got popular, but that didn't matter - I was too busy wandering around the included level with my jaw on the desk.

Re: Quake 3 Source Code Review

#7

Post by ibrow » Sun, Jul 01, 2012, 8:32 AM UTC

This is really very interesting stuff, and what a great site.

Are there any other resources out there that offer code reviews like this? Reviewing others code really is a great way to improve your own.

Re: Quake 3 Source Code Review

#8

Post by Muzza » Sun, Jul 01, 2012, 9:18 AM UTC

This might be OT, but that guy sure has some weird ideas about how to build a website.

Why are the images lazy loaded? There are like ten small images per page. It also doesn't revert to img tags in the absence of Javascript.

At one point on the first page he needs to show something with a fixed-width font. This also requires Javascript, when obviously CSS should do.

Re: Quake 3 Source Code Review

#9

Post by skrebbel » Sun, Jul 01, 2012, 9:28 AM UTC

hello_asdf wrote: post #2

I'm not really adding anything of value to this discussion, but I've always loved reading his code reviews. I have an unshaken belief in the genius that is John Carmack.

I genuinely doubt Carmack is the only competent coder at id. Some of the really good ideas in here might be made up by others!

Re: Quake 3 Source Code Review

#10

Post by hcles » Sun, Jul 01, 2012, 9:53 AM UTC

Muzza wrote: post #8

This might be OT, but that guy sure has some weird ideas about how to build a website. Why are the images lazy loaded? There are like ten small images per page. It also doesn't revert to img tags in the absence of Javascript. At one point on the first page he needs to show something with a fixed-width font. This also requires Javascript, when obviously CSS should do.

Most people will visit the page, scroll down a screen or two and leave it since they're not game programmers.

So, just speculating, he's no stranger to bandwidth spikes so perhaps the approach employed significantly saves on bandwidth during these periods, ultimately whether it's a conscious attempt to save or just a webdev quirk I don't know.