Ruby Heaps Inspired by Python
homo-sapiens-reviewed.bearblog.dev
Ruby Heaps Inspired by Python
1–3 of 3 posts
Re: Ruby Heaps Inspired by Python
#2Nice. This is interesting and definitely something worth implementing. I hope you don't mind but I have some discussion points.
If it were me, rather than monkey patching array I'd be tempted introduce a new dedicated Heap class that implements existing API (push, pop, As well as better duck typing this allows introspection via .is_a? and case statements.
Also I wonder if it would be useful to base the implementation on the Queue[1] rather than Array to maintain thread safety.
Re: Ruby Heaps Inspired by Python
#3Nice. This is interesting and definitely something worth implementing. I hope you don't mind but I have some discussion points. If it were me, rather than monkey patching array I'd be tempted introduce a new dedicated Heap class that implements existing API (push, pop, As well as better duck typing this allows introspection via .is_a? and case statements. Also I wonder if it would be useful to base the implementation…
Defining a new class is probably the most Ruby way to do it. There are two implementations that define a new class: rb_heap[1] and algorithms[2]. However, algorithms[2] use a Fibonacci heap, which should technically have better time complexity but is slower in practice, and the library pulls in a lot of unnecessary stuff. rb_heap is good, although I think using a symbol to specify if it's a max/min heap is a little strange.
There is something satisfying about using an array like Python. It's very straightforward and doesn't require you to convert back and forth between a queue and a array.
That's an interesting idea to use Queue. I do need random access to implement the binary queue, so I'm not sure if Queue would work.
1. https://github.com/florian/rb_heap 2. https://github.com/kanwei/algorithms