Counting website hits using Cloudflare workers

#1

Post by asadawadia » Mon, Jul 03, 2023, 5:10 PM UTC

Counting website hits using Cloudflare workers
blog.aawadia.dev

Re: Counting website hits using Cloudflare workers

#2

Post by kentonv » Mon, Jul 03, 2023, 5:26 PM UTC

Nice tutorial. One catch:

    // asynchronously make the request to the counter service
    // don't wait for this to finish before responding back to the client
    fetch("https://api/" + counterName, requestOptions)

I would recommend wrapping this in `event.waitUntil()`, like:

    event.waitUntil(fetch("https://api/" + counterName, requestOptions))

Otherwise, the Workers Runtime will cancel this call as soon as the top-level response is returned. That may not be causing any trouble here because the cancellation happens too late to actually have an effect (the cancellation would manifest as the HTTP connection to the counter API being closed, but by the time it notices it has probably already finished incrementing the counter). Still, it's a good idea to be safe add add the waitUntil().

Re: Counting website hits using Cloudflare workers

#3

Post by asadawadia » Mon, Jul 03, 2023, 6:04 PM UTC

kentonv wrote: post #2

Nice tutorial. One catch: // asynchronously make the request to the counter service // don't wait for this to finish before responding back to the client fetch("https://api/" + counterName, requestOptions) I would recommend wrapping this in `event.waitUntil()`, like: event.waitUntil(fetch("https://api/" + counterName, requestOptions)) Otherwise, the Workers Runtime will cancel this call as soon as the top-level respo…

Ah, Thanks! Didn't consider/know that