Microsoft team submits Redis patch to enable Windows support

#1

Post by aaronlerch » Thu, Dec 08, 2011, 8:03 PM UTC

Microsoft team submits Redis patch to enable Windows support
github.com

Re: Microsoft team submits Redis patch to enable Windows support

#2

Post by [deleted] » Thu, Dec 08, 2011, 8:04 PM UTC

[deleted]

Re: Microsoft team submits Redis patch to enable Windows support

#3

Post by jrockway » Thu, Dec 08, 2011, 8:54 PM UTC

Embrace, extend, extinguish.

Does Redis still do that thing where it forks and the child writes its core to disk? How does that work under Windows, which doesn't have fork?

Finally, this is one big patch:

    339 files changed, 146821 insertions(+), 290 deletions(-)

With many of the changes along the lines of:

     static void *callbackValDup(void *privdata, const void *src) {
    -    ((void) privdata);
         redisCallback *dup = malloc(sizeof(*dup));
    +    ((void) privdata);
         memcpy(dup,src,sizeof(*dup));
         return dup;
     }

or

    -    cmd = malloc(totlen+1);
    +    cmd = (char*)malloc(totlen+1);

Eliminating compiler warnings is nice and whatever, but probably not the best thing to include in your "add major feature" patch.

Re: Microsoft team submits Redis patch to enable Windows support

#4

Post by splitbrain » Thu, Dec 08, 2011, 8:55 PM UTC

A patch file in a gist instead of a pull request? sigh

Re: Microsoft team submits Redis patch to enable Windows support

#5

Post by donspaulding » Thu, Dec 08, 2011, 8:57 PM UTC

The README on that gist reminds me how fortunate I am to work with Ubuntu servers. Building redis from source on Linux is literally "git clone https://github.com/antirez/redis && cd redis && make". And that's the hard way to install things in DebianLand.

Re: Microsoft team submits Redis patch to enable Windows support

#6

Post by aaronlerch » Thu, Dec 08, 2011, 8:57 PM UTC

splitbrain wrote: post #4

A patch file in a gist instead of a pull request? sigh

That was my first thought too. :)

Re: Microsoft team submits Redis patch to enable Windows support

#7

Post by vier » Thu, Dec 08, 2011, 9:00 PM UTC

Using libuv from Node.js too. Awesome.

Re: Microsoft team submits Redis patch to enable Windows support

#8

Post by diminish » Thu, Dec 08, 2011, 9:00 PM UTC

splitbrain wrote: post #4

A patch file in a gist instead of a pull request? sigh

can someone please submit a patch to MS to add git pull support to team foundation server or visual sourcesafe (or what are MS guys using these days as version control?)

Re: Microsoft team submits Redis patch to enable Windows support

#9

Post by atuladhar » Thu, Dec 08, 2011, 9:01 PM UTC

jrockway wrote: post #3

Embrace, extend, extinguish. Does Redis still do that thing where it forks and the child writes its core to disk? How does that work under Windows, which doesn't have fork? Finally, this is one big patch: 339 files changed, 146821 insertions(+), 290 deletions(-) With many of the changes along the lines of: static void *callbackValDup(void *privdata, const void *src) { - ((void) privdata); redisCallback *dup = malloc(…

Not sure what they're going to do regarding fork, but they say this at the end of the gist:

TODO

    Snapshotting (Fork and Write) is not perfect, right now we simply block requests while memory is dumped on disk. We are working on a solution that will give us better performance. An update will be released soon.

Re: Microsoft team submits Redis patch to enable Windows support

#10

Post by burke » Thu, Dec 08, 2011, 9:01 PM UTC

jrockway wrote: post #3

Embrace, extend, extinguish. Does Redis still do that thing where it forks and the child writes its core to disk? How does that work under Windows, which doesn't have fork? Finally, this is one big patch: 339 files changed, 146821 insertions(+), 290 deletions(-) With many of the changes along the lines of: static void *callbackValDup(void *privdata, const void *src) { - ((void) privdata); redisCallback *dup = malloc(…

There are 453 mentions of "fork" in the patch, so I'm imagining it does.