Hacker News Board Hacker News, browsed like a classic message board
Live data from Hacker News

Grep one-liners as CI tasks

phili.pe

Post reply on HN
Print view View original

1–10 of 36 posts

Re: Grep one-liners as CI tasks

#3

Post by gravypod »

I think this is a great example of where build systems, that understand the need for testing, can help out. In a build system I use quite often (Bazel) you can express this as an `sh_test()` [0] which provides documentation about what you're attempting to do and provides you with a way to reproduce the failure locally. You don't have to push the code and wait for CI to fail to find out, or debug, this error.

Extra fun thing to do: print a message describing why the decision was made and how to resolve the error in the failure message of your test!

[0] - https://docs.bazel.build/versions/main/be/shell.html#sh_test

Re: Grep one-liners as CI tasks

#5

Post by jeffbee »

grep and other shell tool one-liners also make excellent kubernetes liveness checks. I have some kubernetes daemonsets that don't do anything other than assert that things on the node are as they should, via grep exit status.

Re: Grep one-liners as CI tasks

#6

Post by david_allison »

Android's default linting already contains a "missing translation" lint rule which you can activate: "MissingTranslation"[0]

For Android specifically: Gradle and Android Studio both support a powerful linting framework (to the level that it can provide auto-fixes to the IDE). It's better to provide an in-editor to guide your contributors before it hits CI, then have CI nag if they didn't fix the in-editor warnings/errors:

Some examples of custom lint rules[1] and the default rules which Android Studio runs[2]:

[0] https://android.googlesource.com/platform/tools/base/+/32923...

[1] https://github.com/ankidroid/Anki-Android/tree/master/lint-r...

[2] https://github.com/ankidroid/Anki-Android/blob/master/lint-r...

Re: Grep one-liners as CI tasks

#7

Post by excircul »

> I personally prefer ripgrep as it is much faster than grep, but usually that is not available on CI machines.

I recommend git grep, which is comparable in speed to ripgrep, since it ignores non-tracked files and searches the object storage directly. It is also able to run in parallel.

Re: Grep one-liners as CI tasks

#8

Post by cfors »

In today's world of excellent CLI tools I don't think grep is a good choice, especially for checking irregular languages like XML. [0]

I use tools like `jq` [1] or `yq` [2] all the time for CI checks. One useful check, is we have a configuration file stored as several hundred lines of YAML. Its a nice thing to maintain a sorted order for that, so we have a git pre-commit hook that runs the following:

> yq eval --inplace '.my_key|= sort' my_file.yaml

Of course, a pre-commit hook or CI both work. There's pros and cons of both. For our team, the pre-commit hook is a low enough level of effort, and doesn't require a CI check for something that executes in milliseconds.

[0] https://stackoverflow.com/a/1732454

[1] https://github.com/stedolan/jq

[2] https://github.com/mikefarah/yq

Re: Grep one-liners as CI tasks

#9

Post by jrockway »

Don't you worry about what happens when the translation software produces a semantically equivalent empty string, or something? Like ``. An XML parser will find that to be empty, grep will be like "ooh lots of text in there".
Post reply on HN