Code Review as a Service
pullrequest.com
Code Review as a Service
1–10 of 238 posts
Re: Code Review as a Service
#2Interested to know if anyone has used this service or similar and what the quality is like.
Re: Code Review as a Service
#3Interested to know if anyone has used this service or similar and what the quality is like.
It is new to me, but raises a concern that they could only review for general engineering quality, not whether or not a PR is appropriate to a codebase. How would they know if the same problem has already been solved elsewhere, that no wheels are being re-invented, or that a PR is stepping on the toes of something else the team is working on.
Because that is the value I've found in code reviews - not generic "is this code elegant?", but "does this code play well with what everyone else is doing?"
Re: Code Review as a Service
#4> expert engineers backed by best-in-class automation.
"Automation" = static analysis or something like https://codeql.github.com/?
Re: Code Review as a Service
#5I will admit that I thought this was a joke on the "SaaS" everything trend.
I can see how this works for fairly limited web applications for example, but as soon as the application grows in complexity and interacts within a bigger system of systems, I am doubtful that it would be logistically possible to outsource the code review (legally, knowledge transfer wise, and a plethora of other angles I'm a tad bit lazy to consider).
Overall, why not, if it's priced correctly, then it's probably a set of additional eyes for small projects. But for anything medium or higher, yeah, I don't see this realistically working.
Maybe OP (?) can explain if I'm wrong (very likely). There's probably something I'm missing.
Re: Code Review as a Service
#6Saw this link here in the past. Didn’t pickup. The reason why I don’t like it is that random people, regardless their expertise, cannot just review PRs and understand the impact of the change on the system without being deeply involved in the product.
Re: Code Review as a Service
#7Having on-demand engineers look at code, without broader context on the project it is in my view the same as something that can be automated either or both via static analysis and custom ci/cd workflow checks. This can probably makes sense on a project with more junior engineers where many basic improvements can be supposedly suggested without needing broader context? I would be keen on hearing the use case
Re: Code Review as a Service
#8Saw this link here in the past. Didn’t pickup. The reason why I don’t like it is that random people, regardless their expertise, cannot just review PRs and understand the impact of the change on the system without being deeply involved in the product.
Nor can arbitrary people weigh the balance between accepting technical debt and shipping a feature.
It involves a risk / benefit analysis.
On the other hand, maybe you can build a relationship with contractors that focus on reviewing code. And maybe it can give insights your team won't have?
Re: Code Review as a Service
#9There's no way that Google would actually use this service.
Re: Code Review as a Service
#10I will admit that I thought this was a joke on the "SaaS" everything trend. I can see how this works for fairly limited web applications for example, but as soon as the application grows in complexity and interacts within a bigger system of systems, I am doubtful that it would be logistically possible to outsource the code review (legally, knowledge transfer wise, and a plethora of other angles I'm a tad bit lazy to…
My thought is the same - I was wondering if I had missed something!
I really need to find a good mentor for our project :(