Hacker News Board Hacker News, browsed like a classic message board
Live data from Hacker News

Detecting integer constant expressions in macros

lkml.org

Post reply on HN
Print view View original

1–10 of 25 posts

Re: Detecting integer constant expressions in macros

#4

Post by Someone1234 »

chrisseldo wrote: post #3

"I'm in awe of your truly marvelously disgusting hack. That is truly a work of art." Ha. How should one take such a comment?

I'd take it as a complement.

Calling something a "disgusting hack," isn't inherently insulting, it is just a description of how well self documenting and obvious its workings are, which in this case is not at all. Whereas calling something a "work of art" particularly from Linus is high praise.

And while there is some subjectivity to if something is a "hack" or not, the original author doesn't even seem to contend that too much. They were more interested in pointing out that this method likely works across compilers (since it relies on less undefined behaviour than it might first appear).

In any case, it is a neat trick, that I wouldn't want to run across in a codebase since I'd have to spend too long figuring it out.

Re: Detecting integer constant expressions in macros

#6

Post by chrisseldo »

Someone1234 wrote: post #4
chrisseldo wrote: post #3

"I'm in awe of your truly marvelously disgusting hack. That is truly a work of art." Ha. How should one take such a comment?

I'd take it as a complement. Calling something a "disgusting hack," isn't inherently insulting, it is just a description of how well self documenting and obvious its workings are, which in this case is not at all. Whereas calling something a "work of art" particularly from Linus is high praise. And while there is some subjectivity to if something is a "hack" or not, the original author doesn't even seem to contend th…

I agree with you - I think I would take it as a compliment as well. Also, I take back my original post on what the best comment is in this post. This is better:

"this will break the minds of everybody who ever sees that expression"

Re: Detecting integer constant expressions in macros

#7

Post by kthejoker2 »

chrisseldo wrote: post #3

"I'm in awe of your truly marvelously disgusting hack. That is truly a work of art." Ha. How should one take such a comment?

I think in this life at least all that's left for Linus to enjoy are marvelously disgusting hacks. So with that understanding this is probably the ultimate compliment.
Post reply on HN