OpenTable Daily Algorithm Challenge

#1

Post by jmsuth » Mon, Feb 06, 2017, 8:17 PM UTC

OpenTable Daily Algorithm Challenge
github.com

Re: OpenTable Daily Algorithm Challenge

#2

Post by doesnotexist » Mon, Feb 06, 2017, 8:59 PM UTC

I'm not sure if this is intentional or not but the "official" solution to today's challenge appears to have a bug.

https://github.com/opentable/ot-daily-algorithm/commit/e811a...

It will return true even when the tree is not a valid BST. Consider the case where a leaf in the left subtree contains a value higher than the root of the tree.

Re: OpenTable Daily Algorithm Challenge

#3

Post by jschapiro » Mon, Feb 06, 2017, 9:08 PM UTC

doesnotexist wrote: post #2

I'm not sure if this is intentional or not but the "official" solution to today's challenge appears to have a bug. https://github.com/opentable/ot-daily-algorithm/commit/e811a... It will return true even when the tree is not a valid BST. Consider the case where a leaf in the left subtree contains a value higher than the root of the tree.

@doesnotexist great point. With that said, that is not the official solution. There is no official solution. This is a community driven repo. Anyone can contribute.