Live data from Hacker News

Abandoning Gitflow and GitHub in favour of Gerrit

beepsend.com

1–10 of 168 posts

Re: Abandoning Gitflow and GitHub in favour of Gerrit

#2

  The process might seem more complex initially but think
  of it like this: If you add a new member to your team, 
  they would have to fork the repositories on GitHub, clone 
  them locally, make the changes, push to their own fork 
  and then create the pull request
Annndddd we're done - its easy to make a pull request from a branch; this person has no idea what they're doing.

In addition, the new GitHub code review tools address most (if not all) of the stated reasons for this switch. And in my opinion, GitHub's ease-of-use, alongside it being an incredible single point of reference, far outweigh any clunky other tools I've used (like Gerrit).

Re: Abandoning Gitflow and GitHub in favour of Gerrit

#3
We tried Gerrit. We ran as fast as possible away. It seemed to hate merge commits, and would hang up often. I'm not sure if it's changed at all, but I think the only option was to review every commit individually inside of a branch. It seemed to really be pushing us towards squashing a branch and pushing that up.

Re: Abandoning Gitflow and GitHub in favour of Gerrit

#4

The process might seem more complex initially but think of it like this: If you add a new member to your team, they would have to fork the repositories on GitHub, clone them locally, make the changes, push to their own fork and then create the pull request Annndddd we're done - its easy to make a pull request from a branch; this person has no idea what they're doing. In addition, the new GitHub code review tools addr…

> Annndddd we're done

I stopped reading exactly there, I knew that something was amiss. We followed that workflow at my last job, it worked well.

Re: Abandoning Gitflow and GitHub in favour of Gerrit

#5
post #3

We tried Gerrit. We ran as fast as possible away. It seemed to hate merge commits, and would hang up often. I'm not sure if it's changed at all, but I think the only option was to review every commit individually inside of a branch. It seemed to really be pushing us towards squashing a branch and pushing that up.

> I'm not sure if it's changed at all, but I think the only option was to review every commit individually inside of a branch. It seemed to really be pushing us towards squashing a branch and pushing that up.

The author mentions this as being a feature of Gerrit in the post.

Re: Abandoning Gitflow and GitHub in favour of Gerrit

#6

The process might seem more complex initially but think of it like this: If you add a new member to your team, they would have to fork the repositories on GitHub, clone them locally, make the changes, push to their own fork and then create the pull request Annndddd we're done - its easy to make a pull request from a branch; this person has no idea what they're doing. In addition, the new GitHub code review tools addr…

I've used gerrit and it's much better than github/bitbucket. My knock on gerrit is it requires one "very good" git person to be on the team however it makes it very easy to support a larger team and do cleaner code reviews.

Re: Abandoning Gitflow and GitHub in favour of Gerrit

#7

The process might seem more complex initially but think of it like this: If you add a new member to your team, they would have to fork the repositories on GitHub, clone them locally, make the changes, push to their own fork and then create the pull request Annndddd we're done - its easy to make a pull request from a branch; this person has no idea what they're doing. In addition, the new GitHub code review tools addr…

Heh, I literally had the same quote in buffer and was coming to make the same comment. Clearly they don't know how GitHub works.

Re: Abandoning Gitflow and GitHub in favour of Gerrit

#8
post #3

We tried Gerrit. We ran as fast as possible away. It seemed to hate merge commits, and would hang up often. I'm not sure if it's changed at all, but I think the only option was to review every commit individually inside of a branch. It seemed to really be pushing us towards squashing a branch and pushing that up.

Gerrit does favor rebasing over merging but that's hardly a reason to run away from it

Re: Abandoning Gitflow and GitHub in favour of Gerrit

#9
What I miss in article is for how long they are on it. Is author after peak of inflated expectations?

I have used Gerrit in my previous team and it did not worked so well. Hanging vetos on -2 are not that nice when you have to push feature forward, like instead of blocking it someone else could just fix it, by the time you talked person who put -2 to change it to -1. But maybe with more mature team it would not be a problem.

Re: Abandoning Gitflow and GitHub in favour of Gerrit

#10
"If you add a new member to your team, they would have to fork the repositories on GitHub, clone them locally, make the changes, push to their own fork and then create the pull request."

You don't have to do this with Github. Just clone directly to your local machine. Also, you don't have to use git flow when using Github. I think git flow seems to be the real culprit of the symptoms you have identified.

Post reply on HN